From: Julia Lawall <julia.lawall@lip6.fr>
To: Namrata A Shettar <namrataashettar@gmail.com>
Cc: Ian Abbott <abbotti@mev.co.uk>,
hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
badbuddha91@gmail.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
Date: Tue, 13 Sep 2016 09:27:11 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.10.1609130926080.3355@hadrien> (raw)
In-Reply-To: <CAFrQyDErWX1NgsruZtt10hihZR2J3cvK-Q9Zj_dp_GLc_0mLmA@mail.gmail.com>
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1456 bytes --]
On Tue, 13 Sep 2016, Namrata A Shettar wrote:
> This patch removes an unnecessary blank line that caused checkpatch issue.
Actually, commit messages and subject lines should be written in the
imperative. So you should say eg
Remove unnecessary blank line
instead of
Removes unnecessary blank line
julia
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> Changes in v2:
> - Changed the subject line
> - Changed description of patch
>
> drivers/staging/comedi/comedi_pcmcia.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/comedi_pcmcia.c
> b/drivers/staging/comedi/comedi_pcmcia.c
> index d7072a5..ec8a0ad 100644
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
>
> #include <linux/module.h>
> #include <linux/kernel.h>
> -
> #include "comedi_pcmcia.h"
>
> /**
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDErWX1NgsruZtt10hi
> hZR2J3cvK-Q9Zj_dp_GLc_0mLmA%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
next prev parent reply other threads:[~2016-09-13 7:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 6:21 [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Namrata A Shettar
2016-09-13 7:27 ` Julia Lawall [this message]
2016-09-13 7:33 ` [Outreachy kernel] " Arnd Bergmann
2016-09-13 9:36 ` Julia Lawall
2016-09-13 9:53 ` Namrata A Shettar
2016-09-13 9:57 ` Julia Lawall
2016-09-13 10:18 ` Namrata A Shettar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.10.1609130926080.3355@hadrien \
--to=julia.lawall@lip6.fr \
--cc=abbotti@mev.co.uk \
--cc=badbuddha91@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=namrataashettar@gmail.com \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.