All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: outreachy-kernel@googlegroups.com
Cc: Namrata A Shettar <namrataashettar@gmail.com>,
	Ian Abbott <abbotti@mev.co.uk>,
	hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
	badbuddha91@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line
Date: Tue, 13 Sep 2016 09:33:51 +0200	[thread overview]
Message-ID: <2284008.DIPsHg5UWl@wuerfel> (raw)
In-Reply-To: <CAFrQyDErWX1NgsruZtt10hihZR2J3cvK-Q9Zj_dp_GLc_0mLmA@mail.gmail.com>

On Tuesday, September 13, 2016 11:51:53 AM CEST Namrata A Shettar wrote:
> --- a/drivers/staging/comedi/comedi_pcmcia.c
> +++ b/drivers/staging/comedi/comedi_pcmcia.c
> @@ -18,7 +18,6 @@
> 
>  #include <linux/module.h>
>  #include <linux/kernel.h>
> -
>  #include "comedi_pcmcia.h"
> 
>  /**
> 

I would argue that checkpatch is wrong here, it's very common to have
an empty line between the global and the local header files.

	Arnd



  parent reply	other threads:[~2016-09-13  7:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-13  6:21 [PATCH v2] staging: comedi: comedi_pcmcia: Removes unnecessary blank line Namrata A Shettar
2016-09-13  7:27 ` [Outreachy kernel] " Julia Lawall
2016-09-13  7:33 ` Arnd Bergmann [this message]
2016-09-13  9:36   ` Julia Lawall
2016-09-13  9:53     ` Namrata A Shettar
2016-09-13  9:57       ` Julia Lawall
2016-09-13 10:18         ` Namrata A Shettar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2284008.DIPsHg5UWl@wuerfel \
    --to=arnd@arndb.de \
    --cc=abbotti@mev.co.uk \
    --cc=badbuddha91@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsweeten@visionengravers.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namrataashettar@gmail.com \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.