All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] staging: octeon: remove multiple blank lines
@ 2016-09-14  0:26 Gargi Sharma
  2016-09-14  5:23 ` [Outreachy kernel] " Alison Schofield
  2016-09-14  5:49 ` Julia Lawall
  0 siblings, 2 replies; 3+ messages in thread
From: Gargi Sharma @ 2016-09-14  0:26 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh, Gargi Sharma

Fixes the checkpatch issue Please don't use multiple blank lines.
---
Changes in v2
	- Change the commit subject to :Correcting the commit
	  message. Fixes the checkpatch issue Please don't use multiple
	  blank lines.
---
Changes in v3
	- Make the commit message more clearer. Also, fixed the subject
	  mistake in v2.

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
 drivers/staging/octeon/ethernet.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 0bd5c18..ec8e424 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
 		return -EINVAL;
 	}
 
-
 	cvm_oct_configure_common_hw();
 
 	cvmx_helper_initialize_packet_io_global();
@@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
 		}
 	}
 
-
 	cvmx_pko_shutdown();
 
 	cvmx_ipd_free_ptr();
-- 
2.9.2



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] staging: octeon: remove multiple blank lines
  2016-09-14  0:26 [PATCH v3] staging: octeon: remove multiple blank lines Gargi Sharma
@ 2016-09-14  5:23 ` Alison Schofield
  2016-09-14  5:49 ` Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2016-09-14  5:23 UTC (permalink / raw)
  To: Gargi Sharma; +Cc: outreachy-kernel, gregkh

On Wed, Sep 14, 2016 at 05:56:52AM +0530, Gargi Sharma wrote:
> Fixes the checkpatch issue Please don't use multiple blank lines.
> ---
> Changes in v2
> 	- Change the commit subject to :Correcting the commit
> 	  message. Fixes the checkpatch issue Please don't use multiple
> 	  blank lines.
> ---
> Changes in v3
> 	- Make the commit message more clearer. Also, fixed the subject
> 	  mistake in v2.
> 
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
  Changes in v4
	- moved the version history down here. 

	Take a look at some patches in mailing lists with v# and you'll
	see how it's done.  The version history goes after the Signed off
	and after the --- but you don't repeat the --- for each version.
	  

>  drivers/staging/octeon/ethernet.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 0bd5c18..ec8e424 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>  
> -
>  	cvm_oct_configure_common_hw();
>  
>  	cvmx_helper_initialize_packet_io_global();
> @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
>  		}
>  	}
>  
> -
>  	cvmx_pko_shutdown();
>  
>  	cvmx_ipd_free_ptr();
> -- 
> 2.9.2
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914002652.12359-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] staging: octeon: remove multiple blank lines
  2016-09-14  0:26 [PATCH v3] staging: octeon: remove multiple blank lines Gargi Sharma
  2016-09-14  5:23 ` [Outreachy kernel] " Alison Schofield
@ 2016-09-14  5:49 ` Julia Lawall
  1 sibling, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2016-09-14  5:49 UTC (permalink / raw)
  To: Gargi Sharma; +Cc: outreachy-kernel, gregkh

On Wed, 14 Sep 2016, Gargi Sharma wrote:

> Fixes the checkpatch issue Please don't use multiple blank lines.
> ---
> Changes in v2
> 	- Change the commit subject to :Correcting the commit
> 	  message. Fixes the checkpatch issue Please don't use multiple
> 	  blank lines.
> ---
> Changes in v3
> 	- Make the commit message more clearer. Also, fixed the subject
> 	  mistake in v2.

You only need one ---, no matter how much text you want to write.  It
would be better for the v3 stuff to come first, since that is the most
relevant for the person who has been following along.

julia



>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
>  drivers/staging/octeon/ethernet.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
> index 0bd5c18..ec8e424 100644
> --- a/drivers/staging/octeon/ethernet.c
> +++ b/drivers/staging/octeon/ethernet.c
> @@ -686,7 +686,6 @@ static int cvm_oct_probe(struct platform_device *pdev)
>  		return -EINVAL;
>  	}
>
> -
>  	cvm_oct_configure_common_hw();
>
>  	cvmx_helper_initialize_packet_io_global();
> @@ -929,7 +928,6 @@ static int cvm_oct_remove(struct platform_device *pdev)
>  		}
>  	}
>
> -
>  	cvmx_pko_shutdown();
>
>  	cvmx_ipd_free_ptr();
> --
> 2.9.2
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914002652.12359-1-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14  5:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14  0:26 [PATCH v3] staging: octeon: remove multiple blank lines Gargi Sharma
2016-09-14  5:23 ` [Outreachy kernel] " Alison Schofield
2016-09-14  5:49 ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.