* [PATCH] staging: dgnc: Fix alignment with open parentheses
@ 2016-09-14 15:33 Rehas Sachdeva
2016-09-14 19:12 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Rehas Sachdeva @ 2016-09-14 15:33 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
This patch removes the checkpatch.pl warning:
CHECK: Alignment should match open parenthesis.
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
drivers/staging/dgnc/dgnc_tty.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index 31b18e6..75e0a6b 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
* ch_flags_wait to wake us back up.
*/
rc = wait_event_interruptible(ch->ch_flags_wait,
- (((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
- UN_CLOSING) == 0));
+ (((ch->ch_tun.un_flags |
+ ch->ch_pun.un_flags) &
+ UN_CLOSING) == 0));
/* If ret is non-zero, user ctrl-c'ed us */
if (rc)
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix alignment with open parentheses
2016-09-14 15:33 [PATCH] staging: dgnc: Fix alignment with open parentheses Rehas Sachdeva
@ 2016-09-14 19:12 ` Julia Lawall
2016-09-14 19:37 ` Rehas Sachdeva
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2016-09-14 19:12 UTC (permalink / raw)
To: Rehas Sachdeva
Cc: outreachy-kernel, Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
On Wed, 14 Sep 2016, Rehas Sachdeva wrote:
> This patch removes the checkpatch.pl warning:
> CHECK: Alignment should match open parenthesis.
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_tty.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index 31b18e6..75e0a6b 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
> * ch_flags_wait to wake us back up.
> */
> rc = wait_event_interruptible(ch->ch_flags_wait,
> - (((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
> - UN_CLOSING) == 0));
> + (((ch->ch_tun.un_flags |
> + ch->ch_pun.un_flags) &
> + UN_CLOSING) == 0));
Bother are not so nice, but maybe it was better before. It's nice to have
at least both arguments to | on the same line.
julia
>
> /* If ret is non-zero, user ctrl-c'ed us */
> if (rc)
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914153331.GA22396%40toblerone.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix alignment with open parentheses
2016-09-14 19:12 ` [Outreachy kernel] " Julia Lawall
@ 2016-09-14 19:37 ` Rehas Sachdeva
0 siblings, 0 replies; 3+ messages in thread
From: Rehas Sachdeva @ 2016-09-14 19:37 UTC (permalink / raw)
To: Julia Lawall
Cc: outreachy-kernel, Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
On Wed, Sep 14, 2016 at 09:12:19PM +0200, Julia Lawall wrote:
> On Wed, 14 Sep 2016, Rehas Sachdeva wrote:
>
> > This patch removes the checkpatch.pl warning:
> > CHECK: Alignment should match open parenthesis.
> >
> > Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> > ---
> > drivers/staging/dgnc/dgnc_tty.c | 5 +++--
> > 1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> > index 31b18e6..75e0a6b 100644
> > --- a/drivers/staging/dgnc/dgnc_tty.c
> > +++ b/drivers/staging/dgnc/dgnc_tty.c
> > @@ -1037,8 +1037,9 @@ static int dgnc_tty_open(struct tty_struct *tty, struct file *file)
> > * ch_flags_wait to wake us back up.
> > */
> > rc = wait_event_interruptible(ch->ch_flags_wait,
> > - (((ch->ch_tun.un_flags | ch->ch_pun.un_flags) &
> > - UN_CLOSING) == 0));
> > + (((ch->ch_tun.un_flags |
> > + ch->ch_pun.un_flags) &
> > + UN_CLOSING) == 0));
>
> Bother are not so nice, but maybe it was better before. It's nice to have
> at least both arguments to | on the same line.
>
> julia
>
Alright. I'll keep that in mind.
Thanks
Rehas
> >
> > /* If ret is non-zero, user ctrl-c'ed us */
> > if (rc)
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914153331.GA22396%40toblerone.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-14 19:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 15:33 [PATCH] staging: dgnc: Fix alignment with open parentheses Rehas Sachdeva
2016-09-14 19:12 ` [Outreachy kernel] " Julia Lawall
2016-09-14 19:37 ` Rehas Sachdeva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.