* [PATCH] staging: dgnc: Fix long line and spelling mistake
@ 2016-09-14 14:27 Rehas Sachdeva
2016-09-14 19:29 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Rehas Sachdeva @ 2016-09-14 14:27 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
This patch fixes the checkpatch.pl warning:
Line over 80 characters.
Also, the word 'because' was spelled as
'Becuz' and has been corrected.
Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
drivers/staging/dgnc/dgnc_neo.c | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 5ef5b3e..fe071e1 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -107,7 +107,9 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch)
/* Turn off auto Xon flow control */
efr &= ~UART_17158_EFR_IXON;
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero it
+ * out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
@@ -143,7 +145,9 @@ static inline void neo_set_rts_flow_control(struct channel_t *ch)
ier &= ~UART_17158_IER_XOFF;
efr &= ~UART_17158_EFR_IXOFF;
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero it
+ * out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
@@ -181,7 +185,9 @@ static inline void neo_set_ixon_flow_control(struct channel_t *ch)
/* Turn on auto Xon flow control */
efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXON);
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero it
+ * out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
@@ -219,7 +225,9 @@ static inline void neo_set_ixoff_flow_control(struct channel_t *ch)
ier |= UART_17158_IER_XOFF;
efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero it
+ * out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
@@ -260,7 +268,9 @@ static inline void neo_set_no_input_flow_control(struct channel_t *ch)
else
efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero
+ * it out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
@@ -298,7 +308,9 @@ static inline void neo_set_no_output_flow_control(struct channel_t *ch)
else
efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXON);
- /* Why? Becuz Exar's spec says we have to zero it out before setting it */
+ /* Why? Because Exar's spec says we have to zero it
+ * out before setting it
+ */
writeb(0, &ch->ch_neo_uart->efr);
/* Turn on UART enhanced bits */
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: dgnc: Fix long line and spelling mistake
2016-09-14 14:27 [PATCH] staging: dgnc: Fix long line and spelling mistake Rehas Sachdeva
@ 2016-09-14 19:29 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-14 19:29 UTC (permalink / raw)
To: Rehas Sachdeva
Cc: outreachy-kernel, Lidza Louina, Mark Hounschell, Greg Kroah-Hartman
On Wed, 14 Sep 2016, Rehas Sachdeva wrote:
> This patch fixes the checkpatch.pl warning:
> Line over 80 characters.
> Also, the word 'because' was spelled as
> 'Becuz' and has been corrected.
While the commit message should not exceed 80 characters, it is also nicer
if it is not too short. The last sentence could probably fit on one line.
julia
>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> drivers/staging/dgnc/dgnc_neo.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 5ef5b3e..fe071e1 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -107,7 +107,9 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch)
> /* Turn off auto Xon flow control */
> efr &= ~UART_17158_EFR_IXON;
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero it
> + * out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> @@ -143,7 +145,9 @@ static inline void neo_set_rts_flow_control(struct channel_t *ch)
> ier &= ~UART_17158_IER_XOFF;
> efr &= ~UART_17158_EFR_IXOFF;
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero it
> + * out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> @@ -181,7 +185,9 @@ static inline void neo_set_ixon_flow_control(struct channel_t *ch)
> /* Turn on auto Xon flow control */
> efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXON);
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero it
> + * out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> @@ -219,7 +225,9 @@ static inline void neo_set_ixoff_flow_control(struct channel_t *ch)
> ier |= UART_17158_IER_XOFF;
> efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero it
> + * out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> @@ -260,7 +268,9 @@ static inline void neo_set_no_input_flow_control(struct channel_t *ch)
> else
> efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero
> + * it out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> @@ -298,7 +308,9 @@ static inline void neo_set_no_output_flow_control(struct channel_t *ch)
> else
> efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXON);
>
> - /* Why? Becuz Exar's spec says we have to zero it out before setting it */
> + /* Why? Because Exar's spec says we have to zero it
> + * out before setting it
> + */
> writeb(0, &ch->ch_neo_uart->efr);
>
> /* Turn on UART enhanced bits */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160914142656.GA3298%40toblerone.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-14 19:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 14:27 [PATCH] staging: dgnc: Fix long line and spelling mistake Rehas Sachdeva
2016-09-14 19:29 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.