[PATCH v2] staging: dgnc: Fix long line and spelling mistake

[PATCH v2] staging: dgnc: Fix long line and spelling mistake

[Rehas Sachdeva]

This patch fixes the checkpatch.pl warning: Line over 80 characters.
Also, the word 'because' was spelled as 'Becuz' and has been corrected.

Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
---
Changes in v2:
Format the commit message to not have too short lines.

 drivers/staging/dgnc/dgnc_neo.c | 24 ++++++++++++++++++------
 1 file changed, 18 insertions(+), 6 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index 5ef5b3e..fe071e1 100644
--- a/drivers/staging/dgnc/dgnc_neo.c
+++ b/drivers/staging/dgnc/dgnc_neo.c
@@ -107,7 +107,9 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch)
 	/* Turn off auto Xon flow control */
 	efr &= ~UART_17158_EFR_IXON;
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero it
+	 * out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
@@ -143,7 +145,9 @@ static inline void neo_set_rts_flow_control(struct channel_t *ch)
 	ier &= ~UART_17158_IER_XOFF;
 	efr &= ~UART_17158_EFR_IXOFF;
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero it
+	 * out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
@@ -181,7 +185,9 @@ static inline void neo_set_ixon_flow_control(struct channel_t *ch)
 	/* Turn on auto Xon flow control */
 	efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXON);
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero it
+	 * out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
@@ -219,7 +225,9 @@ static inline void neo_set_ixoff_flow_control(struct channel_t *ch)
 	ier |= UART_17158_IER_XOFF;
 	efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero it
+	 * out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
@@ -260,7 +268,9 @@ static inline void neo_set_no_input_flow_control(struct channel_t *ch)
 	else
 		efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero
+	 * it out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
@@ -298,7 +308,9 @@ static inline void neo_set_no_output_flow_control(struct channel_t *ch)
 	else
 		efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXON);
 
-	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
+	/* Why? Because Exar's spec says we have to zero it
+	 * out before setting it
+	 */
 	writeb(0, &ch->ch_neo_uart->efr);
 
 	/* Turn on UART enhanced bits */
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: Fix long line and spelling mistake

[Julia Lawall]

On Thu, 15 Sep 2016, Rehas Sachdeva wrote:

> This patch fixes the checkpatch.pl warning: Line over 80 characters.
> Also, the word 'because' was spelled as 'Becuz' and has been corrected.

Looks much betetr :)

julia

>
> Signed-off-by: Rehas Sachdeva <aquannie@gmail.com>
> ---
> Changes in v2:
> Format the commit message to not have too short lines.
>
>  drivers/staging/dgnc/dgnc_neo.c | 24 ++++++++++++++++++------
>  1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
> index 5ef5b3e..fe071e1 100644
> --- a/drivers/staging/dgnc/dgnc_neo.c
> +++ b/drivers/staging/dgnc/dgnc_neo.c
> @@ -107,7 +107,9 @@ static inline void neo_set_cts_flow_control(struct channel_t *ch)
>  	/* Turn off auto Xon flow control */
>  	efr &= ~UART_17158_EFR_IXON;
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero it
> +	 * out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> @@ -143,7 +145,9 @@ static inline void neo_set_rts_flow_control(struct channel_t *ch)
>  	ier &= ~UART_17158_IER_XOFF;
>  	efr &= ~UART_17158_EFR_IXOFF;
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero it
> +	 * out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> @@ -181,7 +185,9 @@ static inline void neo_set_ixon_flow_control(struct channel_t *ch)
>  	/* Turn on auto Xon flow control */
>  	efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXON);
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero it
> +	 * out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> @@ -219,7 +225,9 @@ static inline void neo_set_ixoff_flow_control(struct channel_t *ch)
>  	ier |= UART_17158_IER_XOFF;
>  	efr |= (UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero it
> +	 * out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> @@ -260,7 +268,9 @@ static inline void neo_set_no_input_flow_control(struct channel_t *ch)
>  	else
>  		efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXOFF);
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero
> +	 * it out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> @@ -298,7 +308,9 @@ static inline void neo_set_no_output_flow_control(struct channel_t *ch)
>  	else
>  		efr &= ~(UART_17158_EFR_ECB | UART_17158_EFR_IXON);
>
> -	/* Why? Becuz Exar's spec says we have to zero it out before setting it */
> +	/* Why? Because Exar's spec says we have to zero it
> +	 * out before setting it
> +	 */
>  	writeb(0, &ch->ch_neo_uart->efr);
>
>  	/* Turn on UART enhanced bits */
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160915040821.GA5441%40toblerone.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: Fix long line and spelling mistake

[Greg Kroah-Hartman]

On Thu, Sep 15, 2016 at 07:10:42AM +0200, Julia Lawall wrote:
> 
> 
> On Thu, 15 Sep 2016, Rehas Sachdeva wrote:
> 
> > This patch fixes the checkpatch.pl warning: Line over 80 characters.
> > Also, the word 'because' was spelled as 'Becuz' and has been corrected.
> 
> Looks much betetr :)

Julia, can you provide "Reviewed-by:" or "Acked-by:" for patches like
this so that I can give you credit for doing this review?

thanks,

greg k-h

Re: [Outreachy kernel] [PATCH v2] staging: dgnc: Fix long line and spelling mistake

[Julia Lawall]

On Fri, 16 Sep 2016, Greg Kroah-Hartman wrote:

> On Thu, Sep 15, 2016 at 07:10:42AM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 15 Sep 2016, Rehas Sachdeva wrote:
> >
> > > This patch fixes the checkpatch.pl warning: Line over 80 characters.
> > > Also, the word 'because' was spelled as 'Becuz' and has been corrected.
> >
> > Looks much betetr :)
>
> Julia, can you provide "Reviewed-by:" or "Acked-by:" for patches like
> this so that I can give you credit for doing this review?

OK.  Will do.

julia