Re: [Outreachy kernel] [PATCH 6/6] staging: vt6656: rxtx: Fix multiple assignments

[Julia Lawall <julia.lawall@lip6.fr>]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2186 bytes --]



On Thu, 15 Sep 2016, Namrata A Shettar wrote:

> This patch fixes checkpatch issue of multiple assignments.

Fix is not very clear, because it is not very clear what a multiple
assignment is.  For example, it could be x = 3; x = 4;.  "Break up
multiple assignments" could be clearer.  Also, it is not necessary to say
"This patch".  The reader knows that the commit log is a description of a
patch.  He wants to get to the interesting part as quickly as possible.

julia

>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
>  drivers/staging/vt6656/rxtx.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index a8553e3a..647220d 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -166,8 +166,9 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct
> vnt_private *priv,
>         } else if (rsv_type == 2) {
>                 rts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
>                         20, priv->top_ofdm_basic_rate);
> -               cts_time = ack_time =
> vnt_get_frame_time(priv->preamble_type,
> +               cts_time = vnt_get_frame_time(priv->preamble_type,
>                         pkt_type, 14, priv->top_ofdm_basic_rate);
> +               ack_time = cts_time;
>         } else if (rsv_type == 3) {
>                 cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
>                         14, priv->top_cck_basic_rate);[cleardot.gif]
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDGAP0UTFhwaidjYrcb
> ijgtoP7jFWRxa2GZiouZ4dnzWcw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>