* [PATCH 6/6] staging: vt6656: rxtx: Fix multiple assignments
@ 2016-09-14 22:16 Namrata A Shettar
2016-09-15 5:15 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Namrata A Shettar @ 2016-09-14 22:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Malcolm Priestley, Alison Schofield,
maomao xu, Othmar Pasteka, Parth Sane, Wolfram Sang,
outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]
This patch fixes checkpatch issue of multiple assignments.
Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
---
drivers/staging/vt6656/rxtx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
index a8553e3a..647220d 100644
--- a/drivers/staging/vt6656/rxtx.c
+++ b/drivers/staging/vt6656/rxtx.c
@@ -166,8 +166,9 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct
vnt_private *priv,
} else if (rsv_type == 2) {
rts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
20, priv->top_ofdm_basic_rate);
- cts_time = ack_time = vnt_get_frame_time(priv->pream
ble_type,
+ cts_time = vnt_get_frame_time(priv->preamble_type,
pkt_type, 14, priv->top_ofdm_basic_rate);
+ ack_time = cts_time;
} else if (rsv_type == 3) {
cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
14, priv->top_cck_basic_rate);
--
2.7.4
[-- Attachment #2: Type: text/html, Size: 1597 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH 6/6] staging: vt6656: rxtx: Fix multiple assignments
2016-09-14 22:16 [PATCH 6/6] staging: vt6656: rxtx: Fix multiple assignments Namrata A Shettar
@ 2016-09-15 5:15 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-15 5:15 UTC (permalink / raw)
To: Namrata A Shettar
Cc: Greg Kroah-Hartman, Malcolm Priestley, Alison Schofield,
maomao xu, Othmar Pasteka, Parth Sane, Wolfram Sang,
outreachy-kernel
[-- Attachment #1: Type: TEXT/PLAIN, Size: 2186 bytes --]
On Thu, 15 Sep 2016, Namrata A Shettar wrote:
> This patch fixes checkpatch issue of multiple assignments.
Fix is not very clear, because it is not very clear what a multiple
assignment is. For example, it could be x = 3; x = 4;. "Break up
multiple assignments" could be clearer. Also, it is not necessary to say
"This patch". The reader knows that the commit log is a description of a
patch. He wants to get to the interesting part as quickly as possible.
julia
>
> Signed-off-by: Namrata A Shettar <namrataashettar@gmail.com>
> ---
> drivers/staging/vt6656/rxtx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index a8553e3a..647220d 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -166,8 +166,9 @@ static __le16 vnt_get_rtscts_rsvtime_le(struct
> vnt_private *priv,
> } else if (rsv_type == 2) {
> rts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
> 20, priv->top_ofdm_basic_rate);
> - cts_time = ack_time =
> vnt_get_frame_time(priv->preamble_type,
> + cts_time = vnt_get_frame_time(priv->preamble_type,
> pkt_type, 14, priv->top_ofdm_basic_rate);
> + ack_time = cts_time;
> } else if (rsv_type == 3) {
> cts_time = vnt_get_frame_time(priv->preamble_type, pkt_type,
> 14, priv->top_cck_basic_rate);[cleardot.gif]
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CAFrQyDGAP0UTFhwaidjYrcb
> ijgtoP7jFWRxa2GZiouZ4dnzWcw%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-15 5:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 22:16 [PATCH 6/6] staging: vt6656: rxtx: Fix multiple assignments Namrata A Shettar
2016-09-15 5:15 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.