All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] staging: iio: meter: Match alignment with open parenthesis
@ 2016-09-18 21:00 Georgiana Rodica Chelu
  2016-09-19  5:21 ` [Outreachy kernel] " Alison Schofield
  2016-09-19  9:20 ` Georgiana Chelu
  0 siblings, 2 replies; 4+ messages in thread
From: Georgiana Rodica Chelu @ 2016-09-18 21:00 UTC (permalink / raw)
  To: outreachy-kernel

This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
 drivers/staging/iio/meter/ade7753.c | 43 ++++++++++++++-----------------------
 1 file changed, 16 insertions(+), 27 deletions(-)

diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
index 4b5f05f..e3f6deb 100644
--- a/drivers/staging/iio/meter/ade7753.c
+++ b/drivers/staging/iio/meter/ade7753.c
@@ -42,8 +42,7 @@ static int ade7753_spi_write_reg_8(struct device *dev,
 }
 
 static int ade7753_spi_write_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 value)
+				    u8 reg_address, u16 value)
 {
 	int ret;
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
@@ -60,8 +59,7 @@ static int ade7753_spi_write_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_8(struct device *dev,
-		u8 reg_address,
-		u8 *val)
+				  u8 reg_address, u8 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);
@@ -70,7 +68,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
 	if (ret < 0) {
 		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		return ret;
 	}
 	*val = ret;
@@ -79,8 +77,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_16(struct device *dev,
-		u8 reg_address,
-		u16 *val)
+				   u8 reg_address, u16 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);
@@ -99,8 +96,7 @@ static int ade7753_spi_read_reg_16(struct device *dev,
 }
 
 static int ade7753_spi_read_reg_24(struct device *dev,
-		u8 reg_address,
-		u32 *val)
+				   u8 reg_address, u32 *val)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);
@@ -123,7 +119,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
 	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
 	if (ret) {
 		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
-				reg_address);
+			reg_address);
 		goto error_ret;
 	}
 	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
@@ -134,8 +130,7 @@ error_ret:
 }
 
 static ssize_t ade7753_read_8bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				 struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u8 val;
@@ -149,8 +144,7 @@ static ssize_t ade7753_read_8bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_16bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u16 val;
@@ -164,8 +158,7 @@ static ssize_t ade7753_read_16bit(struct device *dev,
 }
 
 static ssize_t ade7753_read_24bit(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				  struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u32 val;
@@ -179,9 +172,8 @@ static ssize_t ade7753_read_24bit(struct device *dev,
 }
 
 static ssize_t ade7753_write_8bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				  struct device_attribute *attr,
+				  const char *buf, size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;
@@ -197,9 +189,8 @@ error_ret:
 }
 
 static ssize_t ade7753_write_16bit(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				   struct device_attribute *attr,
+				   const char *buf, size_t len)
 {
 	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
 	int ret;
@@ -384,8 +375,7 @@ err_ret:
 }
 
 static ssize_t ade7753_read_frequency(struct device *dev,
-		struct device_attribute *attr,
-		char *buf)
+				      struct device_attribute *attr, char *buf)
 {
 	int ret;
 	u16 t;
@@ -402,9 +392,8 @@ static ssize_t ade7753_read_frequency(struct device *dev,
 }
 
 static ssize_t ade7753_write_frequency(struct device *dev,
-		struct device_attribute *attr,
-		const char *buf,
-		size_t len)
+				       struct device_attribute *attr,
+				       const char *buf, size_t len)
 {
 	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
 	struct ade7753_state *st = iio_priv(indio_dev);
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: iio: meter: Match alignment with open parenthesis
  2016-09-18 21:00 [PATCH] staging: iio: meter: Match alignment with open parenthesis Georgiana Rodica Chelu
@ 2016-09-19  5:21 ` Alison Schofield
  2016-09-19  5:32   ` Julia Lawall
  2016-09-19  9:20 ` Georgiana Chelu
  1 sibling, 1 reply; 4+ messages in thread
From: Alison Schofield @ 2016-09-19  5:21 UTC (permalink / raw)
  To: Georgiana Rodica Chelu; +Cc: outreachy-kernel

On Mon, Sep 19, 2016 at 12:00:56AM +0300, Georgiana Rodica Chelu wrote:
> This patch fixes the following checkpatch.pl check:
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>

Hi Georgiana,
Nice patch.  I think there's a patch for this already in the IIO queue,
so probably won't get taken.  In IIO, the driver name is typically
mentioned in the Subject line - as in:
staging: iio: meter: ade5933: ....
alisons

> ---
>  drivers/staging/iio/meter/ade7753.c | 43 ++++++++++++++-----------------------
>  1 file changed, 16 insertions(+), 27 deletions(-)
> 
> diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> index 4b5f05f..e3f6deb 100644
> --- a/drivers/staging/iio/meter/ade7753.c
> +++ b/drivers/staging/iio/meter/ade7753.c
> @@ -42,8 +42,7 @@ static int ade7753_spi_write_reg_8(struct device *dev,
>  }
>  
>  static int ade7753_spi_write_reg_16(struct device *dev,
> -		u8 reg_address,
> -		u16 value)
> +				    u8 reg_address, u16 value)
>  {
>  	int ret;
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> @@ -60,8 +59,7 @@ static int ade7753_spi_write_reg_16(struct device *dev,
>  }
>  
>  static int ade7753_spi_read_reg_8(struct device *dev,
> -		u8 reg_address,
> -		u8 *val)
> +				  u8 reg_address, u8 *val)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct ade7753_state *st = iio_priv(indio_dev);
> @@ -70,7 +68,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
>  	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
>  	if (ret < 0) {
>  		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
> -				reg_address);
> +			reg_address);
>  		return ret;
>  	}
>  	*val = ret;
> @@ -79,8 +77,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
>  }
>  
>  static int ade7753_spi_read_reg_16(struct device *dev,
> -		u8 reg_address,
> -		u16 *val)
> +				   u8 reg_address, u16 *val)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct ade7753_state *st = iio_priv(indio_dev);
> @@ -99,8 +96,7 @@ static int ade7753_spi_read_reg_16(struct device *dev,
>  }
>  
>  static int ade7753_spi_read_reg_24(struct device *dev,
> -		u8 reg_address,
> -		u32 *val)
> +				   u8 reg_address, u32 *val)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct ade7753_state *st = iio_priv(indio_dev);
> @@ -123,7 +119,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
>  	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
>  	if (ret) {
>  		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
> -				reg_address);
> +			reg_address);
>  		goto error_ret;
>  	}
>  	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
> @@ -134,8 +130,7 @@ error_ret:
>  }
>  
>  static ssize_t ade7753_read_8bit(struct device *dev,
> -		struct device_attribute *attr,
> -		char *buf)
> +				 struct device_attribute *attr, char *buf)
>  {
>  	int ret;
>  	u8 val;
> @@ -149,8 +144,7 @@ static ssize_t ade7753_read_8bit(struct device *dev,
>  }
>  
>  static ssize_t ade7753_read_16bit(struct device *dev,
> -		struct device_attribute *attr,
> -		char *buf)
> +				  struct device_attribute *attr, char *buf)
>  {
>  	int ret;
>  	u16 val;
> @@ -164,8 +158,7 @@ static ssize_t ade7753_read_16bit(struct device *dev,
>  }
>  
>  static ssize_t ade7753_read_24bit(struct device *dev,
> -		struct device_attribute *attr,
> -		char *buf)
> +				  struct device_attribute *attr, char *buf)
>  {
>  	int ret;
>  	u32 val;
> @@ -179,9 +172,8 @@ static ssize_t ade7753_read_24bit(struct device *dev,
>  }
>  
>  static ssize_t ade7753_write_8bit(struct device *dev,
> -		struct device_attribute *attr,
> -		const char *buf,
> -		size_t len)
> +				  struct device_attribute *attr,
> +				  const char *buf, size_t len)
>  {
>  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>  	int ret;
> @@ -197,9 +189,8 @@ error_ret:
>  }
>  
>  static ssize_t ade7753_write_16bit(struct device *dev,
> -		struct device_attribute *attr,
> -		const char *buf,
> -		size_t len)
> +				   struct device_attribute *attr,
> +				   const char *buf, size_t len)
>  {
>  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
>  	int ret;
> @@ -384,8 +375,7 @@ err_ret:
>  }
>  
>  static ssize_t ade7753_read_frequency(struct device *dev,
> -		struct device_attribute *attr,
> -		char *buf)
> +				      struct device_attribute *attr, char *buf)
>  {
>  	int ret;
>  	u16 t;
> @@ -402,9 +392,8 @@ static ssize_t ade7753_read_frequency(struct device *dev,
>  }
>  
>  static ssize_t ade7753_write_frequency(struct device *dev,
> -		struct device_attribute *attr,
> -		const char *buf,
> -		size_t len)
> +				       struct device_attribute *attr,
> +				       const char *buf, size_t len)
>  {
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct ade7753_state *st = iio_priv(indio_dev);
> -- 
> 2.7.4
> 
> -- 
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160918210056.GA6241%40fireworks.
> For more options, visit https://groups.google.com/d/optout.


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Outreachy kernel] [PATCH] staging: iio: meter: Match alignment with open parenthesis
  2016-09-19  5:21 ` [Outreachy kernel] " Alison Schofield
@ 2016-09-19  5:32   ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-09-19  5:32 UTC (permalink / raw)
  To: Alison Schofield; +Cc: Georgiana Rodica Chelu, outreachy-kernel



On Sun, 18 Sep 2016, Alison Schofield wrote:

> On Mon, Sep 19, 2016 at 12:00:56AM +0300, Georgiana Rodica Chelu wrote:
> > This patch fixes the following checkpatch.pl check:
> > CHECK: Alignment should match open parenthesis
> >
> > Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
>
> Hi Georgiana,
> Nice patch.  I think there's a patch for this already in the IIO queue,
> so probably won't get taken.  In IIO, the driver name is typically
> mentioned in the Subject line - as in:
> staging: iio: meter: ade5933: ....

Always check using git log --oneline for the affected file what others
have done for the subject line.  While iio may follow this strategy, other
subsystems have other preferences.

julia

> alisons
>
> > ---
> >  drivers/staging/iio/meter/ade7753.c | 43 ++++++++++++++-----------------------
> >  1 file changed, 16 insertions(+), 27 deletions(-)
> >
> > diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c
> > index 4b5f05f..e3f6deb 100644
> > --- a/drivers/staging/iio/meter/ade7753.c
> > +++ b/drivers/staging/iio/meter/ade7753.c
> > @@ -42,8 +42,7 @@ static int ade7753_spi_write_reg_8(struct device *dev,
> >  }
> >
> >  static int ade7753_spi_write_reg_16(struct device *dev,
> > -		u8 reg_address,
> > -		u16 value)
> > +				    u8 reg_address, u16 value)
> >  {
> >  	int ret;
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> > @@ -60,8 +59,7 @@ static int ade7753_spi_write_reg_16(struct device *dev,
> >  }
> >
> >  static int ade7753_spi_read_reg_8(struct device *dev,
> > -		u8 reg_address,
> > -		u8 *val)
> > +				  u8 reg_address, u8 *val)
> >  {
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> >  	struct ade7753_state *st = iio_priv(indio_dev);
> > @@ -70,7 +68,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
> >  	ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address));
> >  	if (ret < 0) {
> >  		dev_err(&st->us->dev, "problem when reading 8 bit register 0x%02X",
> > -				reg_address);
> > +			reg_address);
> >  		return ret;
> >  	}
> >  	*val = ret;
> > @@ -79,8 +77,7 @@ static int ade7753_spi_read_reg_8(struct device *dev,
> >  }
> >
> >  static int ade7753_spi_read_reg_16(struct device *dev,
> > -		u8 reg_address,
> > -		u16 *val)
> > +				   u8 reg_address, u16 *val)
> >  {
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> >  	struct ade7753_state *st = iio_priv(indio_dev);
> > @@ -99,8 +96,7 @@ static int ade7753_spi_read_reg_16(struct device *dev,
> >  }
> >
> >  static int ade7753_spi_read_reg_24(struct device *dev,
> > -		u8 reg_address,
> > -		u32 *val)
> > +				   u8 reg_address, u32 *val)
> >  {
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> >  	struct ade7753_state *st = iio_priv(indio_dev);
> > @@ -123,7 +119,7 @@ static int ade7753_spi_read_reg_24(struct device *dev,
> >  	ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers));
> >  	if (ret) {
> >  		dev_err(&st->us->dev, "problem when reading 24 bit register 0x%02X",
> > -				reg_address);
> > +			reg_address);
> >  		goto error_ret;
> >  	}
> >  	*val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2];
> > @@ -134,8 +130,7 @@ error_ret:
> >  }
> >
> >  static ssize_t ade7753_read_8bit(struct device *dev,
> > -		struct device_attribute *attr,
> > -		char *buf)
> > +				 struct device_attribute *attr, char *buf)
> >  {
> >  	int ret;
> >  	u8 val;
> > @@ -149,8 +144,7 @@ static ssize_t ade7753_read_8bit(struct device *dev,
> >  }
> >
> >  static ssize_t ade7753_read_16bit(struct device *dev,
> > -		struct device_attribute *attr,
> > -		char *buf)
> > +				  struct device_attribute *attr, char *buf)
> >  {
> >  	int ret;
> >  	u16 val;
> > @@ -164,8 +158,7 @@ static ssize_t ade7753_read_16bit(struct device *dev,
> >  }
> >
> >  static ssize_t ade7753_read_24bit(struct device *dev,
> > -		struct device_attribute *attr,
> > -		char *buf)
> > +				  struct device_attribute *attr, char *buf)
> >  {
> >  	int ret;
> >  	u32 val;
> > @@ -179,9 +172,8 @@ static ssize_t ade7753_read_24bit(struct device *dev,
> >  }
> >
> >  static ssize_t ade7753_write_8bit(struct device *dev,
> > -		struct device_attribute *attr,
> > -		const char *buf,
> > -		size_t len)
> > +				  struct device_attribute *attr,
> > +				  const char *buf, size_t len)
> >  {
> >  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> >  	int ret;
> > @@ -197,9 +189,8 @@ error_ret:
> >  }
> >
> >  static ssize_t ade7753_write_16bit(struct device *dev,
> > -		struct device_attribute *attr,
> > -		const char *buf,
> > -		size_t len)
> > +				   struct device_attribute *attr,
> > +				   const char *buf, size_t len)
> >  {
> >  	struct iio_dev_attr *this_attr = to_iio_dev_attr(attr);
> >  	int ret;
> > @@ -384,8 +375,7 @@ err_ret:
> >  }
> >
> >  static ssize_t ade7753_read_frequency(struct device *dev,
> > -		struct device_attribute *attr,
> > -		char *buf)
> > +				      struct device_attribute *attr, char *buf)
> >  {
> >  	int ret;
> >  	u16 t;
> > @@ -402,9 +392,8 @@ static ssize_t ade7753_read_frequency(struct device *dev,
> >  }
> >
> >  static ssize_t ade7753_write_frequency(struct device *dev,
> > -		struct device_attribute *attr,
> > -		const char *buf,
> > -		size_t len)
> > +				       struct device_attribute *attr,
> > +				       const char *buf, size_t len)
> >  {
> >  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> >  	struct ade7753_state *st = iio_priv(indio_dev);
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160918210056.GA6241%40fireworks.
> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160919052122.GA2699%40d830.WORKGROUP.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: iio: meter: Match alignment with open parenthesis
  2016-09-18 21:00 [PATCH] staging: iio: meter: Match alignment with open parenthesis Georgiana Rodica Chelu
  2016-09-19  5:21 ` [Outreachy kernel] " Alison Schofield
@ 2016-09-19  9:20 ` Georgiana Chelu
  1 sibling, 0 replies; 4+ messages in thread
From: Georgiana Chelu @ 2016-09-19  9:20 UTC (permalink / raw)
  To: outreachy-kernel


[-- Attachment #1.1: Type: text/plain, Size: 6026 bytes --]

Hello!

Thank you for your responses. I will keep them in mind.


On Monday, 19 September 2016 00:01:00 UTC+3, Georgiana Chelu wrote:
>
> This patch fixes the following checkpatch.pl check: 
> CHECK: Alignment should match open parenthesis 
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com> 
> --- 
>  drivers/staging/iio/meter/ade7753.c | 43 
> ++++++++++++++----------------------- 
>  1 file changed, 16 insertions(+), 27 deletions(-) 
>
> diff --git a/drivers/staging/iio/meter/ade7753.c 
> b/drivers/staging/iio/meter/ade7753.c 
> index 4b5f05f..e3f6deb 100644 
> --- a/drivers/staging/iio/meter/ade7753.c 
> +++ b/drivers/staging/iio/meter/ade7753.c 
> @@ -42,8 +42,7 @@ static int ade7753_spi_write_reg_8(struct device *dev, 
>  } 
>   
>  static int ade7753_spi_write_reg_16(struct device *dev, 
> -                u8 reg_address, 
> -                u16 value) 
> +                                    u8 reg_address, u16 value) 
>  { 
>          int ret; 
>          struct iio_dev *indio_dev = dev_to_iio_dev(dev); 
> @@ -60,8 +59,7 @@ static int ade7753_spi_write_reg_16(struct device *dev, 
>  } 
>   
>  static int ade7753_spi_read_reg_8(struct device *dev, 
> -                u8 reg_address, 
> -                u8 *val) 
> +                                  u8 reg_address, u8 *val) 
>  { 
>          struct iio_dev *indio_dev = dev_to_iio_dev(dev); 
>          struct ade7753_state *st = iio_priv(indio_dev); 
> @@ -70,7 +68,7 @@ static int ade7753_spi_read_reg_8(struct device *dev, 
>          ret = spi_w8r8(st->us, ADE7753_READ_REG(reg_address)); 
>          if (ret < 0) { 
>                  dev_err(&st->us->dev, "problem when reading 8 bit 
> register 0x%02X", 
> -                                reg_address); 
> +                        reg_address); 
>                  return ret; 
>          } 
>          *val = ret; 
> @@ -79,8 +77,7 @@ static int ade7753_spi_read_reg_8(struct device *dev, 
>  } 
>   
>  static int ade7753_spi_read_reg_16(struct device *dev, 
> -                u8 reg_address, 
> -                u16 *val) 
> +                                   u8 reg_address, u16 *val) 
>  { 
>          struct iio_dev *indio_dev = dev_to_iio_dev(dev); 
>          struct ade7753_state *st = iio_priv(indio_dev); 
> @@ -99,8 +96,7 @@ static int ade7753_spi_read_reg_16(struct device *dev, 
>  } 
>   
>  static int ade7753_spi_read_reg_24(struct device *dev, 
> -                u8 reg_address, 
> -                u32 *val) 
> +                                   u8 reg_address, u32 *val) 
>  { 
>          struct iio_dev *indio_dev = dev_to_iio_dev(dev); 
>          struct ade7753_state *st = iio_priv(indio_dev); 
> @@ -123,7 +119,7 @@ static int ade7753_spi_read_reg_24(struct device *dev, 
>          ret = spi_sync_transfer(st->us, xfers, ARRAY_SIZE(xfers)); 
>          if (ret) { 
>                  dev_err(&st->us->dev, "problem when reading 24 bit 
> register 0x%02X", 
> -                                reg_address); 
> +                        reg_address); 
>                  goto error_ret; 
>          } 
>          *val = (st->rx[0] << 16) | (st->rx[1] << 8) | st->rx[2]; 
> @@ -134,8 +130,7 @@ error_ret: 
>  } 
>   
>  static ssize_t ade7753_read_8bit(struct device *dev, 
> -                struct device_attribute *attr, 
> -                char *buf) 
> +                                 struct device_attribute *attr, char 
> *buf) 
>  { 
>          int ret; 
>          u8 val; 
> @@ -149,8 +144,7 @@ static ssize_t ade7753_read_8bit(struct device *dev, 
>  } 
>   
>  static ssize_t ade7753_read_16bit(struct device *dev, 
> -                struct device_attribute *attr, 
> -                char *buf) 
> +                                  struct device_attribute *attr, char 
> *buf) 
>  { 
>          int ret; 
>          u16 val; 
> @@ -164,8 +158,7 @@ static ssize_t ade7753_read_16bit(struct device *dev, 
>  } 
>   
>  static ssize_t ade7753_read_24bit(struct device *dev, 
> -                struct device_attribute *attr, 
> -                char *buf) 
> +                                  struct device_attribute *attr, char 
> *buf) 
>  { 
>          int ret; 
>          u32 val; 
> @@ -179,9 +172,8 @@ static ssize_t ade7753_read_24bit(struct device *dev, 
>  } 
>   
>  static ssize_t ade7753_write_8bit(struct device *dev, 
> -                struct device_attribute *attr, 
> -                const char *buf, 
> -                size_t len) 
> +                                  struct device_attribute *attr, 
> +                                  const char *buf, size_t len) 
>  { 
>          struct iio_dev_attr *this_attr = to_iio_dev_attr(attr); 
>          int ret; 
> @@ -197,9 +189,8 @@ error_ret: 
>  } 
>   
>  static ssize_t ade7753_write_16bit(struct device *dev, 
> -                struct device_attribute *attr, 
> -                const char *buf, 
> -                size_t len) 
> +                                   struct device_attribute *attr, 
> +                                   const char *buf, size_t len) 
>  { 
>          struct iio_dev_attr *this_attr = to_iio_dev_attr(attr); 
>          int ret; 
> @@ -384,8 +375,7 @@ err_ret: 
>  } 
>   
>  static ssize_t ade7753_read_frequency(struct device *dev, 
> -                struct device_attribute *attr, 
> -                char *buf) 
> +                                      struct device_attribute *attr, char 
> *buf) 
>  { 
>          int ret; 
>          u16 t; 
> @@ -402,9 +392,8 @@ static ssize_t ade7753_read_frequency(struct device 
> *dev, 
>  } 
>   
>  static ssize_t ade7753_write_frequency(struct device *dev, 
> -                struct device_attribute *attr, 
> -                const char *buf, 
> -                size_t len) 
> +                                       struct device_attribute *attr, 
> +                                       const char *buf, size_t len) 
>  { 
>          struct iio_dev *indio_dev = dev_to_iio_dev(dev); 
>          struct ade7753_state *st = iio_priv(indio_dev); 
> -- 
> 2.7.4 
>
>

[-- Attachment #1.2: Type: text/html, Size: 8701 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-09-19  9:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 21:00 [PATCH] staging: iio: meter: Match alignment with open parenthesis Georgiana Rodica Chelu
2016-09-19  5:21 ` [Outreachy kernel] " Alison Schofield
2016-09-19  5:32   ` Julia Lawall
2016-09-19  9:20 ` Georgiana Chelu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.