* [PATCH] Staging: i4l: Remove unused variable
@ 2016-09-18 19:01 Sandhya Bankar
2016-09-19 9:52 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Sandhya Bankar @ 2016-09-18 19:01 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh
Remove unused variable.
This change is made by below coccinelle script:
@@
type T;
identifier i;
constant C;
@@
(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)
Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
drivers/staging/i4l/act2000/act2000_isa.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
index 808bb3b..ad7a039 100644
--- a/drivers/staging/i4l/act2000/act2000_isa.c
+++ b/drivers/staging/i4l/act2000/act2000_isa.c
@@ -399,7 +399,6 @@ act2000_isa_download(act2000_card *card, act2000_ddef __user *cb)
unsigned int length;
int l;
int c;
- long timeout;
u_char *b;
u_char __user *p;
u_char *buf;
@@ -417,7 +416,6 @@ act2000_isa_download(act2000_card *card, act2000_ddef __user *cb)
buf = kmalloc(1024, GFP_KERNEL);
if (!buf)
return -ENOMEM;
- timeout = 0;
while (length) {
l = (length > 1024) ? 1024 : length;
c = 0;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: i4l: Remove unused variable
2016-09-18 19:01 [PATCH] Staging: i4l: Remove unused variable Sandhya Bankar
@ 2016-09-19 9:52 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-09-19 9:52 UTC (permalink / raw)
To: Sandhya Bankar; +Cc: outreachy-kernel, gregkh
On Mon, 19 Sep 2016, Sandhya Bankar wrote:
> Remove unused variable.
>
> This change is made by below coccinelle script:
> @@
> type T;
> identifier i;
> constant C;
> @@
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
>
> Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/i4l/act2000/act2000_isa.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/i4l/act2000/act2000_isa.c b/drivers/staging/i4l/act2000/act2000_isa.c
> index 808bb3b..ad7a039 100644
> --- a/drivers/staging/i4l/act2000/act2000_isa.c
> +++ b/drivers/staging/i4l/act2000/act2000_isa.c
> @@ -399,7 +399,6 @@ act2000_isa_download(act2000_card *card, act2000_ddef __user *cb)
> unsigned int length;
> int l;
> int c;
> - long timeout;
> u_char *b;
> u_char __user *p;
> u_char *buf;
> @@ -417,7 +416,6 @@ act2000_isa_download(act2000_card *card, act2000_ddef __user *cb)
> buf = kmalloc(1024, GFP_KERNEL);
> if (!buf)
> return -ENOMEM;
> - timeout = 0;
> while (length) {
> l = (length > 1024) ? 1024 : length;
> c = 0;
> --
> 1.7.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20160918190112.GA4845%40sandhya.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-19 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-18 19:01 [PATCH] Staging: i4l: Remove unused variable Sandhya Bankar
2016-09-19 9:52 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.