* [PATCH v3] Staging: sm750fb: fix comment block coding style issue in ddk750_display.h
@ 2016-10-02 12:42 Muraru Mihaela
2016-10-02 12:45 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Muraru Mihaela @ 2016-10-02 12:42 UTC (permalink / raw)
To: Julia Lawall
Cc: Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman, outreachy-kernel
This is a patch to the ddk750_display.h file that fixes up a comment
block warning, found by checkpatch.pl tool, by adding a * for each line
of the comment block.
Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
---
Changes in v3:
- arrange the subject line
---
drivers/staging/sm750fb/ddk750_display.h | 73 +++++++++++++++++---------------
1 file changed, 40 insertions(+), 33 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
index 5fc9f6f..e998f21 100644
--- a/drivers/staging/sm750fb/ddk750_display.h
+++ b/drivers/staging/sm750fb/ddk750_display.h
@@ -1,10 +1,10 @@
#ifndef DDK750_DISPLAY_H__
#define DDK750_DISPLAY_H__
-/* panel path select
- 80000[29:28]
-*/
-
+/*
+ * panel path select
+ * 80000[29:28]
+ */
#define PNL_2_OFFSET 0
#define PNL_2_MASK (3 << PNL_2_OFFSET)
#define PNL_2_USAGE (PNL_2_MASK << 16)
@@ -12,10 +12,11 @@
#define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE)
-/* primary timing & plane enable bit
- 1: 80000[8] & 80000[2] on
- 0: both off
-*/
+/*
+ * primary timing & plane enable bit
+ * 1: 80000[8] & 80000[2] on
+ * 0: both off
+ */
#define PRI_TP_OFFSET 4
#define PRI_TP_MASK BIT(PRI_TP_OFFSET)
#define PRI_TP_USAGE (PRI_TP_MASK << 16)
@@ -23,37 +24,41 @@
#define PRI_TP_OFF ((0x0 << PRI_TP_OFFSET) | PRI_TP_USAGE)
-/* panel sequency status
- 80000[27:24]
-*/
+/*
+ * panel sequency status
+ * 80000[27:24]
+ */
#define PNL_SEQ_OFFSET 6
#define PNL_SEQ_MASK BIT(PNL_SEQ_OFFSET)
#define PNL_SEQ_USAGE (PNL_SEQ_MASK << 16)
#define PNL_SEQ_ON (BIT(PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
#define PNL_SEQ_OFF ((0 << PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
-/* dual digital output
- 80000[19]
-*/
+/*
+ * dual digital output
+ * 80000[19]
+ */
#define DUAL_TFT_OFFSET 8
#define DUAL_TFT_MASK BIT(DUAL_TFT_OFFSET)
#define DUAL_TFT_USAGE (DUAL_TFT_MASK << 16)
#define DUAL_TFT_ON (BIT(DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
#define DUAL_TFT_OFF ((0 << DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
-/* secondary timing & plane enable bit
- 1:80200[8] & 80200[2] on
- 0: both off
-*/
+/*
+ * secondary timing & plane enable bit
+ * 1:80200[8] & 80200[2] on
+ * 0: both off
+ */
#define SEC_TP_OFFSET 5
#define SEC_TP_MASK BIT(SEC_TP_OFFSET)
#define SEC_TP_USAGE (SEC_TP_MASK << 16)
#define SEC_TP_ON ((0x1 << SEC_TP_OFFSET) | SEC_TP_USAGE)
#define SEC_TP_OFF ((0x0 << SEC_TP_OFFSET) | SEC_TP_USAGE)
-/* crt path select
- 80200[19:18]
-*/
+/*
+ * crt path select
+ * 80200[19:18]
+ */
#define CRT_2_OFFSET 2
#define CRT_2_MASK (3 << CRT_2_OFFSET)
#define CRT_2_USAGE (CRT_2_MASK << 16)
@@ -61,18 +66,20 @@
#define CRT_2_SEC ((0x2 << CRT_2_OFFSET) | CRT_2_USAGE)
-/* DAC affect both DVI and DSUB
- 4[20]
-*/
+/*
+ * DAC affect both DVI and DSUB
+ * 4[20]
+ */
#define DAC_OFFSET 7
#define DAC_MASK BIT(DAC_OFFSET)
#define DAC_USAGE (DAC_MASK << 16)
#define DAC_ON ((0x0 << DAC_OFFSET) | DAC_USAGE)
#define DAC_OFF ((0x1 << DAC_OFFSET) | DAC_USAGE)
-/* DPMS only affect D-SUB head
- 0[31:30]
-*/
+/*
+ * DPMS only affect D-SUB head
+ * 0[31:30]
+ */
#define DPMS_OFFSET 9
#define DPMS_MASK (3 << DPMS_OFFSET)
#define DPMS_USAGE (DPMS_MASK << 16)
@@ -82,18 +89,18 @@
/*
- LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
- CRT means crt path DSUB
-*/
+ * LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
+ * CRT means crt path DSUB
+ */
typedef enum _disp_output_t {
do_LCD1_PRI = PNL_2_PRI | PRI_TP_ON | PNL_SEQ_ON | DAC_ON,
do_LCD1_SEC = PNL_2_SEC | SEC_TP_ON | PNL_SEQ_ON | DAC_ON,
do_LCD2_PRI = CRT_2_PRI | PRI_TP_ON | DUAL_TFT_ON,
do_LCD2_SEC = CRT_2_SEC | SEC_TP_ON | DUAL_TFT_ON,
/*
- do_DSUB_PRI = CRT_2_PRI|PRI_TP_ON|DPMS_ON|DAC_ON,
- do_DSUB_SEC = CRT_2_SEC|SEC_TP_ON|DPMS_ON|DAC_ON,
- */
+ * do_DSUB_PRI = CRT_2_PRI|PRI_TP_ON|DPMS_ON|DAC_ON,
+ * do_DSUB_SEC = CRT_2_SEC|SEC_TP_ON|DPMS_ON|DAC_ON,
+ */
do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON,
do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v3] Staging: sm750fb: fix comment block coding style issue in ddk750_display.h
2016-10-02 12:42 [PATCH v3] Staging: sm750fb: fix comment block coding style issue in ddk750_display.h Muraru Mihaela
@ 2016-10-02 12:45 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2016-10-02 12:45 UTC (permalink / raw)
To: Muraru Mihaela
Cc: Julia Lawall, Sudip Mukherjee, Teddy Wang, Greg Kroah-Hartman,
outreachy-kernel
Oops, sorry one more thing. There is no need to put the file name in the
subject line. Indeed the subject line should try to be at most 50
characters. You could really stop with "style".
julia
On Sun, 2 Oct 2016, Muraru Mihaela wrote:
> This is a patch to the ddk750_display.h file that fixes up a comment
> block warning, found by checkpatch.pl tool, by adding a * for each line
> of the comment block.
>
> Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
>
> ---
> Changes in v3:
> - arrange the subject line
> ---
> drivers/staging/sm750fb/ddk750_display.h | 73 +++++++++++++++++---------------
> 1 file changed, 40 insertions(+), 33 deletions(-)
>
> diff --git a/drivers/staging/sm750fb/ddk750_display.h b/drivers/staging/sm750fb/ddk750_display.h
> index 5fc9f6f..e998f21 100644
> --- a/drivers/staging/sm750fb/ddk750_display.h
> +++ b/drivers/staging/sm750fb/ddk750_display.h
> @@ -1,10 +1,10 @@
> #ifndef DDK750_DISPLAY_H__
> #define DDK750_DISPLAY_H__
>
> -/* panel path select
> - 80000[29:28]
> -*/
> -
> +/*
> + * panel path select
> + * 80000[29:28]
> + */
> #define PNL_2_OFFSET 0
> #define PNL_2_MASK (3 << PNL_2_OFFSET)
> #define PNL_2_USAGE (PNL_2_MASK << 16)
> @@ -12,10 +12,11 @@
> #define PNL_2_SEC ((2 << PNL_2_OFFSET) | PNL_2_USAGE)
>
>
> -/* primary timing & plane enable bit
> - 1: 80000[8] & 80000[2] on
> - 0: both off
> -*/
> +/*
> + * primary timing & plane enable bit
> + * 1: 80000[8] & 80000[2] on
> + * 0: both off
> + */
> #define PRI_TP_OFFSET 4
> #define PRI_TP_MASK BIT(PRI_TP_OFFSET)
> #define PRI_TP_USAGE (PRI_TP_MASK << 16)
> @@ -23,37 +24,41 @@
> #define PRI_TP_OFF ((0x0 << PRI_TP_OFFSET) | PRI_TP_USAGE)
>
>
> -/* panel sequency status
> - 80000[27:24]
> -*/
> +/*
> + * panel sequency status
> + * 80000[27:24]
> + */
> #define PNL_SEQ_OFFSET 6
> #define PNL_SEQ_MASK BIT(PNL_SEQ_OFFSET)
> #define PNL_SEQ_USAGE (PNL_SEQ_MASK << 16)
> #define PNL_SEQ_ON (BIT(PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
> #define PNL_SEQ_OFF ((0 << PNL_SEQ_OFFSET) | PNL_SEQ_USAGE)
>
> -/* dual digital output
> - 80000[19]
> -*/
> +/*
> + * dual digital output
> + * 80000[19]
> + */
> #define DUAL_TFT_OFFSET 8
> #define DUAL_TFT_MASK BIT(DUAL_TFT_OFFSET)
> #define DUAL_TFT_USAGE (DUAL_TFT_MASK << 16)
> #define DUAL_TFT_ON (BIT(DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
> #define DUAL_TFT_OFF ((0 << DUAL_TFT_OFFSET) | DUAL_TFT_USAGE)
>
> -/* secondary timing & plane enable bit
> - 1:80200[8] & 80200[2] on
> - 0: both off
> -*/
> +/*
> + * secondary timing & plane enable bit
> + * 1:80200[8] & 80200[2] on
> + * 0: both off
> + */
> #define SEC_TP_OFFSET 5
> #define SEC_TP_MASK BIT(SEC_TP_OFFSET)
> #define SEC_TP_USAGE (SEC_TP_MASK << 16)
> #define SEC_TP_ON ((0x1 << SEC_TP_OFFSET) | SEC_TP_USAGE)
> #define SEC_TP_OFF ((0x0 << SEC_TP_OFFSET) | SEC_TP_USAGE)
>
> -/* crt path select
> - 80200[19:18]
> -*/
> +/*
> + * crt path select
> + * 80200[19:18]
> + */
> #define CRT_2_OFFSET 2
> #define CRT_2_MASK (3 << CRT_2_OFFSET)
> #define CRT_2_USAGE (CRT_2_MASK << 16)
> @@ -61,18 +66,20 @@
> #define CRT_2_SEC ((0x2 << CRT_2_OFFSET) | CRT_2_USAGE)
>
>
> -/* DAC affect both DVI and DSUB
> - 4[20]
> -*/
> +/*
> + * DAC affect both DVI and DSUB
> + * 4[20]
> + */
> #define DAC_OFFSET 7
> #define DAC_MASK BIT(DAC_OFFSET)
> #define DAC_USAGE (DAC_MASK << 16)
> #define DAC_ON ((0x0 << DAC_OFFSET) | DAC_USAGE)
> #define DAC_OFF ((0x1 << DAC_OFFSET) | DAC_USAGE)
>
> -/* DPMS only affect D-SUB head
> - 0[31:30]
> -*/
> +/*
> + * DPMS only affect D-SUB head
> + * 0[31:30]
> + */
> #define DPMS_OFFSET 9
> #define DPMS_MASK (3 << DPMS_OFFSET)
> #define DPMS_USAGE (DPMS_MASK << 16)
> @@ -82,18 +89,18 @@
>
>
> /*
> - LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
> - CRT means crt path DSUB
> -*/
> + * LCD1 means panel path TFT1 & panel path DVI (so enable DAC)
> + * CRT means crt path DSUB
> + */
> typedef enum _disp_output_t {
> do_LCD1_PRI = PNL_2_PRI | PRI_TP_ON | PNL_SEQ_ON | DAC_ON,
> do_LCD1_SEC = PNL_2_SEC | SEC_TP_ON | PNL_SEQ_ON | DAC_ON,
> do_LCD2_PRI = CRT_2_PRI | PRI_TP_ON | DUAL_TFT_ON,
> do_LCD2_SEC = CRT_2_SEC | SEC_TP_ON | DUAL_TFT_ON,
> /*
> - do_DSUB_PRI = CRT_2_PRI|PRI_TP_ON|DPMS_ON|DAC_ON,
> - do_DSUB_SEC = CRT_2_SEC|SEC_TP_ON|DPMS_ON|DAC_ON,
> - */
> + * do_DSUB_PRI = CRT_2_PRI|PRI_TP_ON|DPMS_ON|DAC_ON,
> + * do_DSUB_SEC = CRT_2_SEC|SEC_TP_ON|DPMS_ON|DAC_ON,
> + */
> do_CRT_PRI = CRT_2_PRI | PRI_TP_ON | DPMS_ON | DAC_ON,
> do_CRT_SEC = CRT_2_SEC | SEC_TP_ON | DPMS_ON | DAC_ON,
> }
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161002124245.GA14194%40domino-MS-16Y1.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-02 12:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-10-02 12:42 [PATCH v3] Staging: sm750fb: fix comment block coding style issue in ddk750_display.h Muraru Mihaela
2016-10-02 12:45 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.