All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Rientjes <rientjes@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Vinayak Menon <vinmenon@codeaurora.org>,
	Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm, vmpressure: free the same pointer we allocated
Date: Thu, 15 Jun 2017 01:49:08 +0000	[thread overview]
Message-ID: <alpine.DEB.2.10.1706141847460.77174@chino.kir.corp.google.com> (raw)
In-Reply-To: <20170613191820.GA20003@elgon.mountain>

On Tue, 13 Jun 2017, Dan Carpenter wrote:

> We keep incrementing "spec" as we parse the args so we end up calling
> kfree() on a modified of spec.  It probably works or this would have
> been caught in testing, but it looks weird.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: David Rientjes <rientjes@google.com>

WARNING: multiple messages have this Message-ID (diff)
From: David Rientjes <rientjes@google.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Minchan Kim <minchan@kernel.org>,
	Vinayak Menon <vinmenon@codeaurora.org>,
	Michal Hocko <mhocko@suse.com>,
	linux-mm@kvack.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm, vmpressure: free the same pointer we allocated
Date: Wed, 14 Jun 2017 18:49:08 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1706141847460.77174@chino.kir.corp.google.com> (raw)
In-Reply-To: <20170613191820.GA20003@elgon.mountain>

On Tue, 13 Jun 2017, Dan Carpenter wrote:

> We keep incrementing "spec" as we parse the args so we end up calling
> kfree() on a modified of spec.  It probably works or this would have
> been caught in testing, but it looks weird.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: David Rientjes <rientjes@google.com>

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-06-15  1:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-13 19:18 [PATCH] mm, vmpressure: free the same pointer we allocated Dan Carpenter
2017-06-13 19:18 ` Dan Carpenter
2017-06-15  1:49 ` David Rientjes [this message]
2017-06-15  1:49   ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1706141847460.77174@chino.kir.corp.google.com \
    --to=rientjes@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@suse.com \
    --cc=minchan@kernel.org \
    --cc=vinmenon@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.