All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: edgar.iglesias@xilinx.com,
	Stefano Stabellini <stefanos@xilinx.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	saeed.nowshadi@xilinx.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v7 4/6] xen/arm: zynqmp: implement zynqmp_eemi
Date: Tue, 18 Dec 2018 14:36:26 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.10.1812181308220.15901@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <c57cd38f-5e0a-3174-4b58-226d929cc7c8@arm.com>

On Tue, 18 Dec 2018, Julien Grall wrote:
> Hi Stefano,
> 
> On 12/17/18 10:10 PM, Stefano Stabellini wrote:
> > +    /* These calls are safe and always allowed.  */
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_CALL_COUNT):
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_UID):
> > +    case EEMI_FID(ZYNQMP_SIP_SVC_VERSION):
> 
> I am a bit surprised that you implement those one using SMC64. Why would you
> duplicate the SMC32 version (ARM_SMCCC_CALL_COUNT_FID(SIP))?

This is a mistake introduced in the last couple of versions, good catch.
ZYNQMP_SIP_SVC_* were preexisting, they go back to the initial
implementation by Edgar. The way the code was written before, it didn't
matter if the call was SMC32 or SMC64. Now that we match on the full
FID, and that we have the right SMC32 calls handled, I'll remove these 3
cases completely.


> I also don't seem to find them neither in the spec nor in the ATF code.

Yes, I raised the issue internally. In any case, I think it makes sense
to handle the mandatory calls in Xen by forwarding them to firmware.


> The rest of the code looks good to me.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2018-12-18 22:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 22:10 [PATCH v7 0/6] zynqmp: Add forwarding of platform specific firmware calls Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 1/6] xen/arm: introduce platform_smc Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 2/6] xen/arm: zynqmp: Forward plaform specific firmware calls Stefano Stabellini
2018-12-18 15:49   ` Julien Grall
2018-12-17 22:10 ` [PATCH v7 3/6] xen/arm: zynqmp: introduce zynqmp specific defines Stefano Stabellini
2018-12-18 15:51   ` Julien Grall
2018-12-18 22:36     ` Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 4/6] xen/arm: zynqmp: implement zynqmp_eemi Stefano Stabellini
2018-12-18 16:02   ` Julien Grall
2018-12-18 22:36     ` Stefano Stabellini [this message]
2018-12-18 16:15   ` Julien Grall
2018-12-18 22:36     ` Stefano Stabellini
2018-12-19 13:14       ` Julien Grall
2018-12-20  0:32         ` Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 5/6] xen/arm: zynqmp: Remove blacklist of ZynqMP's PM node Stefano Stabellini
2018-12-18 16:02   ` Julien Grall
2018-12-17 22:10 ` [PATCH v7 6/6] xen/zynqmp: add IPI calls virtualization Stefano Stabellini
2018-12-18 16:03   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.10.1812181308220.15901@sstabellini-ThinkPad-X260 \
    --to=sstabellini@kernel.org \
    --cc=edgar.iglesias@xilinx.com \
    --cc=julien.grall@arm.com \
    --cc=saeed.nowshadi@xilinx.com \
    --cc=stefanos@xilinx.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.