From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>, xen-devel@lists.xen.org
Cc: edgar.iglesias@xilinx.com,
Stefano Stabellini <stefanos@xilinx.com>,
saeed.nowshadi@xilinx.com
Subject: Re: [PATCH v7 4/6] xen/arm: zynqmp: implement zynqmp_eemi
Date: Tue, 18 Dec 2018 16:15:07 +0000 [thread overview]
Message-ID: <e366da30-eecf-c8dc-45c9-f3349eb11b36@arm.com> (raw)
In-Reply-To: <1545084630-3873-4-git-send-email-sstabellini@kernel.org>
Hi,
On 12/17/18 10:10 PM, Stefano Stabellini wrote:
> + /* These calls are safe and always allowed. */
> + case EEMI_FID(ZYNQMP_SIP_SVC_CALL_COUNT):
> + case EEMI_FID(ZYNQMP_SIP_SVC_UID):
> + case EEMI_FID(ZYNQMP_SIP_SVC_VERSION):
> + case EEMI_FID(PM_GET_TRUSTZONE_VERSION):
> + case EEMI_FID(PM_GET_API_VERSION):
Above you say the call to PM_GET_API_VERSION are safe and always
allowed. But looking at the ATF implementation the first call to
PM_GET_API_VERSION will enable IPI IRQ.
AFAICT, Dom0 will be the only domain to access IPI. So what happen if,
in the Dom0less case, the guest is booting before and calling
PM_GET_API_VERSION?
I haven't looked in depth the other SIP functions to see whether there
are other potential issue.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2018-12-18 16:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 22:10 [PATCH v7 0/6] zynqmp: Add forwarding of platform specific firmware calls Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 1/6] xen/arm: introduce platform_smc Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 2/6] xen/arm: zynqmp: Forward plaform specific firmware calls Stefano Stabellini
2018-12-18 15:49 ` Julien Grall
2018-12-17 22:10 ` [PATCH v7 3/6] xen/arm: zynqmp: introduce zynqmp specific defines Stefano Stabellini
2018-12-18 15:51 ` Julien Grall
2018-12-18 22:36 ` Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 4/6] xen/arm: zynqmp: implement zynqmp_eemi Stefano Stabellini
2018-12-18 16:02 ` Julien Grall
2018-12-18 22:36 ` Stefano Stabellini
2018-12-18 16:15 ` Julien Grall [this message]
2018-12-18 22:36 ` Stefano Stabellini
2018-12-19 13:14 ` Julien Grall
2018-12-20 0:32 ` Stefano Stabellini
2018-12-17 22:10 ` [PATCH v7 5/6] xen/arm: zynqmp: Remove blacklist of ZynqMP's PM node Stefano Stabellini
2018-12-18 16:02 ` Julien Grall
2018-12-17 22:10 ` [PATCH v7 6/6] xen/zynqmp: add IPI calls virtualization Stefano Stabellini
2018-12-18 16:03 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e366da30-eecf-c8dc-45c9-f3349eb11b36@arm.com \
--to=julien.grall@arm.com \
--cc=edgar.iglesias@xilinx.com \
--cc=saeed.nowshadi@xilinx.com \
--cc=sstabellini@kernel.org \
--cc=stefanos@xilinx.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.