From: Christoph Lameter <cl@gentwo.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <sasha.levin@oracle.com>,
akpm@linux-foundation.org, Gilad Ben-Yossef <gilad@benyossef.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <johnstul@us.ibm.com>,
Mike Frysinger <vapier@gentoo.org>,
Minchan Kim <minchan.kim@gmail.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Max Krasnyansky <maxk@qualcomm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hughd@google.com, viresh.kumar@linaro.org, hpa@zytor.com,
mingo@kernel.org
Subject: Re: vmstat: On demand vmstat workers V8
Date: Wed, 30 Jul 2014 09:34:16 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1407300933370.4608@gentwo.org> (raw)
In-Reply-To: <53D8626E.5060900@cn.fujitsu.com>
On Wed, 30 Jul 2014, Lai Jiangshan wrote:
> >
> >
> > Index: linux/mm/vmstat.c
> > ===================================================================
> > --- linux.orig/mm/vmstat.c 2014-07-29 10:22:45.073884943 -0500
> > +++ linux/mm/vmstat.c 2014-07-29 10:34:45.083369228 -0500
> > @@ -1277,8 +1277,8 @@ static int vmstat_cpuup_callback(struct
> > break;
> > case CPU_DOWN_PREPARE:
> > case CPU_DOWN_PREPARE_FROZEN:
> > - cancel_delayed_work_sync(&per_cpu(vmstat_work, cpu));
> > per_cpu(vmstat_work, cpu).work.func = NULL;
> > + cancel_delayed_work_sync(&per_cpu(vmstat_work, cpu));
>
> I think we should just remove "per_cpu(vmstat_work, cpu).work.func = NULL;"
It has been removed by the vmstat patch. The patch I posted is against
upstream not against -next.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@gentwo.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Tejun Heo <tj@kernel.org>, Peter Zijlstra <peterz@infradead.org>,
Sasha Levin <sasha.levin@oracle.com>,
akpm@linux-foundation.org, Gilad Ben-Yossef <gilad@benyossef.com>,
Thomas Gleixner <tglx@linutronix.de>,
John Stultz <johnstul@us.ibm.com>,
Mike Frysinger <vapier@gentoo.org>,
Minchan Kim <minchan.kim@gmail.com>,
Hakan Akkan <hakanakkan@gmail.com>,
Max Krasnyansky <maxk@qualcomm.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
hughd@google.com, viresh.kumar@linaro.org, hpa@zytor.com,
mingo@kernel.org
Subject: Re: vmstat: On demand vmstat workers V8
Date: Wed, 30 Jul 2014 09:34:16 -0500 (CDT) [thread overview]
Message-ID: <alpine.DEB.2.11.1407300933370.4608@gentwo.org> (raw)
In-Reply-To: <53D8626E.5060900@cn.fujitsu.com>
On Wed, 30 Jul 2014, Lai Jiangshan wrote:
> >
> >
> > Index: linux/mm/vmstat.c
> > ===================================================================
> > --- linux.orig/mm/vmstat.c 2014-07-29 10:22:45.073884943 -0500
> > +++ linux/mm/vmstat.c 2014-07-29 10:34:45.083369228 -0500
> > @@ -1277,8 +1277,8 @@ static int vmstat_cpuup_callback(struct
> > break;
> > case CPU_DOWN_PREPARE:
> > case CPU_DOWN_PREPARE_FROZEN:
> > - cancel_delayed_work_sync(&per_cpu(vmstat_work, cpu));
> > per_cpu(vmstat_work, cpu).work.func = NULL;
> > + cancel_delayed_work_sync(&per_cpu(vmstat_work, cpu));
>
> I think we should just remove "per_cpu(vmstat_work, cpu).work.func = NULL;"
It has been removed by the vmstat patch. The patch I posted is against
upstream not against -next.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2014-07-30 14:34 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-10 14:04 vmstat: On demand vmstat workers V8 Christoph Lameter
2014-07-10 14:04 ` Christoph Lameter
2014-07-11 13:20 ` Frederic Weisbecker
2014-07-11 13:20 ` Frederic Weisbecker
2014-07-11 13:56 ` Christoph Lameter
2014-07-11 13:56 ` Christoph Lameter
2014-07-11 13:58 ` Frederic Weisbecker
2014-07-11 13:58 ` Frederic Weisbecker
2014-07-11 15:17 ` Christoph Lameter
2014-07-11 15:17 ` Christoph Lameter
2014-07-11 15:19 ` Frederic Weisbecker
2014-07-11 15:19 ` Frederic Weisbecker
2014-07-11 15:22 ` Christoph Lameter
2014-07-11 15:22 ` Christoph Lameter
2014-07-14 20:10 ` Hugh Dickins
2014-07-14 20:10 ` Hugh Dickins
2014-07-14 20:51 ` Christoph Lameter
2014-07-14 20:51 ` Christoph Lameter
2014-07-30 3:04 ` Lai Jiangshan
2014-07-30 3:04 ` Lai Jiangshan
2014-07-26 2:22 ` Sasha Levin
2014-07-26 2:22 ` Sasha Levin
2014-07-28 18:55 ` Christoph Lameter
2014-07-28 18:55 ` Christoph Lameter
2014-07-28 21:54 ` Andrew Morton
2014-07-28 21:54 ` Andrew Morton
2014-07-28 22:00 ` Sasha Levin
2014-07-28 22:00 ` Sasha Levin
2014-07-29 15:17 ` Christoph Lameter
2014-07-29 15:17 ` Christoph Lameter
2014-07-29 7:56 ` Peter Zijlstra
2014-07-29 12:05 ` Tejun Heo
2014-07-29 12:05 ` Tejun Heo
2014-07-29 12:23 ` Peter Zijlstra
2014-07-29 12:23 ` Peter Zijlstra
2014-07-29 13:12 ` Tejun Heo
2014-07-29 13:12 ` Tejun Heo
2014-07-29 15:10 ` Christoph Lameter
2014-07-29 15:10 ` Christoph Lameter
2014-07-29 15:14 ` Tejun Heo
2014-07-29 15:14 ` Tejun Heo
2014-07-29 15:26 ` Christoph Lameter
2014-07-29 15:26 ` Christoph Lameter
2014-07-29 15:39 ` Christoph Lameter
2014-07-29 15:39 ` Christoph Lameter
2014-07-29 15:47 ` Sasha Levin
2014-07-29 15:47 ` Sasha Levin
2014-07-29 15:59 ` Christoph Lameter
2014-07-29 15:59 ` Christoph Lameter
2014-07-30 3:11 ` Lai Jiangshan
2014-07-30 3:11 ` Lai Jiangshan
2014-07-30 14:34 ` Christoph Lameter [this message]
2014-07-30 14:34 ` Christoph Lameter
2014-07-29 15:22 ` Christoph Lameter
2014-07-29 15:22 ` Christoph Lameter
2014-07-29 15:43 ` Sasha Levin
2014-07-29 15:43 ` Sasha Levin
2014-08-04 21:37 ` Sasha Levin
2014-08-04 21:37 ` Sasha Levin
2014-08-05 14:51 ` Christoph Lameter
2014-08-05 14:51 ` Christoph Lameter
2014-08-05 22:25 ` Sasha Levin
2014-08-05 22:25 ` Sasha Levin
2014-08-06 14:12 ` Christoph Lameter
2014-08-06 14:12 ` Christoph Lameter
2014-08-07 1:50 ` Sasha Levin
2014-08-07 1:50 ` Sasha Levin
2014-07-30 2:57 ` Lai Jiangshan
2014-07-30 2:57 ` Lai Jiangshan
2014-07-30 14:45 ` Christoph Lameter
2014-07-30 14:45 ` Christoph Lameter
2014-07-31 0:52 ` Lai Jiangshan
2014-07-31 0:52 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1407300933370.4608@gentwo.org \
--to=cl@gentwo.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=gilad@benyossef.com \
--cc=hakanakkan@gmail.com \
--cc=hpa@zytor.com \
--cc=hughd@google.com \
--cc=johnstul@us.ibm.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maxk@qualcomm.com \
--cc=minchan.kim@gmail.com \
--cc=mingo@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=vapier@gentoo.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.