From: Thomas Gleixner <tglx@linutronix.de> To: Baolin Wang <baolin.wang@linaro.org> Cc: arnd@arndb.de, john.stultz@linaro.org, heenasirwani@gmail.com, pang.xunlei@linaro.org, peterz@infradead.org, rafael.j.wysocki@intel.com, gregkh@linuxfoundation.org, richardcochran@gmail.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, linux390@de.ibm.com, rth@twiddle.net, riel@redhat.com, cl@linux.com, tj@kernel.org, fweisbec@gmail.com, ahh@google.com, pjt@google.com, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, y2038@lists.linaro.org Subject: Re: [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function Date: Mon, 20 Apr 2015 23:09:17 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.11.1504202249590.13914@nanos> (raw) In-Reply-To: <1429509459-17068-10-git-send-email-baolin.wang@linaro.org> On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces some functions for converting cputime to timespec64 and back, > that repalce the timespec type with timespec64 type, as well as for arch/s390 and > arch/powerpc architecture. No. We want a patch which adds the functions and then a patch which uses them. This stuff is tricky and hard to review. So please split the patches into smaller chunks. > +unsigned long > +timespec64_to_jiffies(const struct timespec64 *value) > +{ > + return __timespec_to_jiffies(value->tv_sec, value->tv_nsec); > +} > +EXPORT_SYMBOL(timespec64_to_jiffies); So we have now two exports which are doing exactly the same thing. Copy and paste is wonderful, right? What about exporting __timespec_to_jiffies() and providing inlines for timespec_to_jiffies() and timespec64_to_jiffies() ? EXPORT_SYMBOL is not just a stupid annotation. Its impact on the resulting kernel size is larger than the actual function implementation. > +void > +jiffies_to_timespec64(const unsigned long jiffies, struct timespec64 *value) > +{ > + /* > + * Convert jiffies to nanoseconds and separate with > + * one divide. > + */ > + u32 rem; > + value->tv_sec = div_u64_rem((u64)jiffies * TICK_NSEC, > + NSEC_PER_SEC, &rem); > + value->tv_nsec = rem; > +} > +EXPORT_SYMBOL(jiffies_to_timespec64); Sigh. Thanks, tglx
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de> To: Baolin Wang <baolin.wang@linaro.org> Cc: pang.xunlei@linaro.org, peterz@infradead.org, heiko.carstens@de.ibm.com, paulus@samba.org, cl@linux.com, heenasirwani@gmail.com, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, y2038@lists.linaro.org, rafael.j.wysocki@intel.com, ahh@google.com, fweisbec@gmail.com, pjt@google.com, riel@redhat.com, arnd@arndb.de, richardcochran@gmail.com, schwidefsky@de.ibm.com, john.stultz@linaro.org, rth@twiddle.net, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tj@kernel.org, linux390@de.ibm.com, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function Date: Mon, 20 Apr 2015 23:09:17 +0200 (CEST) [thread overview] Message-ID: <alpine.DEB.2.11.1504202249590.13914@nanos> (raw) In-Reply-To: <1429509459-17068-10-git-send-email-baolin.wang@linaro.org> On Mon, 20 Apr 2015, Baolin Wang wrote: > This patch introduces some functions for converting cputime to timespec64 and back, > that repalce the timespec type with timespec64 type, as well as for arch/s390 and > arch/powerpc architecture. No. We want a patch which adds the functions and then a patch which uses them. This stuff is tricky and hard to review. So please split the patches into smaller chunks. > +unsigned long > +timespec64_to_jiffies(const struct timespec64 *value) > +{ > + return __timespec_to_jiffies(value->tv_sec, value->tv_nsec); > +} > +EXPORT_SYMBOL(timespec64_to_jiffies); So we have now two exports which are doing exactly the same thing. Copy and paste is wonderful, right? What about exporting __timespec_to_jiffies() and providing inlines for timespec_to_jiffies() and timespec64_to_jiffies() ? EXPORT_SYMBOL is not just a stupid annotation. Its impact on the resulting kernel size is larger than the actual function implementation. > +void > +jiffies_to_timespec64(const unsigned long jiffies, struct timespec64 *value) > +{ > + /* > + * Convert jiffies to nanoseconds and separate with > + * one divide. > + */ > + u32 rem; > + value->tv_sec = div_u64_rem((u64)jiffies * TICK_NSEC, > + NSEC_PER_SEC, &rem); > + value->tv_nsec = rem; > +} > +EXPORT_SYMBOL(jiffies_to_timespec64); Sigh. Thanks, tglx
next prev parent reply other threads:[~2015-04-20 21:09 UTC|newest] Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-04-20 5:57 [PATCH 00/11] Convert the posix_clock_operations and k_clock structure to ready for 2038 Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 01/11] linux/time64.h:Introduce the 'struct itimerspec64' for 64bit Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 9:49 ` Sergei Shtylyov 2015-04-20 9:49 ` Sergei Shtylyov 2015-04-20 10:55 ` Baolin Wang 2015-04-20 10:55 ` Baolin Wang 2015-04-20 19:14 ` Thomas Gleixner 2015-04-20 19:14 ` Thomas Gleixner 2015-04-20 19:59 ` Thomas Gleixner 2015-04-20 19:59 ` Thomas Gleixner 2015-04-21 8:19 ` Baolin Wang 2015-04-21 8:19 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 02/11] timekeeping:Introduce the current_kernel_time64() function with timespec64 type Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 03/11] time/hrtimer:Introduce hrtimer_get_res64() with timespec64 type for getting the timer resolution Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 19:15 ` Thomas Gleixner 2015-04-20 19:15 ` Thomas Gleixner 2015-04-20 5:57 ` [PATCH 04/11] posix timers:Introduce the 64bit methods with timespec64 type for k_clock structure Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 20:40 ` Thomas Gleixner 2015-04-20 20:40 ` Thomas Gleixner 2015-04-21 8:59 ` [Y2038] " Arnd Bergmann 2015-04-21 8:59 ` Arnd Bergmann 2015-04-21 14:14 ` Thomas Gleixner 2015-04-21 14:14 ` Thomas Gleixner 2015-04-21 14:57 ` Arnd Bergmann 2015-04-21 14:57 ` Arnd Bergmann 2015-04-21 14:57 ` Arnd Bergmann 2015-04-21 15:13 ` Thomas Gleixner 2015-04-21 15:13 ` Thomas Gleixner 2015-04-21 15:40 ` Arnd Bergmann 2015-04-21 15:40 ` Arnd Bergmann 2015-04-21 15:40 ` Arnd Bergmann 2015-04-21 15:40 ` Arnd Bergmann 2015-04-21 20:13 ` Thomas Gleixner 2015-04-21 20:13 ` Thomas Gleixner 2015-04-22 8:45 ` Thomas Gleixner 2015-04-22 8:45 ` Thomas Gleixner 2015-04-22 10:11 ` Richard Cochran 2015-04-22 10:11 ` Richard Cochran 2015-04-22 10:44 ` David Laight 2015-04-22 10:44 ` David Laight 2015-04-22 10:44 ` David Laight 2015-04-22 10:44 ` David Laight 2015-04-22 11:07 ` Arnd Bergmann 2015-04-22 11:07 ` Arnd Bergmann 2015-04-22 13:37 ` Thomas Gleixner 2015-04-22 13:37 ` Thomas Gleixner 2015-04-22 13:50 ` Arnd Bergmann 2015-04-22 13:50 ` Arnd Bergmann 2015-04-22 14:54 ` Richard Cochran 2015-04-22 14:54 ` Richard Cochran 2015-04-22 15:37 ` Arnd Bergmann 2015-04-22 15:37 ` Arnd Bergmann 2015-04-22 15:14 ` Luc Van Oostenryck 2015-04-22 15:14 ` Luc Van Oostenryck 2015-04-22 15:14 ` Luc Van Oostenryck 2015-04-22 15:38 ` Arnd Bergmann 2015-04-22 15:38 ` Arnd Bergmann 2015-04-22 15:38 ` Arnd Bergmann 2015-04-20 5:57 ` [PATCH 05/11] time/posix-timers:Convert to the 64bit methods for k_clock callback functions Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 20:48 ` Thomas Gleixner 2015-04-20 20:48 ` Thomas Gleixner 2015-04-21 8:36 ` Baolin Wang 2015-04-21 8:36 ` Baolin Wang 2015-04-21 8:45 ` [Y2038] " Arnd Bergmann 2015-04-21 8:45 ` Arnd Bergmann 2015-04-21 8:45 ` Arnd Bergmann 2015-04-21 8:55 ` Baolin Wang 2015-04-21 8:55 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 06/11] char/mmtimer:Convert to the 64bit methods for k_clock callback function Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 07/11] time/alarmtimer:Convert to the new methods for k_clock structure Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 08/11] time/posix-clock:Convert to the 64bit methods for k_clock and posix_clock_operations structure Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 09/11] cputime:Introduce the cputime_to_timespec64/timespec64_to_cputime function Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 21:09 ` Thomas Gleixner [this message] 2015-04-20 21:09 ` Thomas Gleixner 2015-04-20 5:57 ` [PATCH 10/11] time/posix-cpu-timers:Convert to the 64bit methods for k_clock structure Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 5:57 ` [PATCH 11/11] k_clock:Remove the 32bit methods with timespec type Baolin Wang 2015-04-20 5:57 ` Baolin Wang 2015-04-20 8:42 ` Richard Cochran 2015-04-20 8:42 ` Richard Cochran 2015-04-20 9:00 ` Baolin Wang 2015-04-20 9:00 ` Baolin Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=alpine.DEB.2.11.1504202249590.13914@nanos \ --to=tglx@linutronix.de \ --cc=ahh@google.com \ --cc=arnd@arndb.de \ --cc=baolin.wang@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=cl@linux.com \ --cc=fweisbec@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=heenasirwani@gmail.com \ --cc=heiko.carstens@de.ibm.com \ --cc=john.stultz@linaro.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux390@de.ibm.com \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=netdev@vger.kernel.org \ --cc=pang.xunlei@linaro.org \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=pjt@google.com \ --cc=rafael.j.wysocki@intel.com \ --cc=richardcochran@gmail.com \ --cc=riel@redhat.com \ --cc=rth@twiddle.net \ --cc=schwidefsky@de.ibm.com \ --cc=tj@kernel.org \ --cc=y2038@lists.linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.