All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned
@ 2016-09-29 11:59 Muraru Mihaela
  2016-09-29 12:26 ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Muraru Mihaela @ 2016-09-29 11:59 UTC (permalink / raw)
  To: Julia Lawall; +Cc: outreachy-kernel

Replace the unsigned with the unsigned int,to decrease the programming
errors that can give the usage of simply unsigned.

Warning found by checkpatch.pl :

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'.

Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>

---

Changes in v2:
	- specify the type of the parameter type from function
	bcm2048_prop_write as unsigned int.
	This reduce the compiling problem and reduce to silent the checker.
---
 drivers/staging/media/bcm2048/radio-bcm2048.c | 46 +++++++++++++--------------
 1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
index ea15cc6..4f73bda 100644
--- a/drivers/staging/media/bcm2048/radio-bcm2048.c
+++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
@@ -1942,7 +1942,7 @@ static ssize_t bcm2048_##prop##_write(struct device *dev,		\
 					size_t count)			\
 {									\
 	struct bcm2048_device *bdev = dev_get_drvdata(dev);		\
-	type value;							\
+	unsigned int value;						\
 	int err;							\
 									\
 	if (!bdev)							\
@@ -2022,27 +2022,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
 	return count;							\
 }
 
-DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
-
-DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
-
-DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
-DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
+
+DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
+
+DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
 property_read(rds_pi, unsigned int, "%x")
 property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
 property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
@@ -2054,7 +2054,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
 property_read(region_top_frequency, unsigned int, "%u")
 property_signed_read(fm_carrier_error, int, "%d")
 property_signed_read(fm_rssi, int, "%d")
-DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
+DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
 
 static struct device_attribute attrs[] = {
 	__ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned
  2016-09-29 11:59 [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned Muraru Mihaela
@ 2016-09-29 12:26 ` Julia Lawall
  2016-09-29 14:30   ` Muraru Mihaela
  0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2016-09-29 12:26 UTC (permalink / raw)
  To: Muraru Mihaela; +Cc: outreachy-kernel



On Thu, 29 Sep 2016, Muraru Mihaela wrote:

> Replace the unsigned with the unsigned int,to decrease the programming
> errors that can give the usage of simply unsigned.
>
> Warning found by checkpatch.pl :
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'.
>
> Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
>
> ---
>
> Changes in v2:
> 	- specify the type of the parameter type from function
> 	bcm2048_prop_write as unsigned int.
> 	This reduce the compiling problem and reduce to silent the checker.
> ---
>  drivers/staging/media/bcm2048/radio-bcm2048.c | 46 +++++++++++++--------------
>  1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> index ea15cc6..4f73bda 100644
> --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> @@ -1942,7 +1942,7 @@ static ssize_t bcm2048_##prop##_write(struct device *dev,		\
>  					size_t count)			\
>  {									\
>  	struct bcm2048_device *bdev = dev_get_drvdata(dev);		\
> -	type value;							\
> +	unsigned int value;						\
>  	int err;							\
>  									\
>  	if (!bdev)							\
> @@ -2022,27 +2022,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
>  	return count;							\
>  }
>
> -DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
> -
> -DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
> -
> -DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
> -DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
> +
> +DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
> +
> +DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)

Are you sure that these are correct?

julia

>  property_read(rds_pi, unsigned int, "%x")
>  property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
>  property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
> @@ -2054,7 +2054,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
>  property_read(region_top_frequency, unsigned int, "%u")
>  property_signed_read(fm_carrier_error, int, "%d")
>  property_signed_read(fm_rssi, int, "%d")
> -DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
> +DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
>
>  static struct device_attribute attrs[] = {
>  	__ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
> --
> 1.9.1
>
>


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned
  2016-09-29 12:26 ` Julia Lawall
@ 2016-09-29 14:30   ` Muraru Mihaela
  2016-09-29 14:32     ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Muraru Mihaela @ 2016-09-29 14:30 UTC (permalink / raw)
  To: Julia Lawall; +Cc: outreachy-kernel

On Thu, Sep 29, 2016 at 02:26:51PM +0200, Julia Lawall wrote:
> 
> 
> On Thu, 29 Sep 2016, Muraru Mihaela wrote:
> 
> > Replace the unsigned with the unsigned int,to decrease the programming
> > errors that can give the usage of simply unsigned.
> >
> > Warning found by checkpatch.pl :
> >
> > WARNING: Prefer 'unsigned int' to bare use of 'unsigned'.
> >
> > Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
> >
> > ---
> >
> > Changes in v2:
> > 	- specify the type of the parameter type from function
> > 	bcm2048_prop_write as unsigned int.
> > 	This reduce the compiling problem and reduce to silent the checker.
> > ---
> >  drivers/staging/media/bcm2048/radio-bcm2048.c | 46 +++++++++++++--------------
> >  1 file changed, 23 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > index ea15cc6..4f73bda 100644
> > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > @@ -1942,7 +1942,7 @@ static ssize_t bcm2048_##prop##_write(struct device *dev,		\
> >  					size_t count)			\
> >  {									\
> >  	struct bcm2048_device *bdev = dev_get_drvdata(dev);		\
> > -	type value;							\
> > +	unsigned int value;						\
> >  	int err;							\
> >  									\
> >  	if (!bdev)							\
> > @@ -2022,27 +2022,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
> >  	return count;							\
> >  }
> >
> > -DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
> > -
> > -DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
> > -
> > -DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
> > -DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
> > +
> > +DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
> > +
> > +DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
> 
> Are you sure that these are correct?
> 
> julia

I don't have compilation errors or checkpatch.pl warnings.
Can you tell me other metods o check it ?

thanks,

mihaela
> >  property_read(rds_pi, unsigned int, "%x")
> >  property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
> >  property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
> > @@ -2054,7 +2054,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
> >  property_read(region_top_frequency, unsigned int, "%u")
> >  property_signed_read(fm_carrier_error, int, "%d")
> >  property_signed_read(fm_rssi, int, "%d")
> > -DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
> > +DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
> >
> >  static struct device_attribute attrs[] = {
> >  	__ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
> > --
> > 1.9.1
> >
> >


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned
  2016-09-29 14:30   ` Muraru Mihaela
@ 2016-09-29 14:32     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-09-29 14:32 UTC (permalink / raw)
  To: Muraru Mihaela; +Cc: outreachy-kernel



On Thu, 29 Sep 2016, Muraru Mihaela wrote:

> On Thu, Sep 29, 2016 at 02:26:51PM +0200, Julia Lawall wrote:
> >
> >
> > On Thu, 29 Sep 2016, Muraru Mihaela wrote:
> >
> > > Replace the unsigned with the unsigned int,to decrease the programming
> > > errors that can give the usage of simply unsigned.
> > >
> > > Warning found by checkpatch.pl :
> > >
> > > WARNING: Prefer 'unsigned int' to bare use of 'unsigned'.
> > >
> > > Signed-off-by: Muraru Mihaela <mihaela.muraru21@gmail.com>
> > >
> > > ---
> > >
> > > Changes in v2:
> > > 	- specify the type of the parameter type from function
> > > 	bcm2048_prop_write as unsigned int.
> > > 	This reduce the compiling problem and reduce to silent the checker.
> > > ---
> > >  drivers/staging/media/bcm2048/radio-bcm2048.c | 46 +++++++++++++--------------
> > >  1 file changed, 23 insertions(+), 23 deletions(-)
> > >
> > > diff --git a/drivers/staging/media/bcm2048/radio-bcm2048.c b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > index ea15cc6..4f73bda 100644
> > > --- a/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > +++ b/drivers/staging/media/bcm2048/radio-bcm2048.c
> > > @@ -1942,7 +1942,7 @@ static ssize_t bcm2048_##prop##_write(struct device *dev,		\
> > >  					size_t count)			\
> > >  {									\
> > >  	struct bcm2048_device *bdev = dev_get_drvdata(dev);		\
> > > -	type value;							\
> > > +	unsigned int value;						\
> > >  	int err;							\
> > >  									\
> > >  	if (!bdev)							\
> > > @@ -2022,27 +2022,27 @@ static ssize_t bcm2048_##prop##_read(struct device *dev,		\
> > >  	return count;							\
> > >  }
> > >
> > > -DEFINE_SYSFS_PROPERTY(power_state, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(mute, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(audio_route, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(dac_output, unsigned, int, "%u", 0)
> > > -
> > > -DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned, int, "%u", value > 3)
> > > -
> > > -DEFINE_SYSFS_PROPERTY(rds, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned, int, "%u", 0)
> > > -DEFINE_SYSFS_PROPERTY(rds_wline, unsigned, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(power_state, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(mute, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(audio_route, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(dac_output, unsigned int, int, "%u", 0)
> > > +
> > > +DEFINE_SYSFS_PROPERTY(fm_hi_lo_injection, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_frequency, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_af_frequency, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_deemphasis, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_rds_mask, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_best_tune_mode, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_search_rssi_threshold, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_search_mode_direction, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(fm_search_tune_mode, unsigned int, int, "%u", value > 3)
> > > +
> > > +DEFINE_SYSFS_PROPERTY(rds, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(rds_b_block_mask, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(rds_b_block_match, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(rds_pi_mask, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(rds_pi_match, unsigned int, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(rds_wline, unsigned int, int, "%u", 0)
> >
> > Are you sure that these are correct?
> >
> > julia
>
> I don't have compilation errors or checkpatch.pl warnings.
> Can you tell me other metods o check it ?

Look at the definition of the macro.

Do make filename.i (for the actual filename) and see what it expands into.

julia

>
> thanks,
>
> mihaela
> > >  property_read(rds_pi, unsigned int, "%x")
> > >  property_str_read(rds_rt, (BCM2048_MAX_RDS_RT + 1))
> > >  property_str_read(rds_ps, (BCM2048_MAX_RDS_PS + 1))
> > > @@ -2054,7 +2054,7 @@ property_read(region_bottom_frequency, unsigned int, "%u")
> > >  property_read(region_top_frequency, unsigned int, "%u")
> > >  property_signed_read(fm_carrier_error, int, "%d")
> > >  property_signed_read(fm_rssi, int, "%d")
> > > -DEFINE_SYSFS_PROPERTY(region, unsigned, int, "%u", 0)
> > > +DEFINE_SYSFS_PROPERTY(region, unsigned int, int, "%u", 0)
> > >
> > >  static struct device_attribute attrs[] = {
> > >  	__ATTR(power_state, S_IRUGO | S_IWUSR, bcm2048_power_state_read,
> > > --
> > > 1.9.1
> > >
> > >
>


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-09-29 14:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-29 11:59 [PATCH v2] Staging : media: bcm2048: radio-bcm2048.c: Use unsigned int rather than unisigned Muraru Mihaela
2016-09-29 12:26 ` Julia Lawall
2016-09-29 14:30   ` Muraru Mihaela
2016-09-29 14:32     ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.