All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: will.deacon@arm.com, robin.murphy@arm.com, joro@8bytes.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures
Date: Tue, 25 Oct 2016 22:21:28 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1610252221141.2062@hadrien> (raw)
In-Reply-To: <1477418772-12184-2-git-send-email-bhumirks@gmail.com>



On Tue, 25 Oct 2016, Bhumika Goyal wrote:

> Check for iommu_gather_ops structures that are only stored in the tlb
> field of an io_pgtable_cfg structure. The tlb field is of type
> const struct iommu_gather_ops *, so iommu_gather_ops structures
> having this property can be declared as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/iommu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index c841eb7..a5bc8fb 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -640,7 +640,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
>  	}
>  }
>
> -static struct iommu_gather_ops arm_smmu_gather_ops = {
> +static const struct iommu_gather_ops arm_smmu_gather_ops = {
>  	.tlb_flush_all	= arm_smmu_tlb_inv_context,
>  	.tlb_add_flush	= arm_smmu_tlb_inv_range_nosync,
>  	.tlb_sync	= arm_smmu_tlb_sync,
> --
> 1.9.1
>
>

WARNING: multiple messages have this Message-ID (diff)
From: julia.lawall@lip6.fr (Julia Lawall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures
Date: Tue, 25 Oct 2016 22:21:28 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1610252221141.2062@hadrien> (raw)
In-Reply-To: <1477418772-12184-2-git-send-email-bhumirks@gmail.com>



On Tue, 25 Oct 2016, Bhumika Goyal wrote:

> Check for iommu_gather_ops structures that are only stored in the tlb
> field of an io_pgtable_cfg structure. The tlb field is of type
> const struct iommu_gather_ops *, so iommu_gather_ops structures
> having this property can be declared as const.
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
>  drivers/iommu/arm-smmu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index c841eb7..a5bc8fb 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -640,7 +640,7 @@ static void arm_smmu_tlb_inv_range_nosync(unsigned long iova, size_t size,
>  	}
>  }
>
> -static struct iommu_gather_ops arm_smmu_gather_ops = {
> +static const struct iommu_gather_ops arm_smmu_gather_ops = {
>  	.tlb_flush_all	= arm_smmu_tlb_inv_context,
>  	.tlb_add_flush	= arm_smmu_tlb_inv_range_nosync,
>  	.tlb_sync	= arm_smmu_tlb_sync,
> --
> 1.9.1
>
>

  reply	other threads:[~2016-10-25 20:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 18:06 [PATCH 0/3] drivers: iommu: declare iommu_gather_ops structures as const Bhumika Goyal
2016-10-25 18:06 ` Bhumika Goyal
2016-10-25 18:06 ` [PATCH 1/3] drivers: iommu: arm-smmu: constify iommu_gather_ops structures Bhumika Goyal
2016-10-25 18:06   ` Bhumika Goyal
2016-10-25 18:06   ` Bhumika Goyal
2016-10-25 20:21   ` Julia Lawall [this message]
2016-10-25 20:21     ` Julia Lawall
2016-10-25 18:06 ` [PATCH 2/3] drivers: iommu: arm-smmu-v3: " Bhumika Goyal
2016-10-25 18:06   ` Bhumika Goyal
2016-10-25 20:20   ` Julia Lawall
2016-10-25 20:20     ` Julia Lawall
2016-10-25 18:06 ` [PATCH 3/3] drivers: iommu: io-pgtable-arm: use const and __initconst for " Bhumika Goyal
2016-10-25 18:06   ` Bhumika Goyal
2016-10-25 18:06   ` Bhumika Goyal
2016-10-25 20:18   ` Julia Lawall
2016-10-25 20:18     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1610252221141.2062@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=bhumirks@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.