Re: [Outreachy kernel] [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line.

[Julia Lawall <julia.lawall@lip6.fr>]

On Fri, 17 Feb 2017, Julia Lawall wrote:

>
>
> On Fri, 17 Feb 2017, Varsha Rao wrote:
>
> > Moved logical OR operator to previous line to fix the following
> > checkpatch issue:
> >
> > CHECK: Logical continuations should be on the previous line.
>
> Acked-by: drivers/staging/rtl8712/ieee80211.c

Sorry!

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
> > Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> > ---
> >  v2:
> >
> >  -Edited commit message.
> >  -Fixed the warning of line over 80 characters.
> >
> >  drivers/staging/rtl8712/ieee80211.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > index d84da2b..f35121e 100644
> > --- a/drivers/staging/rtl8712/ieee80211.c
> > +++ b/drivers/staging/rtl8712/ieee80211.c
> > @@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
> >  		/* No WPA IE - fail silently */
> >  		return _FAIL;
> >  	}
> > -	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
> > -	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
> > +	if ((*wpa_ie != _WPA_IE_ID_) ||
> > +	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
> > +	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
> >  		return _FAIL;
> >  	pos = wpa_ie;
> >  	pos += 8;
> > --
> > 2.9.3
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170217051238.GA3213%40euri.
> > For more options, visit https://groups.google.com/d/optout.
> >
>