All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line.
@ 2017-02-17  5:12 Varsha Rao
  2017-02-17  5:50 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Varsha Rao @ 2017-02-17  5:12 UTC (permalink / raw)
  To: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman, outreachy-kernel

Moved logical OR operator to previous line to fix the following
checkpatch issue:

CHECK: Logical continuations should be on the previous line.

Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
---
 v2:

 -Edited commit message.
 -Fixed the warning of line over 80 characters.

 drivers/staging/rtl8712/ieee80211.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
index d84da2b..f35121e 100644
--- a/drivers/staging/rtl8712/ieee80211.c
+++ b/drivers/staging/rtl8712/ieee80211.c
@@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
 		/* No WPA IE - fail silently */
 		return _FAIL;
 	}
-	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
-	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
+	if ((*wpa_ie != _WPA_IE_ID_) ||
+	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
+	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
 		return _FAIL;
 	pos = wpa_ie;
 	pos += 8;
-- 
2.9.3



^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line.
  2017-02-17  5:12 [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line Varsha Rao
@ 2017-02-17  5:50 ` Julia Lawall
  2017-02-17  6:52   ` Julia Lawall
  0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2017-02-17  5:50 UTC (permalink / raw)
  To: Varsha Rao
  Cc: Larry Finger, Florian Schilhabel, Greg Kroah-Hartman, outreachy-kernel



On Fri, 17 Feb 2017, Varsha Rao wrote:

> Moved logical OR operator to previous line to fix the following
> checkpatch issue:
>
> CHECK: Logical continuations should be on the previous line.

Acked-by: drivers/staging/rtl8712/ieee80211.c

> Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> ---
>  v2:
>
>  -Edited commit message.
>  -Fixed the warning of line over 80 characters.
>
>  drivers/staging/rtl8712/ieee80211.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> index d84da2b..f35121e 100644
> --- a/drivers/staging/rtl8712/ieee80211.c
> +++ b/drivers/staging/rtl8712/ieee80211.c
> @@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
>  		/* No WPA IE - fail silently */
>  		return _FAIL;
>  	}
> -	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
> -	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
> +	if ((*wpa_ie != _WPA_IE_ID_) ||
> +	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
> +	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
>  		return _FAIL;
>  	pos = wpa_ie;
>  	pos += 8;
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170217051238.GA3213%40euri.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line.
  2017-02-17  5:50 ` [Outreachy kernel] " Julia Lawall
@ 2017-02-17  6:52   ` Julia Lawall
  0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2017-02-17  6:52 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Varsha Rao, Larry Finger, Florian Schilhabel, Greg Kroah-Hartman,
	outreachy-kernel



On Fri, 17 Feb 2017, Julia Lawall wrote:

>
>
> On Fri, 17 Feb 2017, Varsha Rao wrote:
>
> > Moved logical OR operator to previous line to fix the following
> > checkpatch issue:
> >
> > CHECK: Logical continuations should be on the previous line.
>
> Acked-by: drivers/staging/rtl8712/ieee80211.c

Sorry!

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

>
> > Signed-off-by: Varsha Rao <rvarsha016@gmail.com>
> > ---
> >  v2:
> >
> >  -Edited commit message.
> >  -Fixed the warning of line over 80 characters.
> >
> >  drivers/staging/rtl8712/ieee80211.c | 5 +++--
> >  1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8712/ieee80211.c b/drivers/staging/rtl8712/ieee80211.c
> > index d84da2b..f35121e 100644
> > --- a/drivers/staging/rtl8712/ieee80211.c
> > +++ b/drivers/staging/rtl8712/ieee80211.c
> > @@ -288,8 +288,9 @@ int r8712_parse_wpa_ie(u8 *wpa_ie, int wpa_ie_len, int *group_cipher,
> >  		/* No WPA IE - fail silently */
> >  		return _FAIL;
> >  	}
> > -	if ((*wpa_ie != _WPA_IE_ID_) || (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2))
> > -	     || (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
> > +	if ((*wpa_ie != _WPA_IE_ID_) ||
> > +	    (*(wpa_ie + 1) != (u8)(wpa_ie_len - 2)) ||
> > +	    (memcmp(wpa_ie + 2, (void *)WPA_OUI_TYPE, WPA_SELECTOR_LEN)))
> >  		return _FAIL;
> >  	pos = wpa_ie;
> >  	pos += 8;
> > --
> > 2.9.3
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170217051238.GA3213%40euri.
> > For more options, visit https://groups.google.com/d/optout.
> >
>


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-17  6:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-17  5:12 [PATCH v2] staging: rtl8712: Moved logical OR operator to previous line Varsha Rao
2017-02-17  5:50 ` [Outreachy kernel] " Julia Lawall
2017-02-17  6:52   ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.