All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message
@ 2017-02-25 18:51 ` Codrut Grosu
  0 siblings, 0 replies; 4+ messages in thread
From: Codrut Grosu @ 2017-02-25 18:51 UTC (permalink / raw)
  To: perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k
  Cc: lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
	swarren-3lzwWm7+Weoh9ZMKESR00Q,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w, Julia.Lawall-L2FTfq7BK8M,
	nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA, Codrut Grosu

This was reported by checkpatch.pl

Signed-off-by: Codrut Grosu <codrut.cristian.grosu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 sound/soc/tegra/tegra_alc5632.c | 2 +-
 sound/soc/tegra/tegra_rt5640.c  | 2 +-
 sound/soc/tegra/tegra_rt5677.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
index 0509902..1f648f9 100644
--- a/sound/soc/tegra/tegra_alc5632.c
+++ b/sound/soc/tegra/tegra_alc5632.c
@@ -1,5 +1,5 @@
 /*
-* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
+ * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
  *
  * Copyright (C) 2011 The AC100 Kernel Team <ac100-oU9gvf+ajcSyy5GWsZ7R2qxOck334EZe@public.gmane.org>
  * Copyright (C) 2012 - NVIDIA, Inc.
diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
index 93a3568..cf706d0 100644
--- a/sound/soc/tegra/tegra_rt5640.c
+++ b/sound/soc/tegra/tegra_rt5640.c
@@ -1,5 +1,5 @@
 /*
-* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
+ * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
  *
  * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
  *
diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
index ebf58d0..0ed2eca 100644
--- a/sound/soc/tegra/tegra_rt5677.c
+++ b/sound/soc/tegra/tegra_rt5677.c
@@ -1,5 +1,5 @@
 /*
-* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
+ * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
  *
  * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
  *
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message
@ 2017-02-25 18:51 ` Codrut Grosu
  0 siblings, 0 replies; 4+ messages in thread
From: Codrut Grosu @ 2017-02-25 18:51 UTC (permalink / raw)
  To: perex, tiwai
  Cc: lgirdwood, broonie, swarren, thierry.reding, gnurou,
	Julia.Lawall, nicoleotsuka, alsa-devel, linux-tegra,
	linux-kernel, Codrut Grosu

This was reported by checkpatch.pl

Signed-off-by: Codrut Grosu <codrut.cristian.grosu@gmail.com>
---
 sound/soc/tegra/tegra_alc5632.c | 2 +-
 sound/soc/tegra/tegra_rt5640.c  | 2 +-
 sound/soc/tegra/tegra_rt5677.c  | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
index 0509902..1f648f9 100644
--- a/sound/soc/tegra/tegra_alc5632.c
+++ b/sound/soc/tegra/tegra_alc5632.c
@@ -1,5 +1,5 @@
 /*
-* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
+ * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
  *
  * Copyright (C) 2011 The AC100 Kernel Team <ac100@lists.lauchpad.net>
  * Copyright (C) 2012 - NVIDIA, Inc.
diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
index 93a3568..cf706d0 100644
--- a/sound/soc/tegra/tegra_rt5640.c
+++ b/sound/soc/tegra/tegra_rt5640.c
@@ -1,5 +1,5 @@
 /*
-* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
+ * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
  *
  * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
  *
diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
index ebf58d0..0ed2eca 100644
--- a/sound/soc/tegra/tegra_rt5677.c
+++ b/sound/soc/tegra/tegra_rt5677.c
@@ -1,5 +1,5 @@
 /*
-* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
+ * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
  *
  * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
  *
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message
  2017-02-25 18:51 ` Codrut Grosu
@ 2017-02-25 18:57     ` Julia Lawall
  -1 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-02-25 18:57 UTC (permalink / raw)
  To: Codrut Grosu
  Cc: perex-/Fr2/VpizcU, tiwai-IBi9RG/b67k,
	lgirdwood-Re5JQEeQqe8AvxtiuMwx3w, broonie-DgEjT+Ai2ygdnm+yROfE0A,
	swarren-3lzwWm7+Weoh9ZMKESR00Q,
	thierry.reding-Re5JQEeQqe8AvxtiuMwx3w,
	gnurou-Re5JQEeQqe8AvxtiuMwx3w, Julia.Lawall-L2FTfq7BK8M,
	nicoleotsuka-Re5JQEeQqe8AvxtiuMwx3w,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

The subject line is not very accurate.  You don't remove the message, in
the sense of picking it up and putting it somewhere else.  You adjust the
code in some way such that the error no longer occurs.  So it would be
better to say what adjustment you have done.  Something like line up *s in
block comments.

julia



On Sat, 25 Feb 2017, Codrut Grosu wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Codrut Grosu <codrut.cristian.grosu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  sound/soc/tegra/tegra_alc5632.c | 2 +-
>  sound/soc/tegra/tegra_rt5640.c  | 2 +-
>  sound/soc/tegra/tegra_rt5677.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
> index 0509902..1f648f9 100644
> --- a/sound/soc/tegra/tegra_alc5632.c
> +++ b/sound/soc/tegra/tegra_alc5632.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
> + * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
>   *
>   * Copyright (C) 2011 The AC100 Kernel Team <ac100-oU9gvf+ajcSyy5GWsZ7R2qxOck334EZe@public.gmane.org>
>   * Copyright (C) 2012 - NVIDIA, Inc.
> diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
> index 93a3568..cf706d0 100644
> --- a/sound/soc/tegra/tegra_rt5640.c
> +++ b/sound/soc/tegra/tegra_rt5640.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
> + * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
>   *
>   * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
>   *
> diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
> index ebf58d0..0ed2eca 100644
> --- a/sound/soc/tegra/tegra_rt5677.c
> +++ b/sound/soc/tegra/tegra_rt5677.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
> + * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
>   *
>   * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
>   *
> 1.9.1
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message
@ 2017-02-25 18:57     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-02-25 18:57 UTC (permalink / raw)
  To: Codrut Grosu
  Cc: perex, tiwai, lgirdwood, broonie, swarren, thierry.reding,
	gnurou, Julia.Lawall, nicoleotsuka, alsa-devel, linux-tegra,
	linux-kernel

The subject line is not very accurate.  You don't remove the message, in
the sense of picking it up and putting it somewhere else.  You adjust the
code in some way such that the error no longer occurs.  So it would be
better to say what adjustment you have done.  Something like line up *s in
block comments.

julia



On Sat, 25 Feb 2017, Codrut Grosu wrote:

> This was reported by checkpatch.pl
>
> Signed-off-by: Codrut Grosu <codrut.cristian.grosu@gmail.com>
> ---
>  sound/soc/tegra/tegra_alc5632.c | 2 +-
>  sound/soc/tegra/tegra_rt5640.c  | 2 +-
>  sound/soc/tegra/tegra_rt5677.c  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/tegra/tegra_alc5632.c b/sound/soc/tegra/tegra_alc5632.c
> index 0509902..1f648f9 100644
> --- a/sound/soc/tegra/tegra_alc5632.c
> +++ b/sound/soc/tegra/tegra_alc5632.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
> + * tegra_alc5632.c  --  Toshiba AC100(PAZ00) machine ASoC driver
>   *
>   * Copyright (C) 2011 The AC100 Kernel Team <ac100@lists.lauchpad.net>
>   * Copyright (C) 2012 - NVIDIA, Inc.
> diff --git a/sound/soc/tegra/tegra_rt5640.c b/sound/soc/tegra/tegra_rt5640.c
> index 93a3568..cf706d0 100644
> --- a/sound/soc/tegra/tegra_rt5640.c
> +++ b/sound/soc/tegra/tegra_rt5640.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
> + * tegra_rt5640.c - Tegra machine ASoC driver for boards using RT5640 codec.
>   *
>   * Copyright (c) 2013, NVIDIA CORPORATION.  All rights reserved.
>   *
> diff --git a/sound/soc/tegra/tegra_rt5677.c b/sound/soc/tegra/tegra_rt5677.c
> index ebf58d0..0ed2eca 100644
> --- a/sound/soc/tegra/tegra_rt5677.c
> +++ b/sound/soc/tegra/tegra_rt5677.c
> @@ -1,5 +1,5 @@
>  /*
> -* tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
> + * tegra_rt5677.c - Tegra machine ASoC driver for boards using RT5677 codec.
>   *
>   * Copyright (c) 2014, The Chromium OS Authors.  All rights reserved.
>   *
> 1.9.1
>
>

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-25 18:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-25 18:51 [PATCH] ASoC: tegra: Remove unnecessary 'Block comments should align the * on each line' message Codrut Grosu
2017-02-25 18:51 ` Codrut Grosu
     [not found] ` <1488048686-5964-1-git-send-email-codrut.cristian.grosu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-02-25 18:57   ` Julia Lawall
2017-02-25 18:57     ` Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.