From: Julia Lawall <julia.lawall@lip6.fr>
To: Arushi Singhal <arushisinghal19971997@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, outreachy-kernel@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.
Date: Mon, 27 Feb 2017 16:07:27 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1702271606420.3032@hadrien> (raw)
In-Reply-To: <CA+XqjF-7SfgGkcHGhraz2R=8qV4Vgqiky+u+qSJNTMGr__JnTg@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]
On Mon, 27 Feb 2017, Arushi Singhal wrote:
>
>
> On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > Commenting Code Is a Bad Idea.
> > Comments are their to explain the code and how the code
> achieves its
> > goal and as codes in the comments does not explain what the
> code is
> > doing so there is no use of commenting them.
> > So in this patch codes in the comments are removed.
> >
> > Signed-off-by: Arushi Singhal
> <arushisinghal19971997@gmail.com>
> > ---
> > changes in v2
> > - subject lines is made short.
> >
> > drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> > 1 file changed, 4 deletions(-)
>
> This patch does not apply against my staging-testing branch :(
>
>
> why?
You should figure this out yourself. Pull Greg's tree again, and try to
apply your patch. It's deterministic, so you should have the same
information that he has.
julia
> Arushi
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF-7SfgGkcHGhraz2
> R%3D8qV4Vgqiky%2Bu%2BqSJNTMGr__JnTg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
next prev parent reply other threads:[~2017-02-27 15:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 16:08 [PATCH v2] staging: ks7010: remove code in comments Arushi Singhal
2017-02-27 14:48 ` Greg KH
2017-02-27 15:03 ` Arushi Singhal
2017-02-27 15:07 ` Julia Lawall [this message]
2017-02-27 20:29 ` [Outreachy kernel] " Tobin C. Harding
2017-02-27 20:29 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1702271606420.3032@hadrien \
--to=julia.lawall@lip6.fr \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.