[PATCH v2] staging: ks7010: remove code in comments.

[PATCH v2] staging: ks7010: remove code in comments.

[Arushi Singhal]

Commenting Code Is a Bad Idea.
Comments are their to explain the code and how the code achieves its
goal and as codes in the comments  does not explain what the code is
doing so there is no use of commenting them.
So in this patch codes in the comments are removed.

Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
 changes in v2
 - subject lines is made short.

 drivers/staging/ks7010/ks7010_sdio.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
index 2c263f98bdbb..54aa2e2f516f 100644
--- a/drivers/staging/ks7010/ks7010_sdio.c
+++ b/drivers/staging/ks7010/ks7010_sdio.c
@@ -495,10 +495,6 @@ static void ks7010_rw_function(struct work_struct *work)
 	/* wiat after WAKEUP */
 	while (time_after(priv->last_wakeup + ((30 * HZ) / 1000), jiffies)) {
 		DPRINTK(4, "wait after WAKEUP\n");
-/* 
- *   queue_delayed_work(priv->ks_wlan_hw.ks7010sdio_wq,&priv->ks_wlan_hw.rw_wq,
- *   (priv->last_wakeup + ((30*HZ)/1000) - jiffies));
- */
 		dev_info(&priv->ks_wlan_hw.sdio_card->func->dev,
 			 "wake: %lu %lu\n",
 			 priv->last_wakeup + (30 * HZ) / 1000,
-- 
2.11.0

Re: [PATCH v2] staging: ks7010: remove code in comments.

[Greg KH]

On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> Commenting Code Is a Bad Idea.
> Comments are their to explain the code and how the code achieves its
> goal and as codes in the comments  does not explain what the code is
> doing so there is no use of commenting them.
> So in this patch codes in the comments are removed.
> 
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
>  changes in v2
>  - subject lines is made short.
> 
>  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
>  1 file changed, 4 deletions(-)

This patch does not apply against my staging-testing branch :(

Re: [PATCH v2] staging: ks7010: remove code in comments.

[Arushi Singhal]

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:

> On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> > Commenting Code Is a Bad Idea.
> > Comments are their to explain the code and how the code achieves its
> > goal and as codes in the comments  does not explain what the code is
> > doing so there is no use of commenting them.
> > So in this patch codes in the comments are removed.
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> > ---
> >  changes in v2
> >  - subject lines is made short.
> >
> >  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> >  1 file changed, 4 deletions(-)
>
> This patch does not apply against my staging-testing branch :(
>

why?
Arushi

[-- Attachment #2: Type: text/html, Size: 1268 bytes --]

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

[Julia Lawall]

[-- Attachment #1: Type: text/plain, Size: 1645 bytes --]



On Mon, 27 Feb 2017, Arushi Singhal wrote:

>
>
> On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>       On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
>       > Commenting Code Is a Bad Idea.
>       > Comments are their to explain the code and how the code
>       achieves its
>       > goal and as codes in the comments  does not explain what the
>       code is
>       > doing so there is no use of commenting them.
>       > So in this patch codes in the comments are removed.
>       >
>       > Signed-off-by: Arushi Singhal
>       <arushisinghal19971997@gmail.com>
>       > ---
>       >  changes in v2
>       >  - subject lines is made short.
>       >
>       >  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
>       >  1 file changed, 4 deletions(-)
>
>       This patch does not apply against my staging-testing branch :(
>
>
> why?

You should figure this out yourself.  Pull Greg's tree again, and try to
apply your patch.  It's deterministic, so you should have the same
information that he has.

julia

> Arushi
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF-7SfgGkcHGhraz2
> R%3D8qV4Vgqiky%2Bu%2BqSJNTMGr__JnTg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

[Tobin C. Harding]

On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
> 
> 
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
> 
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >       On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> >       > Commenting Code Is a Bad Idea.
> >       > Comments are their to explain the code and how the code
> >       achieves its
> >       > goal and as codes in the comments  does not explain what the
> >       code is
> >       > doing so there is no use of commenting them.
> >       > So in this patch codes in the comments are removed.
> >       >
> >       > Signed-off-by: Arushi Singhal
> >       <arushisinghal19971997@gmail.com>
> >       > ---
> >       >  changes in v2
> >       >  - subject lines is made short.
> >       >
> >       >  drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> >       >  1 file changed, 4 deletions(-)
> >
> >       This patch does not apply against my staging-testing branch :(
> >
> >
> > why?
> 
> You should figure this out yourself.  Pull Greg's tree again, and try to
> apply your patch.  It's deterministic, so you should have the same
> information that he has.

I have only just worked this out Arushi so I thought I'd share. You
may want to read up on remote tracking branches in git and set up a
branch tracking Greg's staging-testing branch. Then create (checkout
-b) your development branches from that branch.

Good luck,
Tobin.

Re: [Outreachy kernel] Re: [PATCH v2] staging: ks7010: remove code in comments.

[Tobin C. Harding]

On Mon, Feb 27, 2017 at 04:07:27PM +0100, Julia Lawall wrote:
> 
> 
> On Mon, 27 Feb 2017, Arushi Singhal wrote:
> 
> >
> >
> > On Mon, Feb 27, 2017 at 8:18 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >       On Sun, Feb 26, 2017 at 09:38:20PM +0530, Arushi Singhal wrote:
> >       > Commenting Code Is a Bad Idea.
> >       > Comments are their to explain the code and how the code
> >       achieves its
> >       > goal and as codes in the comments� does not explain what the
> >       code is
> >       > doing so there is no use of commenting them.
> >       > So in this patch codes in the comments are removed.
> >       >
> >       > Signed-off-by: Arushi Singhal
> >       <arushisinghal19971997@gmail.com>
> >       > ---
> >       >� changes in v2
> >       >� - subject lines is made short.
> >       >
> >       >� drivers/staging/ks7010/ks7010_sdio.c | 4 ----
> >       >� 1 file changed, 4 deletions(-)
> >
> >       This patch does not apply against my staging-testing branch :(
> >
> >
> > why?
> 
> You should figure this out yourself.  Pull Greg's tree again, and try to
> apply your patch.  It's deterministic, so you should have the same
> information that he has.

I have only just worked this out Arushi so I thought I'd share. You
may want to read up on remote tracking branches in git and set up a
branch tracking Greg's staging-testing branch. Then create (checkout
-b) your development branches from that branch.

Good luck,
Tobin.