All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging:rtl8188eu Add spaces around binary operator
@ 2017-02-27 21:29 Georgiana Rodica Chelu
  2017-02-27 21:37 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Georgiana Rodica Chelu @ 2017-02-27 21:29 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Add spaces around binary operator '&' in order to
increase the readability of the code. 

Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>
---
Changes in v2:
 - rephrase the commit message to avoid passive voice

 drivers/staging/rtl8188eu/core/rtw_xmit.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
index 630fdc3..1dcb4eb 100644
--- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
+++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
@@ -1763,20 +1763,20 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_fra
 			switch (pattrib->priority) {
 			case 1:
 			case 2:
-				wmmps_ac = psta->uapsd_bk&BIT(0);
+				wmmps_ac = psta->uapsd_bk & BIT(0);
 				break;
 			case 4:
 			case 5:
-				wmmps_ac = psta->uapsd_vi&BIT(0);
+				wmmps_ac = psta->uapsd_vi & BIT(0);
 				break;
 			case 6:
 			case 7:
-				wmmps_ac = psta->uapsd_vo&BIT(0);
+				wmmps_ac = psta->uapsd_vo & BIT(0);
 				break;
 			case 0:
 			case 3:
 			default:
-				wmmps_ac = psta->uapsd_be&BIT(0);
+				wmmps_ac = psta->uapsd_be & BIT(0);
 				break;
 			}
 
@@ -1890,20 +1890,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)
 		switch (pxmitframe->attrib.priority) {
 		case 1:
 		case 2:
-			wmmps_ac = psta->uapsd_bk&BIT(1);
+			wmmps_ac = psta->uapsd_bk & BIT(1);
 			break;
 		case 4:
 		case 5:
-			wmmps_ac = psta->uapsd_vi&BIT(1);
+			wmmps_ac = psta->uapsd_vi & BIT(1);
 			break;
 		case 6:
 		case 7:
-			wmmps_ac = psta->uapsd_vo&BIT(1);
+			wmmps_ac = psta->uapsd_vo & BIT(1);
 			break;
 		case 0:
 		case 3:
 		default:
-			wmmps_ac = psta->uapsd_be&BIT(1);
+			wmmps_ac = psta->uapsd_be & BIT(1);
 			break;
 		}
 
@@ -2016,20 +2016,20 @@ void xmit_delivery_enabled_frames(struct adapter *padapter, struct sta_info *pst
 		switch (pxmitframe->attrib.priority) {
 		case 1:
 		case 2:
-			wmmps_ac = psta->uapsd_bk&BIT(1);
+			wmmps_ac = psta->uapsd_bk & BIT(1);
 			break;
 		case 4:
 		case 5:
-			wmmps_ac = psta->uapsd_vi&BIT(1);
+			wmmps_ac = psta->uapsd_vi & BIT(1);
 			break;
 		case 6:
 		case 7:
-			wmmps_ac = psta->uapsd_vo&BIT(1);
+			wmmps_ac = psta->uapsd_vo & BIT(1);
 			break;
 		case 0:
 		case 3:
 		default:
-			wmmps_ac = psta->uapsd_be&BIT(1);
+			wmmps_ac = psta->uapsd_be & BIT(1);
 			break;
 		}
 
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging:rtl8188eu Add spaces around binary operator
  2017-02-27 21:29 [PATCH v2] staging:rtl8188eu Add spaces around binary operator Georgiana Rodica Chelu
@ 2017-02-27 21:37 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2017-02-27 21:37 UTC (permalink / raw)
  To: Georgiana Rodica Chelu; +Cc: outreachy-kernel, gregkh



On Mon, 27 Feb 2017, Georgiana Rodica Chelu wrote:

> Add spaces around binary operator '&' in order to
> increase the readability of the code.
>
> Signed-off-by: Georgiana Rodica Chelu <georgiana.chelu93@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Thanks for the improved commit message.

> ---
> Changes in v2:
>  - rephrase the commit message to avoid passive voice
>
>  drivers/staging/rtl8188eu/core/rtw_xmit.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> index 630fdc3..1dcb4eb 100644
> --- a/drivers/staging/rtl8188eu/core/rtw_xmit.c
> +++ b/drivers/staging/rtl8188eu/core/rtw_xmit.c
> @@ -1763,20 +1763,20 @@ int xmitframe_enqueue_for_sleeping_sta(struct adapter *padapter, struct xmit_fra
>  			switch (pattrib->priority) {
>  			case 1:
>  			case 2:
> -				wmmps_ac = psta->uapsd_bk&BIT(0);
> +				wmmps_ac = psta->uapsd_bk & BIT(0);
>  				break;
>  			case 4:
>  			case 5:
> -				wmmps_ac = psta->uapsd_vi&BIT(0);
> +				wmmps_ac = psta->uapsd_vi & BIT(0);
>  				break;
>  			case 6:
>  			case 7:
> -				wmmps_ac = psta->uapsd_vo&BIT(0);
> +				wmmps_ac = psta->uapsd_vo & BIT(0);
>  				break;
>  			case 0:
>  			case 3:
>  			default:
> -				wmmps_ac = psta->uapsd_be&BIT(0);
> +				wmmps_ac = psta->uapsd_be & BIT(0);
>  				break;
>  			}
>
> @@ -1890,20 +1890,20 @@ void wakeup_sta_to_xmit(struct adapter *padapter, struct sta_info *psta)
>  		switch (pxmitframe->attrib.priority) {
>  		case 1:
>  		case 2:
> -			wmmps_ac = psta->uapsd_bk&BIT(1);
> +			wmmps_ac = psta->uapsd_bk & BIT(1);
>  			break;
>  		case 4:
>  		case 5:
> -			wmmps_ac = psta->uapsd_vi&BIT(1);
> +			wmmps_ac = psta->uapsd_vi & BIT(1);
>  			break;
>  		case 6:
>  		case 7:
> -			wmmps_ac = psta->uapsd_vo&BIT(1);
> +			wmmps_ac = psta->uapsd_vo & BIT(1);
>  			break;
>  		case 0:
>  		case 3:
>  		default:
> -			wmmps_ac = psta->uapsd_be&BIT(1);
> +			wmmps_ac = psta->uapsd_be & BIT(1);
>  			break;
>  		}
>
> @@ -2016,20 +2016,20 @@ void xmit_delivery_enabled_frames(struct adapter *padapter, struct sta_info *pst
>  		switch (pxmitframe->attrib.priority) {
>  		case 1:
>  		case 2:
> -			wmmps_ac = psta->uapsd_bk&BIT(1);
> +			wmmps_ac = psta->uapsd_bk & BIT(1);
>  			break;
>  		case 4:
>  		case 5:
> -			wmmps_ac = psta->uapsd_vi&BIT(1);
> +			wmmps_ac = psta->uapsd_vi & BIT(1);
>  			break;
>  		case 6:
>  		case 7:
> -			wmmps_ac = psta->uapsd_vo&BIT(1);
> +			wmmps_ac = psta->uapsd_vo & BIT(1);
>  			break;
>  		case 0:
>  		case 3:
>  		default:
> -			wmmps_ac = psta->uapsd_be&BIT(1);
> +			wmmps_ac = psta->uapsd_be & BIT(1);
>  			break;
>  		}
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170227212948.GA5171%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-02-27 21:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-27 21:29 [PATCH v2] staging:rtl8188eu Add spaces around binary operator Georgiana Rodica Chelu
2017-02-27 21:37 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.