[PATCH] Delete tab to indent

[PATCH] Delete tab to indent

[Tamara Diaconita]

Deleted a tab to fix the checkpath.pl issue:
CHECK: indent should use tabs where possible.

Deleted an extra tab to indent the code.

Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
---
 drivers/staging/speakup/i18n.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
index 1a3e348..3e5f012 100644
--- a/drivers/staging/speakup/i18n.c
+++ b/drivers/staging/speakup/i18n.c
@@ -552,7 +552,7 @@ ssize_t spk_msg_set(enum msg_index_t index, char *text, size_t length)
 			if (index >= MSG_FORMATTED_START &&
 			    index <= MSG_FORMATTED_END &&
 			    !fmt_validate(speakup_default_msgs[index],
-			                  newstr)) {
+				    newstr)) {
 				kfree(newstr);
 				return -EINVAL;
 			}
-- 
2.9.3

Re: [Outreachy kernel] [PATCH] Delete tab to indent

[Julia Lawall]

On Fri, 3 Mar 2017, Tamara Diaconita wrote:

> Deleted a tab to fix the checkpath.pl issue:
> CHECK: indent should use tabs where possible.
>
> Deleted an extra tab to indent the code.
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com>
> ---
>  drivers/staging/speakup/i18n.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c
> index 1a3e348..3e5f012 100644
> --- a/drivers/staging/speakup/i18n.c
> +++ b/drivers/staging/speakup/i18n.c
> @@ -552,7 +552,7 @@ ssize_t spk_msg_set(enum msg_index_t index, char *text, size_t length)
>  			if (index >= MSG_FORMATTED_START &&
>  			    index <= MSG_FORMATTED_END &&
>  			    !fmt_validate(speakup_default_msgs[index],
> -			                  newstr)) {
> +				    newstr)) {

Actually, checkpatch was complaining about the number of spaces in front
of newstr, and not the number of tabs.  newstr is in the right position in
the original code.  It just needs to be put into that position using tabs
as much as possible.

julia

>  				kfree(newstr);
>  				return -EINVAL;
>  			}
> --
> 2.9.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170303215557.10077-1-diaconita.tamara%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH] Delete tab to indent

[Tamara Diaconita]

[-- Attachment #1.1: Type: text/plain, Size: 1167 bytes --]

I will resend the patch, thank you!

vineri, 3 martie 2017, 23:56:01 UTC+2, Tamara Diaconita a scris:
>
> Deleted a tab to fix the checkpath.pl issue: 
> CHECK: indent should use tabs where possible. 
>
> Deleted an extra tab to indent the code. 
>
> Signed-off-by: Tamara Diaconita <diaconita.tamara@gmail.com> 
> --- 
>  drivers/staging/speakup/i18n.c | 2 +- 
>  1 file changed, 1 insertion(+), 1 deletion(-) 
>
> diff --git a/drivers/staging/speakup/i18n.c 
> b/drivers/staging/speakup/i18n.c 
> index 1a3e348..3e5f012 100644 
> --- a/drivers/staging/speakup/i18n.c 
> +++ b/drivers/staging/speakup/i18n.c 
> @@ -552,7 +552,7 @@ ssize_t spk_msg_set(enum msg_index_t index, char 
> *text, size_t length) 
>                          if (index >= MSG_FORMATTED_START && 
>                              index <= MSG_FORMATTED_END && 
>                              !fmt_validate(speakup_default_msgs[index], 
> -                                          newstr)) { 
> +                                    newstr)) { 
>                                  kfree(newstr); 
>                                  return -EINVAL; 
>                          } 
> -- 
> 2.9.3 
>
>

[-- Attachment #1.2: Type: text/html, Size: 2330 bytes --]