[PATCH v2] staging: greybus: Remove unneeded header file

[PATCH v2] staging: greybus: Remove unneeded header file

[Gargi Sharma]

module.h contains a call to moduleparam.h making the call to it
redundant and useless.

The Coccinelle semantic patch used to make this change is as follows:
@ includesmodule @
@@

@ depends on includesmodule @
@@

- #include <linux/moduleparam.h>

Signed-off-by: Gargi Sharma <gs051095@gmail.com>
---
Changes in v2:
	- Added the missing line to the script.
---
 drivers/staging/greybus/gbphy.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
index 64a1eb9..603de6f 100644
--- a/drivers/staging/greybus/gbphy.c
+++ b/drivers/staging/greybus/gbphy.c
@@ -11,7 +11,6 @@
 
 #include <linux/types.h>
 #include <linux/module.h>
-#include <linux/moduleparam.h>
 #include <linux/kernel.h>
 #include <linux/slab.h>
 #include <linux/device.h>
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v2] staging: greybus: Remove unneeded header file

[Julia Lawall]

On Wed, 8 Mar 2017, Gargi Sharma wrote:

> module.h contains a call to moduleparam.h making the call to it
> redundant and useless.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @ includesmodule @
> @@
>
> @ depends on includesmodule @
> @@
>
> - #include <linux/moduleparam.h>
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> Changes in v2:
> 	- Added the missing line to the script.

It's still not there.

julia

> ---
>  drivers/staging/greybus/gbphy.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 64a1eb9..603de6f 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -11,7 +11,6 @@
>
>  #include <linux/types.h>
>  #include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/device.h>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488984963-9642-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: greybus: Remove unneeded header file

[Julia Lawall]

On Wed, 8 Mar 2017, Gargi Sharma wrote:

> module.h contains a call to moduleparam.h making the call to it
> redundant and useless.
>
> @ includesmodule @
> @@
>
>  #include <linux/module.h>
>
> @ depends on includesmodule @
> @@
>
> - #include <linux/moduleparam.h>
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> Changes in v2:
>         - Added the missing line to the script.

Shouldn't the version number be higher?

julia

> ---
>  drivers/staging/greybus/gbphy.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 64a1eb9..603de6f 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -11,7 +11,6 @@
>
>  #include <linux/types.h>
>  #include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/device.h>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488987310-11915-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v2] staging: greybus: Remove unneeded header file

[Julia Lawall]

On Wed, 8 Mar 2017, Gargi Sharma wrote:

> module.h contains a call to moduleparam.h making the call to it
> redundant and useless.
>
> The Coccinelle semantic patch used to make this change is as follows:
> @ includesmodule @
> @@

There should be a line here.

julia

> @ depends on includesmodule @
> @@
>
> - #include <linux/moduleparam.h>
>
> Signed-off-by: Gargi Sharma <gs051095@gmail.com>
> ---
> Changes in v2:
> 	- Added the missing line to the script.
> ---
>  drivers/staging/greybus/gbphy.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c
> index 64a1eb9..603de6f 100644
> --- a/drivers/staging/greybus/gbphy.c
> +++ b/drivers/staging/greybus/gbphy.c
> @@ -11,7 +11,6 @@
>
>  #include <linux/types.h>
>  #include <linux/module.h>
> -#include <linux/moduleparam.h>
>  #include <linux/kernel.h>
>  #include <linux/slab.h>
>  #include <linux/device.h>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1488984682-9321-1-git-send-email-gs051095%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>