* [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.
@ 2017-03-23 13:45 Arushi Singhal
2017-03-23 13:49 ` [Outreachy kernel] " Julia Lawall
2017-03-23 20:45 ` Greg Kroah-Hartman
0 siblings, 2 replies; 4+ messages in thread
From: Arushi Singhal @ 2017-03-23 13:45 UTC (permalink / raw)
To: Chris Brannon, Kirk Reiser, Samuel Thibault, Greg Kroah-Hartman,
speakup, driverdevel, LKML, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2298 bytes --]
Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
changes in v2
- change the commit message.
drivers/staging/speakup/speakup_apollo.c | 2 +-
drivers/staging/speakup/speakup_decext.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/speakup/speakup_apollo.c
b/drivers/staging/speakup/speakup_apollo.c
index 9cfdbbfb9742..6ad83dc642c4 100644
--- a/drivers/staging/speakup/speakup_apollo.c
+++ b/drivers/staging/speakup/speakup_apollo.c
@@ -173,7 +173,7 @@ static void do_catch_up(struct spk_synth *synth)
if (!synth->io_ops->synth_out(synth, ch)) {
outb(UART_MCR_DTR, speakup_info.port_tts +
UART_MCR);
outb(UART_MCR_DTR | UART_MCR_RTS,
- speakup_info.port_tts + UART_MCR);
+ speakup_info.port_tts + UART_MCR);
schedule_timeout(msecs_to_jiffies(full_time_val));
continue;
}
diff --git a/drivers/staging/speakup/speakup_decext.c
b/drivers/staging/speakup/speakup_decext.c
index 929a28d618dc..c564bf8e1531 100644
--- a/drivers/staging/speakup/speakup_decext.c
+++ b/drivers/staging/speakup/speakup_decext.c
@@ -206,11 +206,11 @@ static void do_catch_up(struct spk_synth *synth)
if (!in_escape)
synth->io_ops->synth_out(synth,
PROCSPEECH);
spin_lock_irqsave(&speakup_info.spinlock,
- flags);
+ flags);
jiffy_delta_val = jiffy_delta->u.n.value;
delay_time_val = delay_time->u.n.value;
spin_unlock_irqrestore(&
speakup_info.spinlock,
- flags);
+ flags);
schedule_timeout(msecs_to_jiffies
(delay_time_val));
jiff_max = jiffies + jiffy_delta_val;
--
2.11.0
[-- Attachment #2: Type: text/html, Size: 3185 bytes --]
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.
2017-03-23 13:45 [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis Arushi Singhal
@ 2017-03-23 13:49 ` Julia Lawall
2017-03-23 20:45 ` Greg Kroah-Hartman
1 sibling, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2017-03-23 13:49 UTC (permalink / raw)
To: Arushi Singhal
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, Greg Kroah-Hartman,
speakup, driverdevel, LKML, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 3522 bytes --]
It should be staging: speakup:, not staging:speakup:
On Thu, 23 Mar 2017, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
It would really be better to say what the patch does, not just say what
error message you have fixed.
julia
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> changes in v2
> - change the commit message.
>
> drivers/staging/speakup/speakup_apollo.c | 2 +-
> drivers/staging/speakup/speakup_decext.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/speakup/speakup_apollo.c
> b/drivers/staging/speakup/speakup_apollo.c
> index 9cfdbbfb9742..6ad83dc642c4 100644
> --- a/drivers/staging/speakup/speakup_apollo.c
> +++ b/drivers/staging/speakup/speakup_apollo.c
> @@ -173,7 +173,7 @@ static void do_catch_up(struct spk_synth *synth)
> if (!synth->io_ops->synth_out(synth, ch)) {
> outb(UART_MCR_DTR, speakup_info.port_tts +
> UART_MCR);
> outb(UART_MCR_DTR | UART_MCR_RTS,
> - speakup_info.port_tts + UART_MCR);
> + speakup_info.port_tts + UART_MCR);
> schedule_timeout(msecs_to_jiffies(full_time_val));
> continue;
> }
> diff --git a/drivers/staging/speakup/speakup_decext.c
> b/drivers/staging/speakup/speakup_decext.c
> index 929a28d618dc..c564bf8e1531 100644
> --- a/drivers/staging/speakup/speakup_decext.c
> +++ b/drivers/staging/speakup/speakup_decext.c
> @@ -206,11 +206,11 @@ static void do_catch_up(struct spk_synth *synth)
> if (!in_escape)
> synth->io_ops->synth_out(synth,
> PROCSPEECH);
> spin_lock_irqsave(&speakup_info.spinlock,
> - flags);
> + flags);
> jiffy_delta_val = jiffy_delta->u.n.value;
> delay_time_val = delay_time->u.n.value;
>
> spin_unlock_irqrestore(&speakup_info.spinlock,
> - flags);
> + flags);
> schedule_timeout(msecs_to_jiffies
> (delay_time_val));
> jiff_max = jiffies + jiffy_delta_val;
> --
> 2.11.0
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/CA%2BXqjF9fNHFEUopsZH5rf
> iuha-Pv0WA%2B8oACvT_cNxwiSX-rjg%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.
2017-03-23 13:45 [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis Arushi Singhal
2017-03-23 13:49 ` [Outreachy kernel] " Julia Lawall
@ 2017-03-23 20:45 ` Greg Kroah-Hartman
2017-03-24 8:15 ` Arushi Singhal
1 sibling, 1 reply; 4+ messages in thread
From: Greg Kroah-Hartman @ 2017-03-23 20:45 UTC (permalink / raw)
To: Arushi Singhal
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, speakup,
driverdevel, LKML, outreachy-kernel
On Thu, Mar 23, 2017 at 07:15:38PM +0530, Arushi Singhal wrote:
> Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
<snip>
I can't take patches sent in html format :(
please fix your email client.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis.
2017-03-23 20:45 ` Greg Kroah-Hartman
@ 2017-03-24 8:15 ` Arushi Singhal
0 siblings, 0 replies; 4+ messages in thread
From: Arushi Singhal @ 2017-03-24 8:15 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Chris Brannon, Kirk Reiser, Samuel Thibault, speakup,
driverdevel, LKML, outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 474 bytes --]
On Fri, Mar 24, 2017 at 2:15 AM, Greg Kroah-Hartman <
gregkh@linuxfoundation.org> wrote:
> On Thu, Mar 23, 2017 at 07:15:38PM +0530, Arushi Singhal wrote:
> > Fix checkpatch issues: "CHECK: Alignment should match open parenthesis".
> >
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
>
> <snip>
>
> I can't take patches sent in html format :(
>
> please fix your email client.
>
Hi Greg
I will forward it in required format.
>
> thanks,
>
> greg k-h
>
[-- Attachment #2: Type: text/html, Size: 1077 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-03-24 8:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-23 13:45 [RESEND PATCH v2] staging:speakup: Fix alignment with parenthesis Arushi Singhal
2017-03-23 13:49 ` [Outreachy kernel] " Julia Lawall
2017-03-23 20:45 ` Greg Kroah-Hartman
2017-03-24 8:15 ` Arushi Singhal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.