* Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
@ 2017-03-30 21:39 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2017-03-30 21:39 UTC (permalink / raw)
To: Christopher Bostic
Cc: joel, linux-kernel, andrew, alistair, benh, Edward A . James,
Jeremy Kerr, robh+dt, mark.rutland, linux, rostedt, mingo,
gregkh, devicetree, linux-arm-kernel, kbuild-all
Is master on line 514 allocated with kmalloc, or the devm call on line
522?
julia
---------- Forwarded message ----------
Date: Fri, 31 Mar 2017 00:15:09 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
Hi Chris,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc4 next-20170330]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
vim +514 drivers/fsi/fsi-master-gpio.c
f4bd3b6a Chris Bostic 2017-03-29 498 {
f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
f4bd3b6a Chris Bostic 2017-03-29 500
f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
f4bd3b6a Chris Bostic 2017-03-29 505
f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
f4bd3b6a Chris Bostic 2017-03-29 507 }
f4bd3b6a Chris Bostic 2017-03-29 508
f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
f4bd3b6a Chris Bostic 2017-03-29 510 {
f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
f4bd3b6a Chris Bostic 2017-03-29 513
f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
f4bd3b6a Chris Bostic 2017-03-29 515 }
f4bd3b6a Chris Bostic 2017-03-29 516
f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
f4bd3b6a Chris Bostic 2017-03-29 518 {
f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
f4bd3b6a Chris Bostic 2017-03-29 521
f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
@ 2017-03-30 21:39 ` Julia Lawall
0 siblings, 0 replies; 5+ messages in thread
From: Julia Lawall @ 2017-03-30 21:39 UTC (permalink / raw)
To: Christopher Bostic
Cc: joel-U3u1mxZcP9KHXe+LvDLADg, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
andrew-zrmu5oMJ5Fs, alistair-Y4h6yKqj69EXC2x5gXVKYQ,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, Edward A . James,
Jeremy Kerr, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
rostedt-nx8X9YLhiw1AfugRpC6u6w, mingo-H+wXaHxf7aLQT0dZR+AlfA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
kbuild-all-JC7UmRfGjtg
Is master on line 514 allocated with kmalloc, or the devm call on line
522?
julia
---------- Forwarded message ----------
Date: Fri, 31 Mar 2017 00:15:09 +0800
From: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: kbuild-JC7UmRfGjtg@public.gmane.org
Cc: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
Hi Chris,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.11-rc4 next-20170330]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
vim +514 drivers/fsi/fsi-master-gpio.c
f4bd3b6a Chris Bostic 2017-03-29 498 {
f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
f4bd3b6a Chris Bostic 2017-03-29 500
f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
f4bd3b6a Chris Bostic 2017-03-29 505
f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
f4bd3b6a Chris Bostic 2017-03-29 507 }
f4bd3b6a Chris Bostic 2017-03-29 508
f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
f4bd3b6a Chris Bostic 2017-03-29 510 {
f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
f4bd3b6a Chris Bostic 2017-03-29 513
f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
f4bd3b6a Chris Bostic 2017-03-29 515 }
f4bd3b6a Chris Bostic 2017-03-29 516
f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
f4bd3b6a Chris Bostic 2017-03-29 518 {
f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
f4bd3b6a Chris Bostic 2017-03-29 521
f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
2017-03-30 21:39 ` Julia Lawall
(?)
@ 2017-04-04 19:10 ` Christopher Bostic
-1 siblings, 0 replies; 5+ messages in thread
From: Christopher Bostic @ 2017-04-04 19:10 UTC (permalink / raw)
To: Julia Lawall
Cc: joel, linux-kernel, andrew, alistair, benh, Edward A . James,
Jeremy Kerr, robh+dt, mark.rutland, linux, rostedt, mingo,
gregkh, devicetree, linux-arm-kernel, kbuild-all
On 3/30/17 4:39 PM, Julia Lawall wrote:
> Is master on line 514 allocated with kmalloc, or the devm call on line
> 522?
Hi Julia,
Its allocated with the devm call on line 522. The kfree on line 514
wouldn't be necessary in that case - will remove.
Thanks for pointing that out.
Chris
> julia
>
> ---------- Forwarded message ----------
> Date: Fri, 31 Mar 2017 00:15:09 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild@01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
>
> Hi Chris,
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.11-rc4 next-20170330]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
>>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
> vim +514 drivers/fsi/fsi-master-gpio.c
>
> f4bd3b6a Chris Bostic 2017-03-29 498 {
> f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
> f4bd3b6a Chris Bostic 2017-03-29 500
> f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
> f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
> f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
> f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
> f4bd3b6a Chris Bostic 2017-03-29 505
> f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
> f4bd3b6a Chris Bostic 2017-03-29 507 }
> f4bd3b6a Chris Bostic 2017-03-29 508
> f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
> f4bd3b6a Chris Bostic 2017-03-29 510 {
> f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
> f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
> f4bd3b6a Chris Bostic 2017-03-29 513
> f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
> f4bd3b6a Chris Bostic 2017-03-29 515 }
> f4bd3b6a Chris Bostic 2017-03-29 516
> f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
> f4bd3b6a Chris Bostic 2017-03-29 518 {
> f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
> f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
> f4bd3b6a Chris Bostic 2017-03-29 521
> f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
@ 2017-04-04 19:10 ` Christopher Bostic
0 siblings, 0 replies; 5+ messages in thread
From: Christopher Bostic @ 2017-04-04 19:10 UTC (permalink / raw)
To: Julia Lawall
Cc: joel-U3u1mxZcP9KHXe+LvDLADg, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
andrew-zrmu5oMJ5Fs, alistair-Y4h6yKqj69EXC2x5gXVKYQ,
benh-XVmvHMARGAS8U2dJNN8I7kB+6BGkLq7r, Edward A . James,
Jeremy Kerr, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
rostedt-nx8X9YLhiw1AfugRpC6u6w, mingo-H+wXaHxf7aLQT0dZR+AlfA,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
kbuild-all-JC7UmRfGjtg
On 3/30/17 4:39 PM, Julia Lawall wrote:
> Is master on line 514 allocated with kmalloc, or the devm call on line
> 522?
Hi Julia,
Its allocated with the devm call on line 522. The kfree on line 514
wouldn't be necessary in that case - will remove.
Thanks for pointing that out.
Chris
> julia
>
> ---------- Forwarded message ----------
> Date: Fri, 31 Mar 2017 00:15:09 +0800
> From: kbuild test robot <fengguang.wu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> To: kbuild-JC7UmRfGjtg@public.gmane.org
> Cc: Julia Lawall <julia.lawall-L2FTfq7BK8M@public.gmane.org>
> Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
>
> Hi Chris,
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.11-rc4 next-20170330]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
>>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
> vim +514 drivers/fsi/fsi-master-gpio.c
>
> f4bd3b6a Chris Bostic 2017-03-29 498 {
> f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
> f4bd3b6a Chris Bostic 2017-03-29 500
> f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
> f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
> f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
> f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
> f4bd3b6a Chris Bostic 2017-03-29 505
> f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
> f4bd3b6a Chris Bostic 2017-03-29 507 }
> f4bd3b6a Chris Bostic 2017-03-29 508
> f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
> f4bd3b6a Chris Bostic 2017-03-29 510 {
> f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
> f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
> f4bd3b6a Chris Bostic 2017-03-29 513
> f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
> f4bd3b6a Chris Bostic 2017-03-29 515 }
> f4bd3b6a Chris Bostic 2017-03-29 516
> f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
> f4bd3b6a Chris Bostic 2017-03-29 518 {
> f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
> f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
> f4bd3b6a Chris Bostic 2017-03-29 521
> f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd)
@ 2017-04-04 19:10 ` Christopher Bostic
0 siblings, 0 replies; 5+ messages in thread
From: Christopher Bostic @ 2017-04-04 19:10 UTC (permalink / raw)
To: linux-arm-kernel
On 3/30/17 4:39 PM, Julia Lawall wrote:
> Is master on line 514 allocated with kmalloc, or the devm call on line
> 522?
Hi Julia,
Its allocated with the devm call on line 522. The kfree on line 514
wouldn't be necessary in that case - will remove.
Thanks for pointing that out.
Chris
> julia
>
> ---------- Forwarded message ----------
> Date: Fri, 31 Mar 2017 00:15:09 +0800
> From: kbuild test robot <fengguang.wu@intel.com>
> To: kbuild at 01.org
> Cc: Julia Lawall <julia.lawall@lip6.fr>
> Subject: Re: [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master
>
> Hi Chris,
>
> [auto build test WARNING on linus/master]
> [also build test WARNING on v4.11-rc4 next-20170330]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
>
> url: https://github.com/0day-ci/linux/commits/Christopher-Bostic/FSI-device-driver-implementation/20170330-184914
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
>>> drivers/fsi/fsi-master-gpio.c:514:1-6: WARNING: invalid free of devm_ allocated data
> git remote add linux-review https://github.com/0day-ci/linux
> git remote update linux-review
> git checkout f4bd3b6a41c7a59e9ce2e65947a4d3dfc2ee4a29
> vim +514 drivers/fsi/fsi-master-gpio.c
>
> f4bd3b6a Chris Bostic 2017-03-29 498 {
> f4bd3b6a Chris Bostic 2017-03-29 499 struct fsi_master_gpio *master = to_fsi_master_gpio(_master);
> f4bd3b6a Chris Bostic 2017-03-29 500
> f4bd3b6a Chris Bostic 2017-03-29 501 if (link != 0)
> f4bd3b6a Chris Bostic 2017-03-29 502 return -ENODEV;
> f4bd3b6a Chris Bostic 2017-03-29 503 if (master->gpio_enable)
> f4bd3b6a Chris Bostic 2017-03-29 504 gpiod_set_value(master->gpio_enable, 1);
> f4bd3b6a Chris Bostic 2017-03-29 505
> f4bd3b6a Chris Bostic 2017-03-29 506 return 0;
> f4bd3b6a Chris Bostic 2017-03-29 507 }
> f4bd3b6a Chris Bostic 2017-03-29 508
> f4bd3b6a Chris Bostic 2017-03-29 509 static void fsi_master_gpio_release(struct device *dev)
> f4bd3b6a Chris Bostic 2017-03-29 510 {
> f4bd3b6a Chris Bostic 2017-03-29 511 struct fsi_master_gpio *master = to_fsi_master_gpio(
> f4bd3b6a Chris Bostic 2017-03-29 512 dev_to_fsi_master(dev));
> f4bd3b6a Chris Bostic 2017-03-29 513
> f4bd3b6a Chris Bostic 2017-03-29 @514 kfree(master);
> f4bd3b6a Chris Bostic 2017-03-29 515 }
> f4bd3b6a Chris Bostic 2017-03-29 516
> f4bd3b6a Chris Bostic 2017-03-29 517 static int fsi_master_gpio_probe(struct platform_device *pdev)
> f4bd3b6a Chris Bostic 2017-03-29 518 {
> f4bd3b6a Chris Bostic 2017-03-29 519 struct fsi_master_gpio *master;
> f4bd3b6a Chris Bostic 2017-03-29 520 struct gpio_desc *gpio;
> f4bd3b6a Chris Bostic 2017-03-29 521
> f4bd3b6a Chris Bostic 2017-03-29 522 master = devm_kzalloc(&pdev->dev, sizeof(*master), GFP_KERNEL);
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-04 19:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-30 21:39 [PATCH v4 19/23] drivers/fsi: Add GPIO based FSI master (fwd) Julia Lawall
2017-03-30 21:39 ` Julia Lawall
2017-04-04 19:10 ` Christopher Bostic
2017-04-04 19:10 ` Christopher Bostic
2017-04-04 19:10 ` Christopher Bostic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.