All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Lameter <cl@linux.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
	Michal Hocko <mhocko@kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	David Rientjes <rientjes@google.com>,
	Hugh Dickins <hughd@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-api@vger.kernel.org
Subject: Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update
Date: Sun, 30 Apr 2017 16:33:10 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.1704301628460.21533@east.gentwo.org> (raw)
In-Reply-To: <fda99ddc-94f5-456e-6560-d4991da452a6@suse.cz>

On Wed, 26 Apr 2017, Vlastimil Babka wrote:

> > Such an application typically already has such logic and executes a
> > binding after discovering its numa node configuration on startup. It would
> > have to be modified to redo that action when it gets some sort of a signal
> > from the script telling it that the node config would be changed.
> >
> > Having this logic in the application instead of the kernel avoids all the
> > kernel messes that we keep on trying to deal with and IMHO is much
> > cleaner.
>
> That would be much simpler for us indeed. But we still IMHO can't
> abruptly start denying page fault allocations for existing applications
> that don't have the necessary awareness.

We certainly can do that. The failure of the page faults are due to the
admin trying to move an application that is not aware of this and is using
mempols. That could be an error. Trying to move an application that
contains both absolute and relative node numbers is definitely something
that is potentiall so screwed up that the kernel should not muck around
with such an app.

Also user space can determine if the application is using memory policies
and can then take appropriate measures (message to the sysadmin to eval
tge situation f.e.) or mess aroud with the processes memory policies on
its own.

So this is certainly a way out of this mess.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Lameter <cl@linux.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	cgroups@vger.kernel.org, Li Zefan <lizefan@huawei.com>,
	Michal Hocko <mhocko@kernel.org>,
	Mel Gorman <mgorman@techsingularity.net>,
	David Rientjes <rientjes@google.com>,
	Hugh Dickins <hughd@google.com>,
	Andrea Arcangeli <aarcange@redhat.com>,
	Anshuman Khandual <khandual@linux.vnet.ibm.com>,
	"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
	linux-api@vger.kernel.org
Subject: Re: [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update
Date: Sun, 30 Apr 2017 16:33:10 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.2.20.1704301628460.21533@east.gentwo.org> (raw)
In-Reply-To: <fda99ddc-94f5-456e-6560-d4991da452a6@suse.cz>

On Wed, 26 Apr 2017, Vlastimil Babka wrote:

> > Such an application typically already has such logic and executes a
> > binding after discovering its numa node configuration on startup. It would
> > have to be modified to redo that action when it gets some sort of a signal
> > from the script telling it that the node config would be changed.
> >
> > Having this logic in the application instead of the kernel avoids all the
> > kernel messes that we keep on trying to deal with and IMHO is much
> > cleaner.
>
> That would be much simpler for us indeed. But we still IMHO can't
> abruptly start denying page fault allocations for existing applications
> that don't have the necessary awareness.

We certainly can do that. The failure of the page faults are due to the
admin trying to move an application that is not aware of this and is using
mempols. That could be an error. Trying to move an application that
contains both absolute and relative node numbers is definitely something
that is potentiall so screwed up that the kernel should not muck around
with such an app.

Also user space can determine if the application is using memory policies
and can then take appropriate measures (message to the sysadmin to eval
tge situation f.e.) or mess aroud with the processes memory policies on
its own.

So this is certainly a way out of this mess.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2017-04-30 21:33 UTC|newest]

Thread overview: 91+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 14:06 [RFC 0/6] cpuset/mempolicies related fixes and cleanups Vlastimil Babka
2017-04-11 14:06 ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 1/6] mm, page_alloc: fix more premature OOM due to race with cpuset update Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka
2017-04-11 17:24   ` Christoph Lameter
2017-04-11 17:24     ` Christoph Lameter
2017-04-11 19:00     ` Vlastimil Babka
2017-04-11 19:00       ` Vlastimil Babka
2017-04-11 19:00       ` Vlastimil Babka
2017-04-12 21:25       ` Christoph Lameter
2017-04-12 21:25         ` Christoph Lameter
2017-04-13  6:24         ` Vlastimil Babka
2017-04-13  6:24           ` Vlastimil Babka
2017-04-13  6:24           ` Vlastimil Babka
2017-04-14 20:37           ` Christoph Lameter
2017-04-14 20:37             ` Christoph Lameter
2017-04-26  8:07             ` Vlastimil Babka
2017-04-26  8:07               ` Vlastimil Babka
2017-04-30 21:33               ` Christoph Lameter [this message]
2017-04-30 21:33                 ` Christoph Lameter
2017-05-17  9:20                 ` Michal Hocko
2017-05-17  9:20                   ` Michal Hocko
2017-05-17  9:20                   ` Michal Hocko
2017-05-17 13:56                   ` Christoph Lameter
2017-05-17 13:56                     ` Christoph Lameter
2017-05-17 13:56                     ` Christoph Lameter
2017-05-17 14:05                     ` Michal Hocko
2017-05-17 14:05                       ` Michal Hocko
2017-05-17 14:05                       ` Michal Hocko
2017-05-17 14:48                       ` Christoph Lameter
2017-05-17 14:48                         ` Christoph Lameter
2017-05-17 14:56                         ` Michal Hocko
2017-05-17 14:56                           ` Michal Hocko
2017-05-17 14:56                           ` Michal Hocko
2017-05-17 15:25                           ` Christoph Lameter
2017-05-17 15:25                             ` Christoph Lameter
2017-05-18  9:08                             ` Michal Hocko
2017-05-18  9:08                               ` Michal Hocko
2017-05-18  9:08                               ` Michal Hocko
2017-05-18 16:57                               ` Christoph Lameter
2017-05-18 16:57                                 ` Christoph Lameter
2017-05-18 16:57                                 ` Christoph Lameter
2017-05-18 17:24                                 ` Michal Hocko
2017-05-18 17:24                                   ` Michal Hocko
2017-05-18 17:24                                   ` Michal Hocko
2017-05-18 19:07                                   ` Christoph Lameter
2017-05-18 19:07                                     ` Christoph Lameter
2017-05-18 19:07                                     ` Christoph Lameter
2017-05-19  7:37                                     ` Michal Hocko
2017-05-19  7:37                                       ` Michal Hocko
2017-05-17 15:27                           ` Christoph Lameter
2017-05-17 15:27                             ` Christoph Lameter
2017-05-18 10:03                         ` Vlastimil Babka
2017-05-18 10:03                           ` Vlastimil Babka
2017-05-18 17:07                           ` Christoph Lameter
2017-05-18 17:07                             ` Christoph Lameter
2017-05-19 11:27                             ` Vlastimil Babka
2017-05-19 11:27                               ` Vlastimil Babka
2017-04-13  5:42   ` Anshuman Khandual
2017-04-13  5:42     ` Anshuman Khandual
2017-04-13  6:06     ` Vlastimil Babka
2017-04-13  6:06       ` Vlastimil Babka
2017-04-13  6:07       ` Vlastimil Babka
2017-04-13  6:07         ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 2/6] mm, mempolicy: stop adjusting current->il_next in mpol_rebind_nodemask() Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka
2017-04-11 17:32   ` Christoph Lameter
2017-04-11 17:32     ` Christoph Lameter
2017-04-11 19:03     ` Vlastimil Babka
2017-04-11 19:03       ` Vlastimil Babka
2017-04-11 19:03       ` Vlastimil Babka
2017-04-12  8:49       ` Vlastimil Babka
2017-04-12  8:49         ` Vlastimil Babka
2017-04-12 21:16         ` Christoph Lameter
2017-04-12 21:16           ` Christoph Lameter
2017-04-12 21:16           ` Christoph Lameter
2017-04-12 21:18           ` Vlastimil Babka
2017-04-12 21:18             ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 3/6] mm, page_alloc: pass preferred nid instead of zonelist to allocator Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 4/6] mm, mempolicy: simplify rebinding mempolicies when updating cpusets Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 5/6] mm, cpuset: always use seqlock when changing task's nodemask Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka
2017-04-12  8:10   ` Hillf Danton
2017-04-12  8:10     ` Hillf Danton
2017-04-12  8:18     ` Vlastimil Babka
2017-04-12  8:18       ` Vlastimil Babka
2017-04-12  8:18       ` Vlastimil Babka
2017-04-11 14:06 ` [RFC 6/6] mm, mempolicy: don't check cpuset seqlock where it doesn't matter Vlastimil Babka
2017-04-11 14:06   ` Vlastimil Babka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1704301628460.21533@east.gentwo.org \
    --to=cl@linux.com \
    --cc=aarcange@redhat.com \
    --cc=cgroups@vger.kernel.org \
    --cc=hughd@google.com \
    --cc=khandual@linux.vnet.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-api@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan@huawei.com \
    --cc=mgorman@techsingularity.net \
    --cc=mhocko@kernel.org \
    --cc=rientjes@google.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.