* [PATCH] staging: media: atomisp: pci: Move constants to right side of comparisons
@ 2017-09-16 19:03 Georgiana Chelu
2017-09-16 19:17 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Georgiana Chelu @ 2017-09-16 19:03 UTC (permalink / raw)
To: outreachy-kernel; +Cc: gregkh, mchehab
Place the constant on the right side of the comparison
to increase the readability of the code.
Warning found by "checkpatch.pl".
Signed-off-by: Georgiana Chelu <georgiana.chelu93@example.com>
---
.../media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
index 606376fdf0ba..81c0e057a8b8 100644
--- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
+++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
@@ -88,7 +88,7 @@ int ia_css_queue_enqueue(
uint32_t item)
{
int error = 0;
- if (NULL == qhandle)
+ if (qhandle == NULL)
return EINVAL;
/* 1. Load the required queue object */
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: media: atomisp: pci: Move constants to right side of comparisons
2017-09-16 19:03 [PATCH] staging: media: atomisp: pci: Move constants to right side of comparisons Georgiana Chelu
@ 2017-09-16 19:17 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2017-09-16 19:17 UTC (permalink / raw)
To: Georgiana Chelu; +Cc: outreachy-kernel, gregkh, mchehab
On Sat, 16 Sep 2017, Georgiana Chelu wrote:
> Place the constant on the right side of the comparison
> to increase the readability of the code.
>
> Warning found by "checkpatch.pl".
>
> Signed-off-by: Georgiana Chelu <georgiana.chelu93@example.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> .../media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
> index 606376fdf0ba..81c0e057a8b8 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp2/css2400/runtime/queue/src/queue.c
> @@ -88,7 +88,7 @@ int ia_css_queue_enqueue(
> uint32_t item)
> {
> int error = 0;
> - if (NULL == qhandle)
> + if (qhandle == NULL)
> return EINVAL;
>
> /* 1. Load the required queue object */
> --
> 2.11.0
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170916190334.awmvwhunsgz4iozl%40fireworks.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-16 19:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-16 19:03 [PATCH] staging: media: atomisp: pci: Move constants to right side of comparisons Georgiana Chelu
2017-09-16 19:17 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.