All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>,
	rkrcmar@redhat.com, kvm@vger.kernel.org, john.stultz@linaro.org,
	mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
	x86@kernel.org, rkagan@virtuozzo.com, den@virtuozzo.com
Subject: Re: [PATCH v5 1/6] timekeeper: introduce extended clocksource reading callback
Date: Wed, 27 Sep 2017 11:18:37 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1709271103420.4773@nanos> (raw)
In-Reply-To: <7b886c9f-70a7-951b-ff6f-f77f263754e7@redhat.com>

On Tue, 26 Sep 2017, Paolo Bonzini wrote:
> However, if get_device_system_crosststamp ran with kvmclock or Hyper-V
> clocksource, the two values stored by read_with_stamp would be
> different, basically a (TSC, nanoseconds) pair.

And that's exactly the problem. The cross time stamp infrastructure keeps
the system clocksource (e.g. TSC) and the reference clock (e.g. ART)
separate. There is enforcement that the two are coupled which I pointed out
in the other mail, but conceptually they are different things and we are
not going to change that and add voodoo callbacks which return different
timestamps from different sources into the clocksource.

So if you want to map kvmclock to the existing infrastructure then:

   device clock:  	       maps to the hypervisor clock
   system reference clock:     maps to REF_TSC
   system timekeeper clock:    maps to TSC

Even if REF_TSC and TSC are the same physically conceptually they are
different.

To make use of the existing infrastructure you have to provide means to
capture HV clock and reference clock atomically. Thats probably something
he hypervisor provides as a value pair HVCLOCK_NSEC, REF_TSC_VAL.

And then you can correlate system time to HVCLOCK_NSEC via REF_TSC_VAL
because that has a fixed ratio / offset to the system TSC.

Thanks,

	tglx

  parent reply	other threads:[~2017-09-27  9:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-30 15:23 [PATCH v5 0/6] KVM: x86: get rid of pvclock_gtod_copy Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 1/6] timekeeper: introduce extended clocksource reading callback Denis Plotnikov
2017-09-25 22:00   ` Thomas Gleixner
2017-09-26 16:51     ` Paolo Bonzini
2017-09-27  8:52       ` Thomas Gleixner
2017-09-27 10:43         ` Paolo Bonzini
2017-09-27 11:53           ` Thomas Gleixner
2017-09-27 12:14             ` Paolo Bonzini
2017-09-27 13:45               ` Thomas Gleixner
2017-09-27  9:18       ` Thomas Gleixner [this message]
2017-08-30 15:23 ` [PATCH v5 2/6] timekeeper: introduce boot field in system_time_snapshot Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 3/6] timekeeper: use the extended reading function on snapshot acquiring Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 4/6] tsc: implement the extended tsc reading function Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 5/6] KVM: x86: switch to masterclock update using timekeeper functionality Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 6/6] KVM: x86: remove not used pvclock_gtod_copy Denis Plotnikov
2017-09-11  9:24 ` [PATCH v5 0/6] KVM: x86: get rid of pvclock_gtod_copy Denis Plotnikov
2017-09-18  7:35   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1709271103420.4773@nanos \
    --to=tglx@linutronix.de \
    --cc=den@virtuozzo.com \
    --cc=dplotnikov@virtuozzo.com \
    --cc=hpa@zytor.com \
    --cc=john.stultz@linaro.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=rkagan@virtuozzo.com \
    --cc=rkrcmar@redhat.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.