From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Denis Plotnikov <dplotnikov@virtuozzo.com>,
rkrcmar@redhat.com, kvm@vger.kernel.org, john.stultz@linaro.org,
mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
x86@kernel.org, rkagan@virtuozzo.com, den@virtuozzo.com
Subject: Re: [PATCH v5 1/6] timekeeper: introduce extended clocksource reading callback
Date: Wed, 27 Sep 2017 15:45:19 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1709271531480.2027@nanos> (raw)
In-Reply-To: <52d6cc44-b065-93d8-a284-9e372033ba9c@redhat.com>
On Wed, 27 Sep 2017, Paolo Bonzini wrote:
> On 27/09/2017 13:53, Thomas Gleixner wrote:
> >> I think the hook should be specific to x86. For example it could be an
> >> array of function pointers, indexed by vclock_mode, with the same
> >> semantics as read_with_stamp.
> > I don't think you need that.
> >
> > The get_time_fn() which is handed in to get_device_system_crossstamp() can
> > convey that information:
> >
> > /*
> > * Try to synchronously capture device time and a system
> > * counter value calling back into the device driver
> > */
> > ret = get_time_fn(&xtstamp->device, &system_counterval, ctx);
> > if (ret)
> > return ret;
> >
> > So in your case get_time_fn() would be kvmclock or hyperv clock specific
> > and the actual hypercall implementation can return a failure code if the
> > requirements are not met:
> >
> > 1) host clock source is TSC
> > 2) capturing of host time and TSC is atomic
>
> So you are suggesting reusing the cross-timestamp hypercall to implement
> nested pvclock. There are advantages and disadvantages to that.
>
> With read_with_stamp-like callbacks:
>
> + running on old KVM or on Hyper-V is supported
> - pvclock_gtod_copy does not go away
>
> With hypercall-based callbacks on the contrary:
>
> + KVM can use ktime_get_snapshot for the bare metal case
> - only very new KVM is supported
I don't think that it's an either or decision.
get_device_system_crossstamp(get_time_fn, ......)
So you can have specific get_time_fn() implementations for your situation:
old_kvm_fn()
retrieve data from pvclock_gtod copy
new_kvm_fn()
use hypercall
hyperv_fn()
do what must be done
All implementations need a way to tell you:
1) Host time
2) Host TSC timestamp which corresponds to #1
3) Validity
For old_kvm_fn() pvclock_gtod_data.clock.vclock_mode == VCLOCK_TSC
For new_kvm_fn() hypercall result
For hyperv_fn() whatever it takes
Thanks,
tglx
next prev parent reply other threads:[~2017-09-27 13:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 15:23 [PATCH v5 0/6] KVM: x86: get rid of pvclock_gtod_copy Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 1/6] timekeeper: introduce extended clocksource reading callback Denis Plotnikov
2017-09-25 22:00 ` Thomas Gleixner
2017-09-26 16:51 ` Paolo Bonzini
2017-09-27 8:52 ` Thomas Gleixner
2017-09-27 10:43 ` Paolo Bonzini
2017-09-27 11:53 ` Thomas Gleixner
2017-09-27 12:14 ` Paolo Bonzini
2017-09-27 13:45 ` Thomas Gleixner [this message]
2017-09-27 9:18 ` Thomas Gleixner
2017-08-30 15:23 ` [PATCH v5 2/6] timekeeper: introduce boot field in system_time_snapshot Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 3/6] timekeeper: use the extended reading function on snapshot acquiring Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 4/6] tsc: implement the extended tsc reading function Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 5/6] KVM: x86: switch to masterclock update using timekeeper functionality Denis Plotnikov
2017-08-30 15:23 ` [PATCH v5 6/6] KVM: x86: remove not used pvclock_gtod_copy Denis Plotnikov
2017-09-11 9:24 ` [PATCH v5 0/6] KVM: x86: get rid of pvclock_gtod_copy Denis Plotnikov
2017-09-18 7:35 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1709271531480.2027@nanos \
--to=tglx@linutronix.de \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=hpa@zytor.com \
--cc=john.stultz@linaro.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.