* [PATCH] staging: vc04_services: Remove duplicate extern variable
@ 2017-09-28 9:39 Mihaela Muraru
2017-09-28 10:35 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Mihaela Muraru @ 2017-09-28 9:39 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Stefan Wahren, Greg Kroah-Hartman
This patch removes the extern vchiq_arm_log_level variable from
vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.
Issue found by checpatch.pl
Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
---
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
index 0159ca4..12b0e0d 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
@@ -84,7 +84,6 @@ static char *g_free_fragments;
static struct semaphore g_free_fragments_sema;
static struct device *g_dev;
-extern int vchiq_arm_log_level;
static DEFINE_SEMAPHORE(g_free_fragments_mutex);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: vc04_services: Remove duplicate extern variable
2017-09-28 9:39 [PATCH] staging: vc04_services: Remove duplicate extern variable Mihaela Muraru
@ 2017-09-28 10:35 ` Julia Lawall
2017-09-28 11:18 ` Mihaela Muraru
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2017-09-28 10:35 UTC (permalink / raw)
To: Mihaela Muraru; +Cc: outreachy-kernel, Stefan Wahren, Greg Kroah-Hartman
On Thu, 28 Sep 2017, Mihaela Muraru wrote:
> This patch removes the extern vchiq_arm_log_level variable from
> vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.
>
> Issue found by checpatch.pl
checpatch.pl -> checkpatch.pl
>
> Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> index 0159ca4..12b0e0d 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> @@ -84,7 +84,6 @@ static char *g_free_fragments;
> static struct semaphore g_free_fragments_sema;
> static struct device *g_dev;
>
> -extern int vchiq_arm_log_level;
>
You're going to end up with two blank lines here.
julia
> static DEFINE_SEMAPHORE(g_free_fragments_mutex);
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: vc04_services: Remove duplicate extern variable
2017-09-28 10:35 ` [Outreachy kernel] " Julia Lawall
@ 2017-09-28 11:18 ` Mihaela Muraru
0 siblings, 0 replies; 3+ messages in thread
From: Mihaela Muraru @ 2017-09-28 11:18 UTC (permalink / raw)
To: outreachy-kernel; +Cc: Stefan Wahren, Greg Kroah-Hartman
On Thu, Sep 28, 2017 at 12:35:40PM +0200, Julia Lawall wrote:
>
>
> On Thu, 28 Sep 2017, Mihaela Muraru wrote:
>
> > This patch removes the extern vchiq_arm_log_level variable from
> > vchiq_2835_arm.c.The variable is also declared in vchiq_arm.h header.
> >
> > Issue found by checpatch.pl
>
> checpatch.pl -> checkpatch.pl
>
> >
> > Signed-off-by: Mihaela Muraru <mihaela.muraru21@gmail.com>
> > ---
> > drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > index 0159ca4..12b0e0d 100644
> > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c
> > @@ -84,7 +84,6 @@ static char *g_free_fragments;
> > static struct semaphore g_free_fragments_sema;
> > static struct device *g_dev;
> >
> > -extern int vchiq_arm_log_level;
> >
>
> You're going to end up with two blank lines here.
>
> julia
Thank you,
I will send patch v2 with these changes
Mihaela
> > static DEFINE_SEMAPHORE(g_free_fragments_mutex);
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20170928093917.GA5023%40ubuntu.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-09-28 11:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-28 9:39 [PATCH] staging: vc04_services: Remove duplicate extern variable Mihaela Muraru
2017-09-28 10:35 ` [Outreachy kernel] " Julia Lawall
2017-09-28 11:18 ` Mihaela Muraru
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.