* [PATCH]:staging:most:aim-cdev:Reducing number of blank lines, to follow the coding style
@ 2017-10-08 18:42 mamta shukla
2017-10-08 18:57 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: mamta shukla @ 2017-10-08 18:42 UTC (permalink / raw)
To: outreachy-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1190 bytes --]
Reducing number of blank lines, to follow the linux kernel coding style.
Signed-off-by: mamta <mamtashukla555@gmail.com>
---
drivers/staging/most/aim-
cdev/aim_cdev.mod.c | 26 ++++++++++++++++++++++++++
1 file changed, 26 insertions(+)
create mode 100644 drivers/staging/most/aim-cdev/aim_cdev.mod.c
diff --git a/drivers/staging/most/aim-cdev/aim_cdev.mod.c
b/drivers/staging/most/aim-cdev/aim_cdev.mod.c
new file mode 100644
index 0000000..0048f6c
--- /dev/null
+++ b/drivers/staging/most/aim-cdev/aim_cdev.mod.c
@@ -0,0 +1,26 @@
+#include <linux/module.h>
+#include <linux/vermagic.h>
+#include <linux/compiler.h>
+
+MODULE_INFO(vermagic, VERMAGIC_STRING);
+MODULE_INFO(name, KBUILD_MODNAME);
+
+__visible struct module __this_module
+__attribute__((section(".gnu.linkonce.this_module"))) = {
+ .name = KBUILD_MODNAME,
+ .init = init_module,
+#ifdef CONFIG_MODULE_UNLOAD
+ .exit = cleanup_module,
+#endif
+ .arch = MODULE_ARCH_INIT,
+};
+
+MODULE_INFO(intree, "Y");
+
+MODULE_INFO(staging, "Y");
+
+static const char __module_depends[]
+__used
+__attribute__((section(".modinfo"))) =
+"depends=mostcore";
+MODULE_INFO(srcversion, "9D77257EA6146867C072D85");
[-- Attachment #1.2: Type: text/html, Size: 2070 bytes --]
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH]:staging:most:aim-cdev:Reducing number of blank lines, to follow the coding style
2017-10-08 18:42 [PATCH]:staging:most:aim-cdev:Reducing number of blank lines, to follow the coding style mamta shukla
@ 2017-10-08 18:57 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2017-10-08 18:57 UTC (permalink / raw)
To: mamta shukla; +Cc: outreachy-kernel
[-- Attachment #1: Type: text/plain, Size: 2312 bytes --]
The format of the subject line is not correct. There should not be a : at
the beginning. There should be a space after each :. Run git log
--oneline on the file you are changing and follow the format of the
beginning of the subject line exactly.
On Sun, 8 Oct 2017, mamta shukla wrote:
> Reducing number of blank lines, to follow the linux kernel coding style.
linux -> Linux.
But the description is totally unrelated to what is done by the patch.
What is done by the patch looks quite incorrect. You should not be adding
new files.
julia
> Signed-off-by: mamta <mamtashukla555@gmail.com>
> ---
> drivers/staging/most/aim-cdev/aim_cdev.mod.c | 26
> ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
> create mode 100644 drivers/staging/most/aim-cdev/aim_cdev.mod.c
>
> diff --git a/drivers/staging/most/aim-cdev/aim_cdev.mod.c
> b/drivers/staging/most/aim-cdev/aim_cdev.mod.c
> new file mode 100644
> index 0000000..0048f6c
> --- /dev/null
> +++ b/drivers/staging/most/aim-cdev/aim_cdev.mod.c
> @@ -0,0 +1,26 @@
> +#include <linux/module.h>
> +#include <linux/vermagic.h>
> +#include <linux/compiler.h>
> +
> +MODULE_INFO(vermagic, VERMAGIC_STRING);
> +MODULE_INFO(name, KBUILD_MODNAME);
> +
> +__visible struct module __this_module
> +__attribute__((section(".gnu.linkonce.this_module"))) = {
> + .name = KBUILD_MODNAME,
> + .init = init_module,
> +#ifdef CONFIG_MODULE_UNLOAD
> + .exit = cleanup_module,
> +#endif
> + .arch = MODULE_ARCH_INIT,
> +};
> +
> +MODULE_INFO(intree, "Y");
> +
> +MODULE_INFO(staging, "Y");
> +
> +static const char __module_depends[]
> +__used
> +__attribute__((section(".modinfo"))) =
> +"depends=mostcore";
> +MODULE_INFO(srcversion, "9D77257EA6146867C072D85");[cleardot.gif]
>
> --
> You received this message because you are subscribed to the Google Groups
> "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visithttps://groups.google.com/d/msgid/outreachy-kernel/f674ab2c-4484-41d9-ba71-
> 6fafddc7792e%40googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-08 18:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-08 18:42 [PATCH]:staging:most:aim-cdev:Reducing number of blank lines, to follow the coding style mamta shukla
2017-10-08 18:57 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.