All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Dexuan Cui <decui@microsoft.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
	Josh Poulson <jopoulso@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Simon Xiao <sixiao@microsoft.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	"Mihai Costache (Cloudbase Solutions SRL)"
	<v-micos@microsoft.com>, Jork Loeser <Jork.Loeser@microsoft.com>
Subject: RE: [patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE
Date: Tue, 17 Oct 2017 23:49:30 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.20.1710172348450.2134@nanos> (raw)
In-Reply-To: <KL1P15301MB000624AF90FB90B39BE84160BF4C0@KL1P15301MB0006.APCP153.PROD.OUTLOOK.COM>

On Tue, 17 Oct 2017, Dexuan Cui wrote:

> > From: Thomas Gleixner [mailto:tglx@linutronix.de]
> > Sent: Tuesday, October 17, 2017 12:55 AM
> > --- a/arch/x86/Kconfig
> > +++ b/arch/x86/Kconfig
> > @@ -95,7 +95,7 @@ config X86
> >  	select GENERIC_IRQ_MATRIX_ALLOCATOR	if X86_LOCAL_APIC
> >  	select GENERIC_IRQ_MIGRATION		if SMP
> >  	select GENERIC_IRQ_PROBE
> > -	select GENERIC_IRQ_SHOW
> > +	select GENERIC_IRQ_RESERVATION_MODE
> >  	select GENERIC_PENDING_IRQ		if SMP
> >  	select GENERIC_SMP_IDLE_THREAD
> >  	select GENERIC_STRNCPY_FROM_USER
> 
> Hi Thomas,
> It looks you removed GENERIC_IRQ_SHOW by accident?

Indeed. My patch foo today is more than bad....

> I got this build error:
> ...
>   LD      vmlinux.o
>   MODPOST vmlinux.o
> fs/proc/interrupts.o:(.rodata+0x118): undefined reference to `show_interrupts'
> Makefile:1000: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
> 
> Adding GENERIC_IRQ_SHOW back can fix the build failure, and with the
> pachset Hyper-V PCI pass-through can work fine.

Thanks for testing.

       tglx

  reply	other threads:[~2017-10-17 21:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17  7:54 [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere Thomas Gleixner
2017-10-17  7:54 ` [patch 1/3] genirq: Add config option for reservation mode Thomas Gleixner
2017-10-17  7:54   ` Thomas Gleixner
2017-10-18 13:42   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-17  7:54 ` [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code Thomas Gleixner
2017-10-17  7:54   ` Thomas Gleixner
2017-10-17 12:28   ` Thomas Gleixner
2017-10-18 13:43   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-17  7:54 ` [patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE Thomas Gleixner
2017-10-17  7:54   ` Thomas Gleixner
2017-10-17 18:59   ` Dexuan Cui
2017-10-17 18:59     ` Dexuan Cui
2017-10-17 21:49     ` Thomas Gleixner [this message]
2017-10-18 13:43   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-20 23:01 ` [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere Bjorn Helgaas
2017-10-21  7:19   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1710172348450.2134@nanos \
    --to=tglx@linutronix.de \
    --cc=Jork.Loeser@microsoft.com \
    --cc=bhelgaas@google.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=jopoulso@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=saeedm@mellanox.com \
    --cc=sixiao@microsoft.com \
    --cc=sthemmin@microsoft.com \
    --cc=v-micos@microsoft.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.