All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>,
	x86@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	linux-pci@vger.kernel.org, devel@linuxdriverproject.org,
	Josh Poulson <jopoulso@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Simon Xiao <sixiao@microsoft.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Mihai Costache <v-micos@microsoft.com>,
	Jork Loeser <Jork.Loeser@microsoft.com>
Subject: [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code
Date: Tue, 17 Oct 2017 09:54:58 +0200	[thread overview]
Message-ID: <20171017075600.448649905@linutronix.de> (raw)
In-Reply-To: 20171017075456.694047687@linutronix.de

[-- Attachment #1: PCI-MSI--Set-MSI_FLAG_MUST_REACTIVATE-in-core-code.patch --]
[-- Type: text/plain, Size: 727 bytes --]

If interrupt reservation mode is enabled then the PCI/MSI interrupts must
be reactivated after early activation.

Make sure that all callers of pci_msi_create_irq_domain() have the
MSI_FLAG_MUST_REACTIVATE set when reservation mode is enabled.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1441,6 +1441,8 @@ struct irq_domain *pci_msi_create_irq_do
 		pci_msi_domain_update_chip_ops(info);
 
 	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION))
+		info->flags |= MSI_FLAG_MUST_REACTIVATE;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (!domain)

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>,
	x86@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	KY Srinivasan <kys@microsoft.com>,
	Stephen Hemminger <sthemmin@microsoft.com>,
	linux-pci@vger.kernel.org, devel@linuxdriverproject.org,
	Josh Poulson <jopoulso@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	Simon Xiao <sixiao@microsoft.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Mihai Costache <v-micos@microsoft.com>,
	Jork Loeser <Jork.Loeser@microsoft.com>
Subject: [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code
Date: Tue, 17 Oct 2017 09:54:58 +0200	[thread overview]
Message-ID: <20171017075600.448649905@linutronix.de> (raw)
In-Reply-To: 20171017075456.694047687@linutronix.de

If interrupt reservation mode is enabled then the PCI/MSI interrupts must
be reactivated after early activation.

Make sure that all callers of pci_msi_create_irq_domain() have the
MSI_FLAG_MUST_REACTIVATE set when reservation mode is enabled.

Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 drivers/pci/msi.c |    2 ++
 1 file changed, 2 insertions(+)

--- a/drivers/pci/msi.c
+++ b/drivers/pci/msi.c
@@ -1441,6 +1441,8 @@ struct irq_domain *pci_msi_create_irq_do
 		pci_msi_domain_update_chip_ops(info);
 
 	info->flags |= MSI_FLAG_ACTIVATE_EARLY;
+	if (IS_ENABLED(CONFIG_GENERIC_IRQ_RESERVATION))
+		info->flags |= MSI_FLAG_MUST_REACTIVATE;
 
 	domain = msi_create_irq_domain(fwnode, info, parent);
 	if (!domain)

  parent reply	other threads:[~2017-10-17  7:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-17  7:54 [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere Thomas Gleixner
2017-10-17  7:54 ` [patch 1/3] genirq: Add config option for reservation mode Thomas Gleixner
2017-10-17  7:54   ` Thomas Gleixner
2017-10-18 13:42   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-17  7:54 ` Thomas Gleixner [this message]
2017-10-17  7:54   ` [patch 2/3] PCI/MSI: Set MSI_FLAG_MUST_REACTIVATE in core code Thomas Gleixner
2017-10-17 12:28   ` Thomas Gleixner
2017-10-18 13:43   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-17  7:54 ` [patch 3/3] x86/vector/msi: Select CONFIG_GENERIC_IRQ_RESERVATION_MODE Thomas Gleixner
2017-10-17  7:54   ` Thomas Gleixner
2017-10-17 18:59   ` Dexuan Cui
2017-10-17 18:59     ` Dexuan Cui
2017-10-17 21:49     ` Thomas Gleixner
2017-10-18 13:43   ` [tip:x86/apic] " tip-bot for Thomas Gleixner
2017-10-20 23:01 ` [patch 0/3] x86/PCI/MSI: Make sure that irq reservation mode works everywhere Bjorn Helgaas
2017-10-21  7:19   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171017075600.448649905@linutronix.de \
    --to=tglx@linutronix.de \
    --cc=Jork.Loeser@microsoft.com \
    --cc=bhelgaas@google.com \
    --cc=decui@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=jopoulso@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=saeedm@mellanox.com \
    --cc=sixiao@microsoft.com \
    --cc=sthemmin@microsoft.com \
    --cc=v-micos@microsoft.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.