* [PATCH] mm/slab: Merge adjacent debug sections
@ 2017-12-07 10:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-12-07 10:18 UTC (permalink / raw)
To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
Andrew Morton
Cc: linux-mm, linux-kernel, Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
mm/slab.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c
index 70be5823227dcb3e..dd8c6d33f59a11d1 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
}
}
}
-#endif
-
-#if DEBUG
static void print_objinfo(struct kmem_cache *cachep, void *objp, int lines)
{
@@ -1661,9 +1658,7 @@ static void check_poison_obj(struct kmem_cache *cachep, void *objp)
}
}
}
-#endif
-#if DEBUG
static void slab_destroy_debugcheck(struct kmem_cache *cachep,
struct page *page)
{
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mm/slab: Merge adjacent debug sections
@ 2017-12-07 10:18 ` Geert Uytterhoeven
0 siblings, 0 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2017-12-07 10:18 UTC (permalink / raw)
To: Christoph Lameter, Pekka Enberg, David Rientjes, Joonsoo Kim,
Andrew Morton
Cc: linux-mm, linux-kernel, Geert Uytterhoeven
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
mm/slab.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/mm/slab.c b/mm/slab.c
index 70be5823227dcb3e..dd8c6d33f59a11d1 100644
--- a/mm/slab.c
+++ b/mm/slab.c
@@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
}
}
}
-#endif
-
-#if DEBUG
static void print_objinfo(struct kmem_cache *cachep, void *objp, int lines)
{
@@ -1661,9 +1658,7 @@ static void check_poison_obj(struct kmem_cache *cachep, void *objp)
}
}
}
-#endif
-#if DEBUG
static void slab_destroy_debugcheck(struct kmem_cache *cachep,
struct page *page)
{
--
2.7.4
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/slab: Merge adjacent debug sections
2017-12-07 10:18 ` Geert Uytterhoeven
@ 2017-12-07 11:17 ` Christopher Lameter
-1 siblings, 0 replies; 4+ messages in thread
From: Christopher Lameter @ 2017-12-07 11:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pekka Enberg, David Rientjes, Joonsoo Kim, Andrew Morton,
linux-mm, linux-kernel
On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
> }
> }
> }
> -#endif
> -
> -#if DEBUG
Hmmm... This may match at other places. Also there are a lot of #ifdef
DEBUG / #else in that section of the code. Maybe better leave as is? Or
generally rework this into a single #ifdef DEBUG section with all the
debugging code in it and an #else section with all the empty functions.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mm/slab: Merge adjacent debug sections
@ 2017-12-07 11:17 ` Christopher Lameter
0 siblings, 0 replies; 4+ messages in thread
From: Christopher Lameter @ 2017-12-07 11:17 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Pekka Enberg, David Rientjes, Joonsoo Kim, Andrew Morton,
linux-mm, linux-kernel
On Thu, 7 Dec 2017, Geert Uytterhoeven wrote:
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1569,9 +1569,6 @@ static void dump_line(char *data, int offset, int limit)
> }
> }
> }
> -#endif
> -
> -#if DEBUG
Hmmm... This may match at other places. Also there are a lot of #ifdef
DEBUG / #else in that section of the code. Maybe better leave as is? Or
generally rework this into a single #ifdef DEBUG section with all the
debugging code in it and an #else section with all the empty functions.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-07 11:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-07 10:18 [PATCH] mm/slab: Merge adjacent debug sections Geert Uytterhoeven
2017-12-07 10:18 ` Geert Uytterhoeven
2017-12-07 11:17 ` Christopher Lameter
2017-12-07 11:17 ` Christopher Lameter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.