All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: "Augustine.Chen" <augustine.chen@intel.com>,
	intel-gfx@lists.freedesktop.org, alsa-devel@alsa-project.org,
	jerome.anand@intel.com, pierre-louis.bossart@intel.com,
	tiwai@suse.de, Ingo Molnar <mingo@redhat.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	Juergen Gross <jgross@suse.com>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [Intel-gfx] [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
Date: Fri, 8 Dec 2017 23:51:35 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712082340400.2301@nanos> (raw)
In-Reply-To: <20171208114404.GN10981@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On Fri, 8 Dec 2017, Ville Syrjälä wrote:

> On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote:
> > The chip data of HDMI LPE audio is set to drm_i915_private which is not
> > consistent with the expectation by x86 APIC driver.
> 
> Hmm. Why is the apic code looking at data for an irq chip it
> hasn't created?
> 
> Do we need something like
> - dev_priv->lpe_audio.irq = irq_alloc_desc(0);
> + dev_priv->lpe_audio.irq = irq_alloc_desc(-1);

#define irq_alloc_desc(node)

So instead of handing in node 0 you hand in node -1 which is NUMA_NO_NODE

> That *looks* more correct to me based on a cursory glance at the x86
> code, but I didn't trawl very deeply.

The x86 core cares not at all about interrupt chips which are created in a
driver and not connected to an actual apic/ioapic/msi interrupt. This
interrupt chip is its own thing as we have others in GPIO etc.

> > In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would cause
> > kernel panic while doing CPU hotplug.

And why so? Surely not because you set irq_chip_data. That's really no
explanation at all.

Curing the symptom is never a good approach.

Thanks,

	tglx

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Juergen Gross <jgross@suse.com>,
	Dou Liyang <douly.fnst@cn.fujitsu.com>,
	alsa-devel@alsa-project.org, tiwai@suse.de,
	intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	Jiang Liu <jiang.liu@linux.intel.com>,
	"Augustine.Chen" <augustine.chen@intel.com>,
	pierre-louis.bossart@intel.com
Subject: Re: [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio
Date: Fri, 8 Dec 2017 23:51:35 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1712082340400.2301@nanos> (raw)
In-Reply-To: <20171208114404.GN10981@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1150 bytes --]

On Fri, 8 Dec 2017, Ville Syrjälä wrote:

> On Fri, Dec 08, 2017 at 05:33:23PM +0800, Augustine.Chen wrote:
> > The chip data of HDMI LPE audio is set to drm_i915_private which is not
> > consistent with the expectation by x86 APIC driver.
> 
> Hmm. Why is the apic code looking at data for an irq chip it
> hasn't created?
> 
> Do we need something like
> - dev_priv->lpe_audio.irq = irq_alloc_desc(0);
> + dev_priv->lpe_audio.irq = irq_alloc_desc(-1);

#define irq_alloc_desc(node)

So instead of handing in node 0 you hand in node -1 which is NUMA_NO_NODE

> That *looks* more correct to me based on a cursory glance at the x86
> code, but I didn't trawl very deeply.

The x86 core cares not at all about interrupt chips which are created in a
driver and not connected to an actual apic/ioapic/msi interrupt. This
interrupt chip is its own thing as we have others in GPIO etc.

> > In the case of not enabling CONFIG_CPUMASK_OFFSTACK, this would cause
> > kernel panic while doing CPU hotplug.

And why so? Surely not because you set irq_chip_data. That's really no
explanation at all.

Curing the symptom is never a good approach.

Thanks,

	tglx

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2017-12-08 22:52 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-08  9:33 [PATCH] drm/i915: Remove unused IRQ chip data of HDMI LPE audio Augustine.Chen
2017-12-08 11:16 ` ✓ Fi.CI.BAT: success for " Patchwork
2017-12-08 11:44 ` [Intel-gfx] [PATCH] " Ville Syrjälä
2017-12-08 11:44   ` Ville Syrjälä
2017-12-08 22:51   ` Thomas Gleixner [this message]
2017-12-08 22:51     ` Thomas Gleixner
2017-12-11  8:33     ` [Intel-gfx] " Anand, Jerome
2017-12-11  8:33       ` Anand, Jerome
2017-12-11 13:20       ` [Intel-gfx] " Ville Syrjälä
2017-12-11 13:20         ` Ville Syrjälä
2017-12-11 13:23         ` [Intel-gfx] " Takashi Iwai
2017-12-12  9:26           ` Chen, Augustine
2017-12-12  9:26             ` Chen, Augustine
2017-12-12  9:45             ` [Intel-gfx] " Takashi Iwai
2017-12-12  9:45               ` Takashi Iwai
2017-12-13  9:25               ` Chen, Augustine
2017-12-13  9:25                 ` Chen, Augustine
2017-12-12 17:06       ` [Intel-gfx] " Thomas Gleixner
2017-12-12 17:06         ` Thomas Gleixner
2017-12-13  2:15         ` [Intel-gfx] " Anand, Jerome
2017-12-13 11:35           ` Thomas Gleixner
2017-12-13 11:35             ` Thomas Gleixner
2017-12-13 11:52             ` [Intel-gfx] " Takashi Iwai
2017-12-13 11:52               ` Takashi Iwai
2017-12-13 14:06               ` [Intel-gfx] " Thomas Gleixner
2017-12-13 14:06                 ` Thomas Gleixner
2018-01-29 17:09                 ` [Intel-gfx] " Ville Syrjälä
2018-02-20 18:49                   ` Ville Syrjälä
2018-02-20 18:49                     ` Ville Syrjälä
2017-12-08 14:39 ` ✗ Fi.CI.IGT: warning for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1712082340400.2301@nanos \
    --to=tglx@linutronix.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=augustine.chen@intel.com \
    --cc=douly.fnst@cn.fujitsu.com \
    --cc=hpa@zytor.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jerome.anand@intel.com \
    --cc=jgross@suse.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pierre-louis.bossart@intel.com \
    --cc=tiwai@suse.de \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.