* [PATCH] staging: speakup: add spaces around arithmetic operators
@ 2018-02-19 19:13 Santha Meena Ramamoorthy
2018-02-19 20:59 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Santha Meena Ramamoorthy @ 2018-02-19 19:13 UTC (permalink / raw)
To: gregkh; +Cc: w.d.hubbs, outreachy-kernel, chris, Santha Meena Ramamoorthy
Add spaces around arithmetic operators ('+', '-' and '*') to conform to
Linux kernel coding style. Problem found using checkpatch.
Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
drivers/staging/speakup/speakup_dtlk.c | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
index f8cb83c..835582a 100644
--- a/drivers/staging/speakup/speakup_dtlk.c
+++ b/drivers/staging/speakup/speakup_dtlk.c
@@ -287,7 +287,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
}
t = buf;
/* serial number is little endian */
- status.serial_number = t[0] + t[1]*256;
+ status.serial_number = t[0] + t[1] * 256;
t += 2;
for (i = 0; *t != '\r'; t++) {
status.rom_version[i] = *t;
@@ -326,13 +326,13 @@ static int synth_probe(struct spk_synth *synth)
speakup_info.port_tts);
if ((port_forced & 0xf) != 0xf)
pr_info("warning: port base should probably end with f\n");
- if (synth_request_region(speakup_info.port_tts-1,
- SYNTH_IO_EXTENT)) {
+ if (synth_request_region(speakup_info.port_tts - 1,
+ SYNTH_IO_EXTENT)) {
pr_warn("sorry, port already reserved\n");
return -EBUSY;
}
- port_val = inw(speakup_info.port_tts-1);
- synth_lpc = speakup_info.port_tts-1;
+ port_val = inw(speakup_info.port_tts - 1);
+ synth_lpc = speakup_info.port_tts - 1;
} else {
for (i = 0; synth_portlist[i]; i++) {
if (synth_request_region(synth_portlist[i],
@@ -341,7 +341,7 @@ static int synth_probe(struct spk_synth *synth)
port_val = inw(synth_portlist[i]) & 0xfbff;
if (port_val == 0x107f) {
synth_lpc = synth_portlist[i];
- speakup_info.port_tts = synth_lpc+1;
+ speakup_info.port_tts = synth_lpc + 1;
break;
}
synth_release_region(synth_portlist[i],
@@ -359,7 +359,7 @@ static int synth_probe(struct spk_synth *synth)
cpu_relax(); /* wait until it's ready */
sp = synth_interrogate(synth);
pr_info("%s: %03x-%03x, ROM ver %s, s/n %u, driver: %s\n",
- synth->long_name, synth_lpc, synth_lpc+SYNTH_IO_EXTENT - 1,
+ synth->long_name, synth_lpc, synth_lpc + SYNTH_IO_EXTENT - 1,
sp->rom_version, sp->serial_number, synth->version);
synth->alive = 1;
return 0;
@@ -369,7 +369,8 @@ static void dtlk_release(void)
{
spk_stop_serial_interrupt();
if (speakup_info.port_tts)
- synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT);
+ synth_release_region(speakup_info.port_tts - 1,
+ SYNTH_IO_EXTENT);
speakup_info.port_tts = 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: add spaces around arithmetic operators
2018-02-19 19:13 [PATCH] staging: speakup: add spaces around arithmetic operators Santha Meena Ramamoorthy
@ 2018-02-19 20:59 ` Julia Lawall
2018-02-21 17:56 ` Santha Meena Ramamoorthy
2018-02-21 19:04 ` Santha Meena Ramamoorthy
0 siblings, 2 replies; 4+ messages in thread
From: Julia Lawall @ 2018-02-19 20:59 UTC (permalink / raw)
To: Santha Meena Ramamoorthy; +Cc: gregkh, w.d.hubbs, outreachy-kernel, chris
On Mon, 19 Feb 2018, Santha Meena Ramamoorthy wrote:
> Add spaces around arithmetic operators ('+', '-' and '*') to conform to
> Linux kernel coding style. Problem found using checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> ---
> drivers/staging/speakup/speakup_dtlk.c | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
> index f8cb83c..835582a 100644
> --- a/drivers/staging/speakup/speakup_dtlk.c
> +++ b/drivers/staging/speakup/speakup_dtlk.c
> @@ -287,7 +287,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
> }
> t = buf;
> /* serial number is little endian */
> - status.serial_number = t[0] + t[1]*256;
> + status.serial_number = t[0] + t[1] * 256;
> t += 2;
> for (i = 0; *t != '\r'; t++) {
> status.rom_version[i] = *t;
> @@ -326,13 +326,13 @@ static int synth_probe(struct spk_synth *synth)
> speakup_info.port_tts);
> if ((port_forced & 0xf) != 0xf)
> pr_info("warning: port base should probably end with f\n");
> - if (synth_request_region(speakup_info.port_tts-1,
> - SYNTH_IO_EXTENT)) {
> + if (synth_request_region(speakup_info.port_tts - 1,
> + SYNTH_IO_EXTENT)) {
I don't think that adjusting the indentation of SYNTH_IO_EXTENT is
necessary for the space around - change. The spacing is indeed improved,
but that should be in another patch.
julia
> pr_warn("sorry, port already reserved\n");
> return -EBUSY;
> }
> - port_val = inw(speakup_info.port_tts-1);
> - synth_lpc = speakup_info.port_tts-1;
> + port_val = inw(speakup_info.port_tts - 1);
> + synth_lpc = speakup_info.port_tts - 1;
> } else {
> for (i = 0; synth_portlist[i]; i++) {
> if (synth_request_region(synth_portlist[i],
> @@ -341,7 +341,7 @@ static int synth_probe(struct spk_synth *synth)
> port_val = inw(synth_portlist[i]) & 0xfbff;
> if (port_val == 0x107f) {
> synth_lpc = synth_portlist[i];
> - speakup_info.port_tts = synth_lpc+1;
> + speakup_info.port_tts = synth_lpc + 1;
> break;
> }
> synth_release_region(synth_portlist[i],
> @@ -359,7 +359,7 @@ static int synth_probe(struct spk_synth *synth)
> cpu_relax(); /* wait until it's ready */
> sp = synth_interrogate(synth);
> pr_info("%s: %03x-%03x, ROM ver %s, s/n %u, driver: %s\n",
> - synth->long_name, synth_lpc, synth_lpc+SYNTH_IO_EXTENT - 1,
> + synth->long_name, synth_lpc, synth_lpc + SYNTH_IO_EXTENT - 1,
> sp->rom_version, sp->serial_number, synth->version);
> synth->alive = 1;
> return 0;
> @@ -369,7 +369,8 @@ static void dtlk_release(void)
> {
> spk_stop_serial_interrupt();
> if (speakup_info.port_tts)
> - synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT);
> + synth_release_region(speakup_info.port_tts - 1,
> + SYNTH_IO_EXTENT);
> speakup_info.port_tts = 0;
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519067638-5144-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: add spaces around arithmetic operators
2018-02-19 20:59 ` [Outreachy kernel] " Julia Lawall
@ 2018-02-21 17:56 ` Santha Meena Ramamoorthy
2018-02-21 19:04 ` Santha Meena Ramamoorthy
1 sibling, 0 replies; 4+ messages in thread
From: Santha Meena Ramamoorthy @ 2018-02-21 17:56 UTC (permalink / raw)
To: Julia Lawall, outreachy-kernel
On Mon, Feb 19, 2018 at 09:59:50PM +0100, Julia Lawall wrote:
>
>
> On Mon, 19 Feb 2018, Santha Meena Ramamoorthy wrote:
>
> > Add spaces around arithmetic operators ('+', '-' and '*') to conform to
> > Linux kernel coding style. Problem found using checkpatch.
> >
> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > ---
> > drivers/staging/speakup/speakup_dtlk.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
> > index f8cb83c..835582a 100644
> > --- a/drivers/staging/speakup/speakup_dtlk.c
> > +++ b/drivers/staging/speakup/speakup_dtlk.c
> > @@ -287,7 +287,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
> > }
> > t = buf;
> > /* serial number is little endian */
> > - status.serial_number = t[0] + t[1]*256;
> > + status.serial_number = t[0] + t[1] * 256;
> > t += 2;
> > for (i = 0; *t != '\r'; t++) {
> > status.rom_version[i] = *t;
> > @@ -326,13 +326,13 @@ static int synth_probe(struct spk_synth *synth)
> > speakup_info.port_tts);
> > if ((port_forced & 0xf) != 0xf)
> > pr_info("warning: port base should probably end with f\n");
> > - if (synth_request_region(speakup_info.port_tts-1,
> > - SYNTH_IO_EXTENT)) {
> > + if (synth_request_region(speakup_info.port_tts - 1,
> > + SYNTH_IO_EXTENT)) {
>
> I don't think that adjusting the indentation of SYNTH_IO_EXTENT is
> necessary for the space around - change. The spacing is indeed improved,
> but that should be in another patch.
>
> julia
Hi,
Sure, I'll make the change and submit the v2 now. Thanks :)
>
> > pr_warn("sorry, port already reserved\n");
> > return -EBUSY;
> > }
> > - port_val = inw(speakup_info.port_tts-1);
> > - synth_lpc = speakup_info.port_tts-1;
> > + port_val = inw(speakup_info.port_tts - 1);
> > + synth_lpc = speakup_info.port_tts - 1;
> > } else {
> > for (i = 0; synth_portlist[i]; i++) {
> > if (synth_request_region(synth_portlist[i],
> > @@ -341,7 +341,7 @@ static int synth_probe(struct spk_synth *synth)
> > port_val = inw(synth_portlist[i]) & 0xfbff;
> > if (port_val == 0x107f) {
> > synth_lpc = synth_portlist[i];
> > - speakup_info.port_tts = synth_lpc+1;
> > + speakup_info.port_tts = synth_lpc + 1;
> > break;
> > }
> > synth_release_region(synth_portlist[i],
> > @@ -359,7 +359,7 @@ static int synth_probe(struct spk_synth *synth)
> > cpu_relax(); /* wait until it's ready */
> > sp = synth_interrogate(synth);
> > pr_info("%s: %03x-%03x, ROM ver %s, s/n %u, driver: %s\n",
> > - synth->long_name, synth_lpc, synth_lpc+SYNTH_IO_EXTENT - 1,
> > + synth->long_name, synth_lpc, synth_lpc + SYNTH_IO_EXTENT - 1,
> > sp->rom_version, sp->serial_number, synth->version);
> > synth->alive = 1;
> > return 0;
> > @@ -369,7 +369,8 @@ static void dtlk_release(void)
> > {
> > spk_stop_serial_interrupt();
> > if (speakup_info.port_tts)
> > - synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT);
> > + synth_release_region(speakup_info.port_tts - 1,
> > + SYNTH_IO_EXTENT);
> > speakup_info.port_tts = 0;
> > }
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519067638-5144-1-git-send-email-santhameena13%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: speakup: add spaces around arithmetic operators
2018-02-19 20:59 ` [Outreachy kernel] " Julia Lawall
2018-02-21 17:56 ` Santha Meena Ramamoorthy
@ 2018-02-21 19:04 ` Santha Meena Ramamoorthy
1 sibling, 0 replies; 4+ messages in thread
From: Santha Meena Ramamoorthy @ 2018-02-21 19:04 UTC (permalink / raw)
To: Julia Lawall, outreachy-kernel
On Mon, Feb 19, 2018 at 09:59:50PM +0100, Julia Lawall wrote:
>
>
> On Mon, 19 Feb 2018, Santha Meena Ramamoorthy wrote:
>
> > Add spaces around arithmetic operators ('+', '-' and '*') to conform to
> > Linux kernel coding style. Problem found using checkpatch.
> >
> > Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
> > ---
> > drivers/staging/speakup/speakup_dtlk.c | 17 +++++++++--------
> > 1 file changed, 9 insertions(+), 8 deletions(-)
> >
> > diff --git a/drivers/staging/speakup/speakup_dtlk.c b/drivers/staging/speakup/speakup_dtlk.c
> > index f8cb83c..835582a 100644
> > --- a/drivers/staging/speakup/speakup_dtlk.c
> > +++ b/drivers/staging/speakup/speakup_dtlk.c
> > @@ -287,7 +287,7 @@ static struct synth_settings *synth_interrogate(struct spk_synth *synth)
> > }
> > t = buf;
> > /* serial number is little endian */
> > - status.serial_number = t[0] + t[1]*256;
> > + status.serial_number = t[0] + t[1] * 256;
> > t += 2;
> > for (i = 0; *t != '\r'; t++) {
> > status.rom_version[i] = *t;
> > @@ -326,13 +326,13 @@ static int synth_probe(struct spk_synth *synth)
> > speakup_info.port_tts);
> > if ((port_forced & 0xf) != 0xf)
> > pr_info("warning: port base should probably end with f\n");
> > - if (synth_request_region(speakup_info.port_tts-1,
> > - SYNTH_IO_EXTENT)) {
> > + if (synth_request_region(speakup_info.port_tts - 1,
> > + SYNTH_IO_EXTENT)) {
>
> I don't think that adjusting the indentation of SYNTH_IO_EXTENT is
> necessary for the space around - change. The spacing is indeed improved,
> but that should be in another patch.
>
> julia
Hi,
When I removed the space for SYNTH_IO_EXTENT, checkpatch showed warning. So I split my changes into logical series and submitted them as a patchset.
>
> > pr_warn("sorry, port already reserved\n");
> > return -EBUSY;
> > }
> > - port_val = inw(speakup_info.port_tts-1);
> > - synth_lpc = speakup_info.port_tts-1;
> > + port_val = inw(speakup_info.port_tts - 1);
> > + synth_lpc = speakup_info.port_tts - 1;
> > } else {
> > for (i = 0; synth_portlist[i]; i++) {
> > if (synth_request_region(synth_portlist[i],
> > @@ -341,7 +341,7 @@ static int synth_probe(struct spk_synth *synth)
> > port_val = inw(synth_portlist[i]) & 0xfbff;
> > if (port_val == 0x107f) {
> > synth_lpc = synth_portlist[i];
> > - speakup_info.port_tts = synth_lpc+1;
> > + speakup_info.port_tts = synth_lpc + 1;
> > break;
> > }
> > synth_release_region(synth_portlist[i],
> > @@ -359,7 +359,7 @@ static int synth_probe(struct spk_synth *synth)
> > cpu_relax(); /* wait until it's ready */
> > sp = synth_interrogate(synth);
> > pr_info("%s: %03x-%03x, ROM ver %s, s/n %u, driver: %s\n",
> > - synth->long_name, synth_lpc, synth_lpc+SYNTH_IO_EXTENT - 1,
> > + synth->long_name, synth_lpc, synth_lpc + SYNTH_IO_EXTENT - 1,
> > sp->rom_version, sp->serial_number, synth->version);
> > synth->alive = 1;
> > return 0;
> > @@ -369,7 +369,8 @@ static void dtlk_release(void)
> > {
> > spk_stop_serial_interrupt();
> > if (speakup_info.port_tts)
> > - synth_release_region(speakup_info.port_tts-1, SYNTH_IO_EXTENT);
> > + synth_release_region(speakup_info.port_tts - 1,
> > + SYNTH_IO_EXTENT);
> > speakup_info.port_tts = 0;
> > }
> >
> > --
> > 2.7.4
> >
> > --
> > You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> > To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> > To post to this group, send email to outreachy-kernel@googlegroups.com.
> > To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1519067638-5144-1-git-send-email-santhameena13%40gmail.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-21 19:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-19 19:13 [PATCH] staging: speakup: add spaces around arithmetic operators Santha Meena Ramamoorthy
2018-02-19 20:59 ` [Outreachy kernel] " Julia Lawall
2018-02-21 17:56 ` Santha Meena Ramamoorthy
2018-02-21 19:04 ` Santha Meena Ramamoorthy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.