All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] staging: rtl8188eu: place constant on the right side of test
@ 2018-03-05 18:37 Santha Meena Ramamoorthy
  2018-03-05 22:01 ` [Outreachy kernel] " Julia Lawall
  0 siblings, 1 reply; 2+ messages in thread
From: Santha Meena Ramamoorthy @ 2018-03-05 18:37 UTC (permalink / raw)
  To: gregkh; +Cc: outreachy-kernel, Santha Meena Ramamoorthy

Place constants on the right side of the test during comparisons to
conform to the Linux kernel coding style. Issue found using checkpatch.

Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>
---
Change in v2:
 - Mention tool used in the commit message.

 drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c      | 2 +-
 drivers/staging/rtl8188eu/hal/rtl8188e_dm.c       | 2 +-
 drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 8 ++++----
 drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c    | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
index 1ab2e55..8d242ad 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
@@ -36,7 +36,7 @@ static u8 _is_fw_read_cmd_down(struct adapter *adapt, u8 msgbox_num)
 
 	do {
 		valid = usb_read8(adapt, REG_HMETFR) & BIT(msgbox_num);
-		if (0 == valid)
+		if (valid == 0)
 			read_down = true;
 	} while ((!read_down) && (retry_cnts--));
 
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
index d04b7fb..ff227c8 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
@@ -182,7 +182,7 @@ void rtw_hal_dm_init(struct adapter *Adapter)
 /*  Compare RSSI for deciding antenna */
 void rtw_hal_antdiv_rssi_compared(struct adapter *Adapter, struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src)
 {
-	if (0 != Adapter->HalData->AntDivCfg) {
+	if (Adapter->HalData->AntDivCfg != 0) {
 		/* select optimum_antenna for before linked =>For antenna diversity */
 		if (dst->Rssi >=  src->Rssi) {/* keep org parameter */
 			src->Rssi = dst->Rssi;
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
index 3673f57..54ede4b 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
@@ -221,13 +221,13 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
 	} else {
 		for (i = 0; i < (txpktbuf_bndy - 1); i++) {
 			status = _LLTWrite(padapter, i, i + 1);
-			if (_SUCCESS != status)
+			if (status != _SUCCESS)
 				return status;
 		}
 
 		/*  end of list */
 		status = _LLTWrite(padapter, (txpktbuf_bndy - 1), 0xFF);
-		if (_SUCCESS != status)
+		if (status != _SUCCESS)
 			return status;
 
 		/*  Make the other pages as ring buffer */
@@ -235,13 +235,13 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
 		/*  Otherwise used as local loopback buffer. */
 		for (i = txpktbuf_bndy; i < Last_Entry_Of_TxPktBuf; i++) {
 			status = _LLTWrite(padapter, i, (i + 1));
-			if (_SUCCESS != status)
+			if (status != _SUCCESS)
 				return status;
 		}
 
 		/*  Let last entry point to the start entry of ring buffer */
 		status = _LLTWrite(padapter, Last_Entry_Of_TxPktBuf, txpktbuf_bndy);
-		if (_SUCCESS != status) {
+		if (status != _SUCCESS) {
 			return status;
 		}
 	}
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
index a9912b6..4f0f512 100644
--- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
+++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
@@ -552,7 +552,7 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp
 		pbuf = round_up(pbuf_tail, 8);
 
 		pfirstframe->agg_num++;
-		if (MAX_TX_AGG_PACKET_NUMBER == pfirstframe->agg_num)
+		if (pfirstframe->agg_num ==  MAX_TX_AGG_PACKET_NUMBER)
 			break;
 
 		if (pbuf < bulkptr) {
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH v2] staging: rtl8188eu: place constant on the right side of test
  2018-03-05 18:37 [PATCH v2] staging: rtl8188eu: place constant on the right side of test Santha Meena Ramamoorthy
@ 2018-03-05 22:01 ` Julia Lawall
  0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2018-03-05 22:01 UTC (permalink / raw)
  To: Santha Meena Ramamoorthy; +Cc: gregkh, outreachy-kernel



On Mon, 5 Mar 2018, Santha Meena Ramamoorthy wrote:

> Place constants on the right side of the test during comparisons to
> conform to the Linux kernel coding style. Issue found using checkpatch.
>
> Signed-off-by: Santha Meena Ramamoorthy <santhameena13@gmail.com>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Change in v2:
>  - Mention tool used in the commit message.
>
>  drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c      | 2 +-
>  drivers/staging/rtl8188eu/hal/rtl8188e_dm.c       | 2 +-
>  drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 8 ++++----
>  drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c    | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> index 1ab2e55..8d242ad 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_cmd.c
> @@ -36,7 +36,7 @@ static u8 _is_fw_read_cmd_down(struct adapter *adapt, u8 msgbox_num)
>
>  	do {
>  		valid = usb_read8(adapt, REG_HMETFR) & BIT(msgbox_num);
> -		if (0 == valid)
> +		if (valid == 0)
>  			read_down = true;
>  	} while ((!read_down) && (retry_cnts--));
>
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> index d04b7fb..ff227c8 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_dm.c
> @@ -182,7 +182,7 @@ void rtw_hal_dm_init(struct adapter *Adapter)
>  /*  Compare RSSI for deciding antenna */
>  void rtw_hal_antdiv_rssi_compared(struct adapter *Adapter, struct wlan_bssid_ex *dst, struct wlan_bssid_ex *src)
>  {
> -	if (0 != Adapter->HalData->AntDivCfg) {
> +	if (Adapter->HalData->AntDivCfg != 0) {
>  		/* select optimum_antenna for before linked =>For antenna diversity */
>  		if (dst->Rssi >=  src->Rssi) {/* keep org parameter */
>  			src->Rssi = dst->Rssi;
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> index 3673f57..54ede4b 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c
> @@ -221,13 +221,13 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
>  	} else {
>  		for (i = 0; i < (txpktbuf_bndy - 1); i++) {
>  			status = _LLTWrite(padapter, i, i + 1);
> -			if (_SUCCESS != status)
> +			if (status != _SUCCESS)
>  				return status;
>  		}
>
>  		/*  end of list */
>  		status = _LLTWrite(padapter, (txpktbuf_bndy - 1), 0xFF);
> -		if (_SUCCESS != status)
> +		if (status != _SUCCESS)
>  			return status;
>
>  		/*  Make the other pages as ring buffer */
> @@ -235,13 +235,13 @@ s32 InitLLTTable(struct adapter *padapter, u8 txpktbuf_bndy)
>  		/*  Otherwise used as local loopback buffer. */
>  		for (i = txpktbuf_bndy; i < Last_Entry_Of_TxPktBuf; i++) {
>  			status = _LLTWrite(padapter, i, (i + 1));
> -			if (_SUCCESS != status)
> +			if (status != _SUCCESS)
>  				return status;
>  		}
>
>  		/*  Let last entry point to the start entry of ring buffer */
>  		status = _LLTWrite(padapter, Last_Entry_Of_TxPktBuf, txpktbuf_bndy);
> -		if (_SUCCESS != status) {
> +		if (status != _SUCCESS) {
>  			return status;
>  		}
>  	}
> diff --git a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> index a9912b6..4f0f512 100644
> --- a/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> +++ b/drivers/staging/rtl8188eu/hal/rtl8188eu_xmit.c
> @@ -552,7 +552,7 @@ s32 rtl8188eu_xmitframe_complete(struct adapter *adapt, struct xmit_priv *pxmitp
>  		pbuf = round_up(pbuf_tail, 8);
>
>  		pfirstframe->agg_num++;
> -		if (MAX_TX_AGG_PACKET_NUMBER == pfirstframe->agg_num)
> +		if (pfirstframe->agg_num ==  MAX_TX_AGG_PACKET_NUMBER)
>  			break;
>
>  		if (pbuf < bulkptr) {
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1520275079-54162-1-git-send-email-santhameena13%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>


^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-03-05 22:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-05 18:37 [PATCH v2] staging: rtl8188eu: place constant on the right side of test Santha Meena Ramamoorthy
2018-03-05 22:01 ` [Outreachy kernel] " Julia Lawall

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.