[PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

[PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

[Nishka Dasgupta]

Replace simple_strtoul with kstrtoul. Issue found with checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
 drivers/staging/speakup/varhandlers.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/speakup/varhandlers.c b/drivers/staging/speakup/varhandlers.c
index 3214055..e27bd5c 100644
--- a/drivers/staging/speakup/varhandlers.c
+++ b/drivers/staging/speakup/varhandlers.c
@@ -327,8 +327,9 @@ char *spk_strlwr(char *s)
 char *spk_s2uchar(char *start, char *dest)
 {
 	int val;
+	unsigned long v = 0;
 
-	val = simple_strtoul(skip_spaces(start), &start, 10);
+	val = kstrtoul(skip_spaces(start), 10, &v);
 	if (*start == ',')
 		start++;
 	*dest = (u_char)val;
-- 
1.9.1

Re: [PATCH] staging: speakup: Replace simple_strtoul with kstrtoul

[Samuel Thibault]

Nishka Dasgupta, on ven. 09 mars 2018 01:19:12 +0530, wrote:
> Replace simple_strtoul with kstrtoul. Issue found with checkpatch.

Again, they are not the same, we need start to be updated.

Re: [PATCH] staging: speakup: Replace simple_strtoul with

[Nishka Dasgupta]

>Nishka Dasgupta, on ven. 09 mars 2018 01:19:12 +0530 wrote:
>>Replace simple_strtoul with kstrtoul. Issue found with checkpatch.
>
>Again, they are not the same, we need start to be updated.
>
>Samuel

I am so sorry for sending the same buggy fix multiple times. Thank you
for the clarification. I will avoid kstrtoul warnings in future.

While we are on the topic of speakup, should I also stay clear of the
checkpatch warnings in keyhelp.c:102 and keyhelp.c:743 to add a
KERN_<LEVEL> signifier in the printk() commands on those lines?

Thank you for your time. 

Regards, 

Nishka Dasgupta

Re: [PATCH] staging: speakup: Replace simple_strtoul with

[Samuel Thibault]

Nishka Dasgupta, on ven. 09 mars 2018 01:33:45 +0530, wrote:
> While we are on the topic of speakup, should I also stay clear of the
> checkpatch warnings in keyhelp.c:102 and keyhelp.c:743 to add a
> KERN_<LEVEL> signifier in the printk() commands on those lines?

That should be fine.

Samuel

Re: [PATCH] staging: speakup: Replace simple_strtoul with

[Nishka Dasgupta]

On Fri, Mar 9, 2018 at 2:18 AM, Samuel Thibault
<samuel.thibault@ens-lyon.org> wrote:
> Nishka Dasgupta, on ven. 09 mars 2018 01:33:45 +0530, wrote:
>> While we are on the topic of speakup, should I also stay clear of the
>> checkpatch warnings in keyhelp.c:102 and keyhelp.c:743 to add a
>> KERN_<LEVEL> signifier in the printk() commands on those lines?
>
> That should be fine.

What Kernel message should I include within the printk statements, if
any? KERN_DEBUG,
KERN_EMERG, KERN_ALERT, KERN_CRIT, KERN_ERR, KERN_WARNING, KERN_NOTICE,
or KERN_INFO?

Thanking you,
Nishka Dasgupta

Re: [PATCH] staging: speakup: Replace simple_strtoul with

[Samuel Thibault]

Nishka Dasgupta, on ven. 09 mars 2018 02:45:18 +0530, wrote:
> On Fri, Mar 9, 2018 at 2:18 AM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > Nishka Dasgupta, on ven. 09 mars 2018 01:33:45 +0530, wrote:
> >> While we are on the topic of speakup, should I also stay clear of the
> >> checkpatch warnings in keyhelp.c:102 and keyhelp.c:743 to add a
> >> KERN_<LEVEL> signifier in the printk() commands on those lines?
> >
> > That should be fine.
> 
> What Kernel message should I include within the printk statements, if
> any? KERN_DEBUG,
> KERN_EMERG, KERN_ALERT, KERN_CRIT, KERN_ERR, KERN_WARNING, KERN_NOTICE,
> or KERN_INFO?

That depends on the message.

Samuel

Re: [Outreachy kernel] Re: [PATCH] staging: speakup: Replace simple_strtoul with

[Julia Lawall]

On Fri, 9 Mar 2018, Nishka Dasgupta wrote:

> On Fri, Mar 9, 2018 at 2:18 AM, Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> > Nishka Dasgupta, on ven. 09 mars 2018 01:33:45 +0530, wrote:
> >> While we are on the topic of speakup, should I also stay clear of the
> >> checkpatch warnings in keyhelp.c:102 and keyhelp.c:743 to add a
> >> KERN_<LEVEL> signifier in the printk() commands on those lines?
> >
> > That should be fine.
>
> What Kernel message should I include within the printk statements, if
> any? KERN_DEBUG,
> KERN_EMERG, KERN_ALERT, KERN_CRIT, KERN_ERR, KERN_WARNING, KERN_NOTICE,
> or KERN_INFO?

You could pick a few and see what seems best to you, and then see what
feedback you get on the patch.

julia

>
> Thanking you,
> Nishka Dasgupta
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAC4%2B%2BKCd3fAuzm3Pbz5oZEF%3DN9amgAd3tsBRgPzT1d39CGLF6A%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>