From: Julia Lawall <julia.lawall@lip6.fr>
To: Matthew Wilcox <willy@infradead.org>
Cc: Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Matthew Wilcox <mawilcox@microsoft.com>,
Linux-MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Kernel Hardening <kernel-hardening@lists.openwall.com>,
cocci@systeme.lip6.fr, Himanshu Jha <himanshujha199640@gmail.com>
Subject: Re: [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct
Date: Tue, 13 Mar 2018 19:35:44 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1803131935160.3117@hadrien> (raw)
In-Reply-To: <20180313183220.GA21538@bombadil.infradead.org>
On Tue, 13 Mar 2018, Matthew Wilcox wrote:
> On Tue, Mar 13, 2018 at 06:19:51PM +0100, Julia Lawall wrote:
> > On Thu, 8 Mar 2018, Matthew Wilcox wrote:
> > > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote:
> > > > Thanks. So it's OK to replace kmalloc and kzalloc, even though they
> > > > didn't previously consider vmalloc and even though kmalloc doesn't zero?
> > >
> > > We'll also need to replace the corresponding places where those structs
> > > are freed with kvfree(). Can coccinelle handle that too?
> >
> > Is the use of vmalloc a necessary part of the design? Or could there be a
> > non vmalloc versions for call sites that are already ok with that?
>
> We can also add kmalloc_struct() along with kmalloc_ab_c that won't fall
> back to vmalloc but just return NULL.
It could be safer than being sure to find all of the relevant kfrees.
julia
WARNING: multiple messages have this Message-ID (diff)
From: julia.lawall@lip6.fr (Julia Lawall)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct
Date: Tue, 13 Mar 2018 19:35:44 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1803131935160.3117@hadrien> (raw)
In-Reply-To: <20180313183220.GA21538@bombadil.infradead.org>
On Tue, 13 Mar 2018, Matthew Wilcox wrote:
> On Tue, Mar 13, 2018 at 06:19:51PM +0100, Julia Lawall wrote:
> > On Thu, 8 Mar 2018, Matthew Wilcox wrote:
> > > On Thu, Mar 08, 2018 at 07:24:47AM +0100, Julia Lawall wrote:
> > > > Thanks. So it's OK to replace kmalloc and kzalloc, even though they
> > > > didn't previously consider vmalloc and even though kmalloc doesn't zero?
> > >
> > > We'll also need to replace the corresponding places where those structs
> > > are freed with kvfree(). Can coccinelle handle that too?
> >
> > Is the use of vmalloc a necessary part of the design? Or could there be a
> > non vmalloc versions for call sites that are already ok with that?
>
> We can also add kmalloc_struct() along with kmalloc_ab_c that won't fall
> back to vmalloc but just return NULL.
It could be safer than being sure to find all of the relevant kfrees.
julia
next prev parent reply other threads:[~2018-03-13 18:35 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 18:26 [PATCH 0/2] Add kvzalloc_struct to complement kvzalloc_array Matthew Wilcox
2018-02-14 18:26 ` Matthew Wilcox
2018-02-14 18:26 ` [PATCH 1/2] mm: Add kernel-doc for kvfree Matthew Wilcox
2018-02-14 18:26 ` Matthew Wilcox
2018-02-14 18:26 ` [PATCH 2/2] mm: Add kvmalloc_ab_c and kvzalloc_struct Matthew Wilcox
2018-02-14 18:26 ` Matthew Wilcox
2018-02-14 19:22 ` Kees Cook
2018-02-14 19:22 ` [Cocci] " Kees Cook
2018-02-14 19:22 ` Kees Cook
2018-02-14 19:27 ` Julia Lawall
2018-02-14 19:27 ` [Cocci] " Julia Lawall
2018-02-14 19:27 ` Julia Lawall
2018-02-14 19:35 ` Matthew Wilcox
2018-02-14 19:35 ` [Cocci] " Matthew Wilcox
2018-02-14 19:35 ` Matthew Wilcox
2018-03-07 21:18 ` Julia Lawall
2018-03-07 21:18 ` [Cocci] " Julia Lawall
2018-03-08 2:58 ` Matthew Wilcox
2018-03-08 2:58 ` [Cocci] " Matthew Wilcox
2018-03-08 6:24 ` Julia Lawall
2018-03-08 6:24 ` [Cocci] " Julia Lawall
2018-03-08 23:05 ` Matthew Wilcox
2018-03-08 23:05 ` [Cocci] " Matthew Wilcox
2018-03-09 5:59 ` Julia Lawall
2018-03-09 5:59 ` [Cocci] " Julia Lawall
2018-03-13 17:19 ` Julia Lawall
2018-03-13 17:19 ` [Cocci] " Julia Lawall
2018-03-13 18:32 ` Matthew Wilcox
2018-03-13 18:32 ` [Cocci] " Matthew Wilcox
2018-03-13 18:35 ` Julia Lawall [this message]
2018-03-13 18:35 ` Julia Lawall
2018-04-29 16:59 ` Kees Cook
2018-04-29 16:59 ` [Cocci] " Kees Cook
2018-04-29 20:30 ` Matthew Wilcox
2018-04-29 20:30 ` [Cocci] " Matthew Wilcox
2018-04-30 19:02 ` Kees Cook
2018-04-30 19:02 ` [Cocci] " Kees Cook
2018-04-30 20:16 ` Matthew Wilcox
2018-04-30 20:16 ` [Cocci] " Matthew Wilcox
2018-04-30 21:29 ` Rasmus Villemoes
2018-04-30 21:29 ` [Cocci] " Rasmus Villemoes
2018-04-30 22:41 ` Matthew Wilcox
2018-04-30 22:41 ` [Cocci] " Matthew Wilcox
2018-05-01 17:00 ` Kees Cook
2018-05-01 17:00 ` [Cocci] " Kees Cook
2018-05-01 17:41 ` Julia Lawall
2018-05-01 17:41 ` [Cocci] " Julia Lawall
2018-05-03 23:00 ` Rasmus Villemoes
2018-05-03 23:00 ` [Cocci] " Rasmus Villemoes
2018-05-04 0:36 ` Kees Cook
2018-05-04 0:36 ` [Cocci] " Kees Cook
2018-05-04 0:40 ` Kees Cook
2018-05-04 0:40 ` [Cocci] " Kees Cook
2018-04-30 22:29 ` Kees Cook
2018-04-30 22:29 ` [Cocci] " Kees Cook
2018-02-14 19:55 ` Christopher Lameter
2018-02-14 19:55 ` Christopher Lameter
2018-02-14 20:14 ` Matthew Wilcox
2018-02-14 20:14 ` Matthew Wilcox
2018-02-15 15:55 ` Christopher Lameter
2018-02-15 15:55 ` Christopher Lameter
2018-02-15 16:23 ` Matthew Wilcox
2018-02-15 16:23 ` Matthew Wilcox
2018-02-15 17:06 ` Christopher Lameter
2018-02-15 17:06 ` Christopher Lameter
2018-02-22 1:28 ` Kees Cook
2018-02-22 1:28 ` Kees Cook
2018-05-04 7:42 ` Linus Torvalds
2018-05-04 13:14 ` Matthew Wilcox
2018-05-04 15:35 ` Linus Torvalds
2018-05-04 16:03 ` Kees Cook
2018-02-14 18:47 ` [PATCH 0/2] Add kvzalloc_struct to complement kvzalloc_array Joe Perches
2018-02-14 18:47 ` Joe Perches
2018-02-14 19:23 ` Kees Cook
2018-02-14 19:23 ` Kees Cook
2018-02-14 19:32 ` Joe Perches
2018-02-14 19:32 ` Joe Perches
2018-02-14 19:36 ` Matthew Wilcox
2018-02-14 19:36 ` Matthew Wilcox
2018-02-14 19:43 ` Joe Perches
2018-02-14 19:43 ` Joe Perches
2018-02-14 19:43 ` Joe Perches
2018-02-14 19:56 ` Matthew Wilcox
2018-02-14 19:56 ` Matthew Wilcox
2018-02-14 20:06 ` Joe Perches
2018-02-14 20:06 ` Joe Perches
2018-02-14 20:06 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1803131935160.3117@hadrien \
--to=julia.lawall@lip6.fr \
--cc=akpm@linux-foundation.org \
--cc=cocci@systeme.lip6.fr \
--cc=himanshujha199640@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mawilcox@microsoft.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.