* [PATCH v2] Replace explicit use of function name with "%s...", __func__
@ 2018-04-10 20:14 Nishka Dasgupta
2018-04-10 20:20 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2018-04-10 20:14 UTC (permalink / raw)
To: outreachy-kernel, gregkh, mchehab; +Cc: Nishka Dasgupta
Replace use of function name with "%s...", __func__ to make future
modifications to the respective functions easier to handle. Issue found
with checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v2:
- Similar changes previously distributed across a patchset are now in a single patch.
- Reason for the change added to commit message.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 6a3434c..a59ab6f 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -696,21 +696,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
if (!gamma->bypass_r && !gamma_param->table_r) {
dev_err(dev,
- "ipipe_get_gamma_params: table ptr empty for R\n");
+ "%s: table ptr empty for R\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_r, gamma->table_r,
(table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
if (!gamma->bypass_g && !gamma_param->table_g) {
- dev_err(dev, "ipipe_get_gamma_params: table ptr empty for G\n");
+ dev_err(dev, "%s: table ptr empty for G\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_g, gamma->table_g,
(table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
if (!gamma->bypass_b && !gamma_param->table_b) {
- dev_err(dev, "ipipe_get_gamma_params: table ptr empty for B\n");
+ dev_err(dev, "%s: table ptr empty for B\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_b, gamma->table_b,
@@ -743,7 +743,7 @@ static int ipipe_get_3d_lut_params(struct vpfe_ipipe_device *ipipe, void *param)
lut_param->en = lut->en;
if (!lut_param->table) {
- dev_err(dev, "ipipe_get_3d_lut_params: Invalid table ptr\n");
+ dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
@@ -924,7 +924,7 @@ static int ipipe_get_gbce_params(struct vpfe_ipipe_device *ipipe, void *param)
gbce_param->en = gbce->en;
gbce_param->type = gbce->type;
if (!gbce_param->table) {
- dev_err(dev, "ipipe_get_gbce_params: Invalid table ptr\n");
+ dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v2] Replace explicit use of function name with "%s...", __func__
2018-04-10 20:14 [PATCH v2] Replace explicit use of function name with "%s...", __func__ Nishka Dasgupta
@ 2018-04-10 20:20 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2018-04-10 20:20 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel, gregkh, mchehab
On Tue, 10 Apr 2018, Nishka Dasgupta wrote:
> Replace use of function name with "%s...", __func__ to make future
> modifications to the respective functions easier to handle. Issue found
> with checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
> Changes in v2:
> - Similar changes previously distributed across a patchset are now in a single patch.
> - Reason for the change added to commit message.
>
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 6a3434c..a59ab6f 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -696,21 +696,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
>
> if (!gamma->bypass_r && !gamma_param->table_r) {
> dev_err(dev,
> - "ipipe_get_gamma_params: table ptr empty for R\n");
> + "%s: table ptr empty for R\n", __func__);
The added line could move up to the same line as the dev_err call.
julia
> return -EINVAL;
> }
> memcpy(gamma_param->table_r, gamma->table_r,
> (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
>
> if (!gamma->bypass_g && !gamma_param->table_g) {
> - dev_err(dev, "ipipe_get_gamma_params: table ptr empty for G\n");
> + dev_err(dev, "%s: table ptr empty for G\n", __func__);
> return -EINVAL;
> }
> memcpy(gamma_param->table_g, gamma->table_g,
> (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
>
> if (!gamma->bypass_b && !gamma_param->table_b) {
> - dev_err(dev, "ipipe_get_gamma_params: table ptr empty for B\n");
> + dev_err(dev, "%s: table ptr empty for B\n", __func__);
> return -EINVAL;
> }
> memcpy(gamma_param->table_b, gamma->table_b,
> @@ -743,7 +743,7 @@ static int ipipe_get_3d_lut_params(struct vpfe_ipipe_device *ipipe, void *param)
>
> lut_param->en = lut->en;
> if (!lut_param->table) {
> - dev_err(dev, "ipipe_get_3d_lut_params: Invalid table ptr\n");
> + dev_err(dev, "%s: Invalid table ptr\n", __func__);
> return -EINVAL;
> }
>
> @@ -924,7 +924,7 @@ static int ipipe_get_gbce_params(struct vpfe_ipipe_device *ipipe, void *param)
> gbce_param->en = gbce->en;
> gbce_param->type = gbce->type;
> if (!gbce_param->table) {
> - dev_err(dev, "ipipe_get_gbce_params: Invalid table ptr\n");
> + dev_err(dev, "%s: Invalid table ptr\n", __func__);
> return -EINVAL;
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1523391296-5535-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] Replace explicit use of function name with "%s...", __func__
@ 2018-04-10 20:34 Nishka Dasgupta
2018-04-10 20:39 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2018-04-10 20:34 UTC (permalink / raw)
To: outreachy-kernel, gregkh, mchehab; +Cc: Nishka Dasgupta
Replace use of function name with "%s...", __func__ to make future
modifications to the respective functions easier to handle. Issue found
with checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v2:
- Moved modified section to previous line.
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 6a3434c..90c4ddd 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -695,22 +695,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
table_size = gamma->tbl_size;
if (!gamma->bypass_r && !gamma_param->table_r) {
- dev_err(dev,
- "ipipe_get_gamma_params: table ptr empty for R\n");
+ dev_err(dev, "%s: table ptr empty for R\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_r, gamma->table_r,
(table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
if (!gamma->bypass_g && !gamma_param->table_g) {
- dev_err(dev, "ipipe_get_gamma_params: table ptr empty for G\n");
+ dev_err(dev, "%s: table ptr empty for G\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_g, gamma->table_g,
(table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
if (!gamma->bypass_b && !gamma_param->table_b) {
- dev_err(dev, "ipipe_get_gamma_params: table ptr empty for B\n");
+ dev_err(dev, "%s: table ptr empty for B\n", __func__);
return -EINVAL;
}
memcpy(gamma_param->table_b, gamma->table_b,
@@ -743,7 +742,7 @@ static int ipipe_get_3d_lut_params(struct vpfe_ipipe_device *ipipe, void *param)
lut_param->en = lut->en;
if (!lut_param->table) {
- dev_err(dev, "ipipe_get_3d_lut_params: Invalid table ptr\n");
+ dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
@@ -924,7 +923,7 @@ static int ipipe_get_gbce_params(struct vpfe_ipipe_device *ipipe, void *param)
gbce_param->en = gbce->en;
gbce_param->type = gbce->type;
if (!gbce_param->table) {
- dev_err(dev, "ipipe_get_gbce_params: Invalid table ptr\n");
+ dev_err(dev, "%s: Invalid table ptr\n", __func__);
return -EINVAL;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Outreachy kernel] [PATCH v2] Replace explicit use of function name with "%s...", __func__
2018-04-10 20:34 Nishka Dasgupta
@ 2018-04-10 20:39 ` Julia Lawall
0 siblings, 0 replies; 3+ messages in thread
From: Julia Lawall @ 2018-04-10 20:39 UTC (permalink / raw)
To: Nishka Dasgupta; +Cc: outreachy-kernel, gregkh, mchehab
On Tue, 10 Apr 2018, Nishka Dasgupta wrote:
> Replace use of function name with "%s...", __func__ to make future
> modifications to the respective functions easier to handle. Issue found
> with checkpatch.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
> Changes in v2:
> - Moved modified section to previous line.
The previous patch was also v2.
julia
>
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> index 6a3434c..90c4ddd 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -695,22 +695,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)
> table_size = gamma->tbl_size;
>
> if (!gamma->bypass_r && !gamma_param->table_r) {
> - dev_err(dev,
> - "ipipe_get_gamma_params: table ptr empty for R\n");
> + dev_err(dev, "%s: table ptr empty for R\n", __func__);
> return -EINVAL;
> }
> memcpy(gamma_param->table_r, gamma->table_r,
> (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
>
> if (!gamma->bypass_g && !gamma_param->table_g) {
> - dev_err(dev, "ipipe_get_gamma_params: table ptr empty for G\n");
> + dev_err(dev, "%s: table ptr empty for G\n", __func__);
> return -EINVAL;
> }
> memcpy(gamma_param->table_g, gamma->table_g,
> (table_size * sizeof(struct vpfe_ipipe_gamma_entry)));
>
> if (!gamma->bypass_b && !gamma_param->table_b) {
> - dev_err(dev, "ipipe_get_gamma_params: table ptr empty for B\n");
> + dev_err(dev, "%s: table ptr empty for B\n", __func__);
> return -EINVAL;
> }
> memcpy(gamma_param->table_b, gamma->table_b,
> @@ -743,7 +742,7 @@ static int ipipe_get_3d_lut_params(struct vpfe_ipipe_device *ipipe, void *param)
>
> lut_param->en = lut->en;
> if (!lut_param->table) {
> - dev_err(dev, "ipipe_get_3d_lut_params: Invalid table ptr\n");
> + dev_err(dev, "%s: Invalid table ptr\n", __func__);
> return -EINVAL;
> }
>
> @@ -924,7 +923,7 @@ static int ipipe_get_gbce_params(struct vpfe_ipipe_device *ipipe, void *param)
> gbce_param->en = gbce->en;
> gbce_param->type = gbce->type;
> if (!gbce_param->table) {
> - dev_err(dev, "ipipe_get_gbce_params: Invalid table ptr\n");
> + dev_err(dev, "%s: Invalid table ptr\n", __func__);
> return -EINVAL;
> }
>
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1523392484-5746-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-10 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-10 20:14 [PATCH v2] Replace explicit use of function name with "%s...", __func__ Nishka Dasgupta
2018-04-10 20:20 ` [Outreachy kernel] " Julia Lawall
2018-04-10 20:34 Nishka Dasgupta
2018-04-10 20:39 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.