* [PATCH] leds: lm3601x: fix semicolon.cocci warnings
@ 2018-05-09 8:26 Julia Lawall
2018-05-09 11:34 ` Dan Murphy
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2018-05-09 8:26 UTC (permalink / raw)
To: Dan Murphy
Cc: robh+dt, mark.rutland, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds, kbuild-all
From: Fengguang Wu <fengguang.wu@intel.com>
Remove unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
CC: Dan Murphy <dmurphy@ti.com>
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
---
url:
https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
for-next
:::::: branch date: 5 hours ago
:::::: commit date: 5 hours ago
I also received the following comment, but no other details. It would be
good to check what is going on on the mentioned lines.
>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
leds-lm3601x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/leds/leds-lm3601x.c
+++ b/drivers/leds/leds-lm3601x.c
@@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
ret = -EINVAL;
goto out;
- };
+ }
if (led->strobe_timeout != current_timeout)
ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings
2018-05-09 8:26 [PATCH] leds: lm3601x: fix semicolon.cocci warnings Julia Lawall
@ 2018-05-09 11:34 ` Dan Murphy
0 siblings, 0 replies; 3+ messages in thread
From: Dan Murphy @ 2018-05-09 11:34 UTC (permalink / raw)
To: Julia Lawall
Cc: robh+dt, mark.rutland, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds, kbuild-all
All
On 05/09/2018 03:26 AM, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
> CC: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> url:
> https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
> I also received the following comment, but no other details. It would be
> good to check what is going on on the mentioned lines.
>
>>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
>
> leds-lm3601x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/leds/leds-lm3601x.c
> +++ b/drivers/leds/leds-lm3601x.c
> @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
>
> ret = -EINVAL;
> goto out;
> - };
> + }
>
I will fix this in v3 of the patch submission.
Dan
> if (led->strobe_timeout != current_timeout)
> ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] leds: lm3601x: fix semicolon.cocci warnings
@ 2018-05-09 11:34 ` Dan Murphy
0 siblings, 0 replies; 3+ messages in thread
From: Dan Murphy @ 2018-05-09 11:34 UTC (permalink / raw)
To: Julia Lawall
Cc: robh+dt, mark.rutland, jacek.anaszewski, pavel, devicetree,
linux-kernel, linux-leds, kbuild-all
All
On 05/09/2018 03:26 AM, Julia Lawall wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
>
> Remove unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> Fixes: b550389fcb74 ("leds: lm3601x: Introduce the lm3601x LED driver")
> CC: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> url:
> https://github.com/0day-ci/linux/commits/Dan-Murphy/dt-bindings-lm3601x-Introduce-the-lm3601x-driver/20180509-033939
> base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git
> for-next
> :::::: branch date: 5 hours ago
> :::::: commit date: 5 hours ago
>
> I also received the following comment, but no other details. It would be
> good to check what is going on on the mentioned lines.
>
>>> drivers/leds/leds-lm3601x.c:315:2-8: preceding lock on line 311
>
> leds-lm3601x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/leds/leds-lm3601x.c
> +++ b/drivers/leds/leds-lm3601x.c
> @@ -234,7 +234,7 @@ static int lm3601x_strobe_set(struct led
>
> ret = -EINVAL;
> goto out;
> - };
> + }
>
I will fix this in v3 of the patch submission.
Dan
> if (led->strobe_timeout != current_timeout)
> ret = regmap_update_bits(led->regmap, LM3601X_CFG_REG,
>
--
------------------
Dan Murphy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-09 11:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-09 8:26 [PATCH] leds: lm3601x: fix semicolon.cocci warnings Julia Lawall
2018-05-09 11:34 ` Dan Murphy
2018-05-09 11:34 ` Dan Murphy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.