* [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-30 15:09 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2018-05-30 15:09 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment dev = dev is redundant and should be removed.
Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/bpf/devmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index ae16d0c373ef..1fe3fe60508a 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
{
struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
- struct net_device *dev = dev = obj ? obj->dev : NULL;
+ struct net_device *dev = obj ? obj->dev : NULL;
return dev ? &dev->ifindex : NULL;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-30 15:09 ` Colin King
0 siblings, 0 replies; 10+ messages in thread
From: Colin King @ 2018-05-30 15:09 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, netdev; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment dev = dev is redundant and should be removed.
Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
kernel/bpf/devmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
index ae16d0c373ef..1fe3fe60508a 100644
--- a/kernel/bpf/devmap.c
+++ b/kernel/bpf/devmap.c
@@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
{
struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
- struct net_device *dev = dev = obj ? obj->dev : NULL;
+ struct net_device *dev = obj ? obj->dev : NULL;
return dev ? &dev->ifindex : NULL;
}
--
2.17.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
2018-05-30 15:09 ` Colin King
@ 2018-05-30 17:18 ` Song Liu
-1 siblings, 0 replies; 10+ messages in thread
From: Song Liu @ 2018-05-30 17:18 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, Networking, kernel-janitors,
open list
On Wed, May 30, 2018 at 8:09 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment dev = dev is redundant and should be removed.
>
> Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> kernel/bpf/devmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index ae16d0c373ef..1fe3fe60508a 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
> static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
> {
> struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
> - struct net_device *dev = dev = obj ? obj->dev : NULL;
> + struct net_device *dev = obj ? obj->dev : NULL;
>
> return dev ? &dev->ifindex : NULL;
> }
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-30 17:18 ` Song Liu
0 siblings, 0 replies; 10+ messages in thread
From: Song Liu @ 2018-05-30 17:18 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, Networking, kernel-janitors,
open list
On Wed, May 30, 2018 at 8:09 AM, Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment dev = dev is redundant and should be removed.
>
> Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Song Liu <songliubraving@fb.com>
> ---
> kernel/bpf/devmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/bpf/devmap.c b/kernel/bpf/devmap.c
> index ae16d0c373ef..1fe3fe60508a 100644
> --- a/kernel/bpf/devmap.c
> +++ b/kernel/bpf/devmap.c
> @@ -352,7 +352,7 @@ int dev_map_enqueue(struct bpf_dtab_netdev *dst, struct xdp_buff *xdp,
> static void *dev_map_lookup_elem(struct bpf_map *map, void *key)
> {
> struct bpf_dtab_netdev *obj = __dev_map_lookup_elem(map, *(u32 *)key);
> - struct net_device *dev = dev = obj ? obj->dev : NULL;
> + struct net_device *dev = obj ? obj->dev : NULL;
>
> return dev ? &dev->ifindex : NULL;
> }
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
2018-05-30 15:09 ` Colin King
@ 2018-05-30 21:07 ` Alexei Starovoitov
-1 siblings, 0 replies; 10+ messages in thread
From: Alexei Starovoitov @ 2018-05-30 21:07 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, netdev, kernel-janitors,
linux-kernel
On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment dev = dev is redundant and should be removed.
>
> Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, Thanks.
Please use [PATCH bpf-next] in the subject next time.
See Documentation/bpf/bpf_devel_QA.rst
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-30 21:07 ` Alexei Starovoitov
0 siblings, 0 replies; 10+ messages in thread
From: Alexei Starovoitov @ 2018-05-30 21:07 UTC (permalink / raw)
To: Colin King
Cc: Alexei Starovoitov, Daniel Borkmann, netdev, kernel-janitors,
linux-kernel
On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment dev = dev is redundant and should be removed.
>
> Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied, Thanks.
Please use [PATCH bpf-next] in the subject next time.
See Documentation/bpf/bpf_devel_QA.rst
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
2018-05-30 21:07 ` Alexei Starovoitov
@ 2018-05-31 7:05 ` Dan Carpenter
-1 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2018-05-31 7:05 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Colin King, Alexei Starovoitov, Daniel Borkmann, netdev,
kernel-janitors, linux-kernel
On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The assignment dev = dev is redundant and should be removed.
> >
> > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Applied, Thanks.
>
> Please use [PATCH bpf-next] in the subject next time.
> See Documentation/bpf/bpf_devel_QA.rst
Guys, be reasonable...
git log --author=Carpenter | \
grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>" | \
grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l
I have sent patches to 206 maintainers. It doesn't scale for everyone
to have their own special document for sending patches.
I asked this last time, and I even skimmed your document, but how are
people supposed to go from linux-next to the correct bpf-next git tree?
It's a pain for me to do this for net, but net is way larger and busier
than any other tree. I know it's a bit rude for me to say that you guys
are not as important as net, but that's how I feel. I'm only going to
report bugs instead of writing patches if you guys are going to insist
on all sorts of new rules.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-31 7:05 ` Dan Carpenter
0 siblings, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2018-05-31 7:05 UTC (permalink / raw)
To: Alexei Starovoitov
Cc: Colin King, Alexei Starovoitov, Daniel Borkmann, netdev,
kernel-janitors, linux-kernel
On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The assignment dev = dev is redundant and should be removed.
> >
> > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
> Applied, Thanks.
>
> Please use [PATCH bpf-next] in the subject next time.
> See Documentation/bpf/bpf_devel_QA.rst
Guys, be reasonable...
git log --authorÊrpenter | \
grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>" | \
grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l
I have sent patches to 206 maintainers. It doesn't scale for everyone
to have their own special document for sending patches.
I asked this last time, and I even skimmed your document, but how are
people supposed to go from linux-next to the correct bpf-next git tree?
It's a pain for me to do this for net, but net is way larger and busier
than any other tree. I know it's a bit rude for me to say that you guys
are not as important as net, but that's how I feel. I'm only going to
report bugs instead of writing patches if you guys are going to insist
on all sorts of new rules.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
2018-05-31 7:05 ` Dan Carpenter
@ 2018-05-31 8:14 ` Julia Lawall
-1 siblings, 0 replies; 10+ messages in thread
From: Julia Lawall @ 2018-05-31 8:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexei Starovoitov, Colin King, Alexei Starovoitov,
Daniel Borkmann, netdev, kernel-janitors, linux-kernel
On Thu, 31 May 2018, Dan Carpenter wrote:
> On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> > On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > The assignment dev = dev is redundant and should be removed.
> > >
> > > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> > >
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >
> > Applied, Thanks.
> >
> > Please use [PATCH bpf-next] in the subject next time.
> > See Documentation/bpf/bpf_devel_QA.rst
>
> Guys, be reasonable...
>
> git log --author=Carpenter | \
> grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>" | \
> grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l
>
> I have sent patches to 206 maintainers. It doesn't scale for everyone
> to have their own special document for sending patches.
Thanks Dan, I support this point of view completely. Special information
has to be in one place and in a machine readable manner. Maybe
get_maintainers can produce this information in some way, if it is
essential.
julia
>
> I asked this last time, and I even skimmed your document, but how are
> people supposed to go from linux-next to the correct bpf-next git tree?
> It's a pain for me to do this for net, but net is way larger and busier
> than any other tree. I know it's a bit rude for me to say that you guys
> are not as important as net, but that's how I feel. I'm only going to
> report bugs instead of writing patches if you guys are going to insist
> on all sorts of new rules.
>
> regards,
> dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev
@ 2018-05-31 8:14 ` Julia Lawall
0 siblings, 0 replies; 10+ messages in thread
From: Julia Lawall @ 2018-05-31 8:14 UTC (permalink / raw)
To: Dan Carpenter
Cc: Alexei Starovoitov, Colin King, Alexei Starovoitov,
Daniel Borkmann, netdev, kernel-janitors, linux-kernel
On Thu, 31 May 2018, Dan Carpenter wrote:
> On Wed, May 30, 2018 at 05:07:15PM -0400, Alexei Starovoitov wrote:
> > On Wed, May 30, 2018 at 04:09:16PM +0100, Colin King wrote:
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > The assignment dev = dev is redundant and should be removed.
> > >
> > > Detected by CoverityScan, CID#1469486 ("Evaluation order violation")
> > >
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> >
> > Applied, Thanks.
> >
> > Please use [PATCH bpf-next] in the subject next time.
> > See Documentation/bpf/bpf_devel_QA.rst
>
> Guys, be reasonable...
>
> git log --authorÊrpenter | \
> grep -A1 "Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>" | \
> grep -v Carpenter | grep Signed | cut -d '<' -f 1 | sort -u | wc -l
>
> I have sent patches to 206 maintainers. It doesn't scale for everyone
> to have their own special document for sending patches.
Thanks Dan, I support this point of view completely. Special information
has to be in one place and in a machine readable manner. Maybe
get_maintainers can produce this information in some way, if it is
essential.
julia
>
> I asked this last time, and I even skimmed your document, but how are
> people supposed to go from linux-next to the correct bpf-next git tree?
> It's a pain for me to do this for net, but net is way larger and busier
> than any other tree. I know it's a bit rude for me to say that you guys
> are not as important as net, but that's how I feel. I'm only going to
> report bugs instead of writing patches if you guys are going to insist
> on all sorts of new rules.
>
> regards,
> dan carpenter
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2018-05-31 8:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-30 15:09 [PATCH][next] bpf: devmap: remove redundant assignment of dev = dev Colin King
2018-05-30 15:09 ` Colin King
2018-05-30 17:18 ` Song Liu
2018-05-30 17:18 ` Song Liu
2018-05-30 21:07 ` Alexei Starovoitov
2018-05-30 21:07 ` Alexei Starovoitov
2018-05-31 7:05 ` Dan Carpenter
2018-05-31 7:05 ` Dan Carpenter
2018-05-31 8:14 ` Julia Lawall
2018-05-31 8:14 ` Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.