[Cocci] Perforce support, or generating list of files that would be changed?

[Cocci] Perforce support, or generating list of files that would be changed?

[Timur Tabi]

I need to run the "p4 edit" command before spatch can modify any file.
Is there a way to do either of the following:

1. Provide a list of files that "spatch --in-place --dir ." would edit
2. Have spatch run the "p4 edit" command on a file before changing it

[Cocci] Perforce support, or generating list of files that would be changed?

[Julia Lawall]

On Thu, 26 Jul 2018, Timur Tabi wrote:

> I need to run the "p4 edit" command before spatch can modify any file.
> Is there a way to do either of the following:
>
> 1. Provide a list of files that "spatch --in-place --dir ." would edit

I'm not sure to understand what you are asking for here.

> 2. Have spatch run the "p4 edit" command on a file before changing it

I don't think so.  Maybe you could make a script to do this.

julia

[Cocci] Perforce support, or generating list of files that would be changed?

[Timur Tabi]

On Thu, Jul 26, 2018 at 3:26 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:

>> 1. Provide a list of files that "spatch --in-place --dir ." would edit
>
> I'm not sure to understand what you are asking for here.

So when I run "spatch --in-place --dir .", spatch run my cocci script
on a bunch of files, but not all of them will need to be changed.  For
some, there won't be a match.

I would like a list of files that spatch *would* change in this
situation.  Something like "spatch --list-only", so I can do this:

$ p4 edit `spatch --sp-file nvprintf.cocci --in-place --list-only --dir .`
$ spatch --sp-file nvprintf.cocci --in-place --list-only --dir .

[Cocci] Perforce support, or generating list of files that would be changed?

[Julia Lawall]

On Thu, 26 Jul 2018, Timur Tabi wrote:

> On Thu, Jul 26, 2018 at 3:26 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
>
> >> 1. Provide a list of files that "spatch --in-place --dir ." would edit
> >
> > I'm not sure to understand what you are asking for here.
>
> So when I run "spatch --in-place --dir .", spatch run my cocci script
> on a bunch of files, but not all of them will need to be changed.  For
> some, there won't be a match.
>
> I would like a list of files that spatch *would* change in this
> situation.  Something like "spatch --list-only", so I can do this:
>
> $ p4 edit `spatch --sp-file nvprintf.cocci --in-place --list-only --dir .`
> $ spatch --sp-file nvprintf.cocci --in-place --list-only --dir .

Coccinelle can make a list of relevant files, but there is not a guarantee
that the rule will actually match on those files.  The option is
--selected-only.

julia

[Cocci] Perforce support, or generating list of files that would be changed?

[Timur Tabi]

On Thu, Jul 26, 2018 at 3:42 PM, Julia Lawall <julia.lawall@lip6.fr> wrote:
> Coccinelle can make a list of relevant files, but there is not a guarantee
> that the rule will actually match on those files.  The option is
> --selected-only.

Thanks, that works.  I also discovered that this works:

spatch --very-quiet --dir .   | lsdiff --strip 1