From: Martin Olsson <martin.olsson+netdev@sentorsecurity.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
netdev@vger.kernel.org, Jiri Pirko <jiri@resnulli.us>,
Lucas Bates <lucasb@mojatatu.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter
Date: Mon, 14 Jan 2019 10:15:40 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1901141008090.1510@localhost.localdomain> (raw)
In-Reply-To: <b7c845f1-be54-79a2-694d-f9db78bcad69@mojatatu.com>
> "did this setup use to work before? If yes, rough idea of which
> kernels?"
Unknown. I haven't tried it before.
/Martin
On Sat, 12 Jan 2019, Jamal Hadi Salim wrote:
> On 2019-01-11 9:55 p.m., Cong Wang wrote:
>> Martin reported a set of filters don't work after changing
>> from reclassify to continue. Looking into the code, it
>> looks like skb protocol is not always fetched for each
>> iteration of the filters. But, as demonstrated by Martin,
>> TC actions could modify skb->protocol, for example act_vlan,
>> this means we have to refetch skb protocol in each iteration,
>> rather than using the one we fetch in the beginning of the loop.
>>
>> This bug is _not_ introduced by commit 3b3ae880266d
>> ("net: sched: consolidate tc_classify{,_compat}"), technically,
>> if act_vlan is the only action that modifies skb protocol, then
>> it is commit c7e2b9689ef8 ("sched: introduce vlan action") which
>> introduced this bug.
>>
>
> +Cc Lucas
> Do we have a test case for a setup like this in tdc?
> i.e incoming tagged and then vlan popped by action?
> Otherwise a test with IFE which resets the ethertype
> would be sufficient i.e just something that will messup
> with skb->protocol.
> Cong,
> I am a little worried about the impact of this change. Smells
> more like it has to do with Vlan action or related issues
> than with reclassifying.
> Martin,
> did this setup use to work before? If yes, rough idea of
> which kernels?
>
> cheers,
> jamal
>
>
next prev parent reply other threads:[~2019-01-14 9:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-12 2:55 [Patch net] net_sched: refetch skb protocol for each filter Cong Wang
2019-01-12 12:23 ` Jamal Hadi Salim
2019-01-12 15:41 ` Jamal Hadi Salim
2019-01-13 21:08 ` Cong Wang
2019-01-15 15:59 ` Jamal Hadi Salim
2019-01-15 16:21 ` Jamal Hadi Salim
2019-01-15 17:57 ` Cong Wang
2019-01-16 14:02 ` Jamal Hadi Salim
2019-01-15 17:52 ` Cong Wang
2019-01-13 20:58 ` Cong Wang
2019-01-15 15:14 ` Jamal Hadi Salim
2019-01-14 9:15 ` Martin Olsson [this message]
2019-01-15 15:19 ` Jamal Hadi Salim
2019-01-14 23:13 ` Lucas Bates
2019-01-14 9:23 ` Daniel Borkmann
2019-01-14 19:55 ` Cong Wang
2019-01-16 13:59 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1901141008090.1510@localhost.localdomain \
--to=martin.olsson+netdev@sentorsecurity.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucasb@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.