All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cong Wang <xiyou.wangcong@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
	Martin Olsson <martin.olsson+netdev@sentorsecurity.com>,
	Jiri Pirko <jiri@resnulli.us>, Lucas Bates <lucasb@mojatatu.com>
Subject: Re: [Patch net] net_sched: refetch skb protocol for each filter
Date: Tue, 15 Jan 2019 09:52:08 -0800	[thread overview]
Message-ID: <CAM_iQpVDay1SHwuXFZN0kS=RJ6_2inT+4NujLL4bBgj4M6xjdA@mail.gmail.com> (raw)
In-Reply-To: <53f2ac1d-ea4c-b779-c4a7-6268758f87bf@mojatatu.com>

On Tue, Jan 15, 2019 at 7:59 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
>
> On 2019-01-13 4:08 p.m., Cong Wang wrote:
> > On Sat, Jan 12, 2019 at 7:41 AM Jamal Hadi Salim <jhs@mojatatu.com> wrote:
> >>
> >> On 2019-01-12 7:23 a.m., Jamal Hadi Salim wrote:
> >>
> >>> Do we have a test case for a setup like this in tdc?
> >>> i.e incoming tagged and then vlan popped by action?
> >>> Otherwise a test with IFE which resets the ethertype
> >>> would be sufficient i.e just something that will messup
> >>> with skb->protocol.
> >>
> >> And here is a slightly complex test with IFE.
> >> Wanted to show both reclassify and continue in play
> >> as well as something that change skb->protocol.
> >>
> >
> > I don't know why you need a complex one, Martin's
> > test case is pretty simple (as I already sent to you).
> >
>
> Martin example had a "reclassify" with the vlan pop.
> Your example was showing a "continue"
> Note: "Reclassify" is typical how we have explained
> to users to deal with skb->protocol changes.


You have to re-read Martin's example, he clearly showed
"reclassify" works but not "continue". This is exactly why
I have "continue" in my script, as I need to test what I fix.


> Lets have Lucas give this a run and we can move
> forward.

Sure.

Thanks.

  parent reply	other threads:[~2019-01-15 17:52 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-12  2:55 [Patch net] net_sched: refetch skb protocol for each filter Cong Wang
2019-01-12 12:23 ` Jamal Hadi Salim
2019-01-12 15:41   ` Jamal Hadi Salim
2019-01-13 21:08     ` Cong Wang
2019-01-15 15:59       ` Jamal Hadi Salim
2019-01-15 16:21         ` Jamal Hadi Salim
2019-01-15 17:57           ` Cong Wang
2019-01-16 14:02             ` Jamal Hadi Salim
2019-01-15 17:52         ` Cong Wang [this message]
2019-01-13 20:58   ` Cong Wang
2019-01-15 15:14     ` Jamal Hadi Salim
2019-01-14  9:15   ` Martin Olsson
2019-01-15 15:19     ` Jamal Hadi Salim
2019-01-14 23:13   ` Lucas Bates
2019-01-14  9:23 ` Daniel Borkmann
2019-01-14 19:55   ` Cong Wang
2019-01-16 13:59 ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAM_iQpVDay1SHwuXFZN0kS=RJ6_2inT+4NujLL4bBgj4M6xjdA@mail.gmail.com' \
    --to=xiyou.wangcong@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=lucasb@mojatatu.com \
    --cc=martin.olsson+netdev@sentorsecurity.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.