* [PATCH] staging: mt7621-eth: add SPDX GPL-2.0 license identifier
@ 2019-02-25 15:48 Jules Irenge
2019-02-25 15:56 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Jules Irenge @ 2019-02-25 15:48 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, Jules Irenge
adds SPDX GPL-2.0 license to clear missing or malformed SPDX warning
Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
---
drivers/staging/mt7621-eth/ethtool.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
index 40b4cf011660..d0e97ae0d82e 100644
--- a/drivers/staging/mt7621-eth/ethtool.h
+++ b/drivers/staging/mt7621-eth/ethtool.h
@@ -1,3 +1,4 @@
+/* SPDX-License-Identifier: GPL-2.0 */
/* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: mt7621-eth: add SPDX GPL-2.0 license identifier
2019-02-25 15:48 [PATCH] staging: mt7621-eth: add SPDX GPL-2.0 license identifier Jules Irenge
@ 2019-02-25 15:56 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-02-25 15:56 UTC (permalink / raw)
To: Jules Irenge; +Cc: gregkh, outreachy-kernel
On Mon, 25 Feb 2019, Jules Irenge wrote:
> adds SPDX GPL-2.0 license to clear missing or malformed SPDX warning
The log message should be written in he imperative, and should be a
well-formed sentence, ie beginning with a capital letter and ending with a
period. So "Add...". The purpose of doing something should also be more
than clearing a warning. On the other hand, at the same time, it would be
nice to give credit to the tool that made that warning.
julia
>
> Signed-off-by: Jules Irenge <jbi.octave@gmail.com>
> ---
> drivers/staging/mt7621-eth/ethtool.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/mt7621-eth/ethtool.h b/drivers/staging/mt7621-eth/ethtool.h
> index 40b4cf011660..d0e97ae0d82e 100644
> --- a/drivers/staging/mt7621-eth/ethtool.h
> +++ b/drivers/staging/mt7621-eth/ethtool.h
> @@ -1,3 +1,4 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /* This program is free software; you can redistribute it and/or modify
> * it under the terms of the GNU General Public License as published by
> * the Free Software Foundation; version 2 of the License
> --
> 2.20.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190225154857.13368-1-jbi.octave%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-02-25 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-25 15:48 [PATCH] staging: mt7621-eth: add SPDX GPL-2.0 license identifier Jules Irenge
2019-02-25 15:56 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.