* [PATCH] staging: rtl8723bs: include: Fix indentation and spacing issues
@ 2019-03-25 3:15 Sammy Abed
2019-03-25 16:14 ` [Outreachy kernel] " Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Sammy Abed @ 2019-03-25 3:15 UTC (permalink / raw)
To: gregkh; +Cc: outreachy-kernel, abdlwahdsa
Replaced spaces with tabs at the beginning of lines.
Added spaces around a (+) operator.
Signed-off-by: Sammy Abed <abdlwahdsa@gmail.com>
---
.../staging/rtl8723bs/include/wlan_bssdef.h | 56 +++++++++----------
1 file changed, 28 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
index bdb14a84e5a5..88890b1c3c4c 100644
--- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
+++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
@@ -129,15 +129,15 @@ struct ndis_801_11_ai_resfi {
typedef struct _NDIS_802_11_ASSOCIATION_INFORMATION
{
- u32 Length;
- u16 AvailableRequestFixedIEs;
- struct ndis_802_11_ai_reqfi RequestFixedIEs;
- u32 RequestIELength;
- u32 OffsetRequestIEs;
- u16 AvailableResponseFixedIEs;
- struct ndis_801_11_ai_resfi ResponseFixedIEs;
- u32 ResponseIELength;
- u32 OffsetResponseIEs;
+ u32 Length;
+ u16 AvailableRequestFixedIEs;
+ struct ndis_802_11_ai_reqfi RequestFixedIEs;
+ u32 RequestIELength;
+ u32 OffsetRequestIEs;
+ u16 AvailableResponseFixedIEs;
+ struct ndis_801_11_ai_resfi ResponseFixedIEs;
+ u32 ResponseIELength;
+ u32 OffsetResponseIEs;
} NDIS_802_11_ASSOCIATION_INFORMATION, *PNDIS_802_11_ASSOCIATION_INFORMATION;
enum NDIS_802_11_RELOAD_DEFAULTS {
@@ -148,19 +148,19 @@ enum NDIS_802_11_RELOAD_DEFAULTS {
/* Key mapping keys require a BSSID */
typedef struct _NDIS_802_11_KEY
{
- u32 Length; /* Length of this structure */
- u32 KeyIndex;
- u32 KeyLength; /* length of key in bytes */
- NDIS_802_11_MAC_ADDRESS BSSID;
- unsigned long long KeyRSC;
- u8 KeyMaterial[32]; /* variable length depending on above field */
+ u32 Length; /* Length of this structure */
+ u32 KeyIndex;
+ u32 KeyLength; /* length of key in bytes */
+ NDIS_802_11_MAC_ADDRESS BSSID;
+ unsigned long long KeyRSC;
+ u8 KeyMaterial[32]; /* variable length depending on above field */
} NDIS_802_11_KEY, *PNDIS_802_11_KEY;
typedef struct _NDIS_802_11_REMOVE_KEY
{
- u32 Length; /* Length of this structure */
- u32 KeyIndex;
- NDIS_802_11_MAC_ADDRESS BSSID;
+ u32 Length; /* Length of this structure */
+ u32 KeyIndex;
+ NDIS_802_11_MAC_ADDRESS BSSID;
} NDIS_802_11_REMOVE_KEY, *PNDIS_802_11_REMOVE_KEY;
struct ndis_802_11_wep {
@@ -181,7 +181,7 @@ struct ndis_802_11_wep {
#define MIC_CHECK_TIME 60000000
#ifndef Ndis802_11APMode
-#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
+#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
#endif
struct wlan_phy_info {
@@ -240,15 +240,15 @@ struct wlan_network {
};
enum VRTL_CARRIER_SENSE {
- DISABLE_VCS,
- ENABLE_VCS,
- AUTO_VCS
+ DISABLE_VCS,
+ ENABLE_VCS,
+ AUTO_VCS
};
enum VCS_TYPE {
- NONE_VCS,
- RTS_CTS,
- CTS_TO_SELF
+ NONE_VCS,
+ RTS_CTS,
+ CTS_TO_SELF
};
#define PWR_CAM 0
@@ -259,9 +259,9 @@ enum VCS_TYPE {
enum UAPSD_MAX_SP {
NO_LIMIT,
- TWO_MSDU,
- FOUR_MSDU,
- SIX_MSDU
+ TWO_MSDU,
+ FOUR_MSDU,
+ SIX_MSDU
};
#define NUM_PRE_AUTH_KEY 16
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: include: Fix indentation and spacing issues
2019-03-25 3:15 [PATCH] staging: rtl8723bs: include: Fix indentation and spacing issues Sammy Abed
@ 2019-03-25 16:14 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2019-03-25 16:14 UTC (permalink / raw)
To: Sammy Abed; +Cc: gregkh, outreachy-kernel
There aren't many patches on this file so far, but the one there is only
has staging: rtl8723bs: in the subject line.
On Sun, 24 Mar 2019, Sammy Abed wrote:
> Replaced spaces with tabs at the beginning of lines.
> Added spaces around a (+) operator.
>
> Signed-off-by: Sammy Abed <abdlwahdsa@gmail.com>
> ---
> .../staging/rtl8723bs/include/wlan_bssdef.h | 56 +++++++++----------
> 1 file changed, 28 insertions(+), 28 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/include/wlan_bssdef.h b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> index bdb14a84e5a5..88890b1c3c4c 100644
> --- a/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> +++ b/drivers/staging/rtl8723bs/include/wlan_bssdef.h
> @@ -129,15 +129,15 @@ struct ndis_801_11_ai_resfi {
>
> typedef struct _NDIS_802_11_ASSOCIATION_INFORMATION
When this patch is accepted, you could get rid of these typedefs.
julia
> {
> - u32 Length;
> - u16 AvailableRequestFixedIEs;
> - struct ndis_802_11_ai_reqfi RequestFixedIEs;
> - u32 RequestIELength;
> - u32 OffsetRequestIEs;
> - u16 AvailableResponseFixedIEs;
> - struct ndis_801_11_ai_resfi ResponseFixedIEs;
> - u32 ResponseIELength;
> - u32 OffsetResponseIEs;
> + u32 Length;
> + u16 AvailableRequestFixedIEs;
> + struct ndis_802_11_ai_reqfi RequestFixedIEs;
> + u32 RequestIELength;
> + u32 OffsetRequestIEs;
> + u16 AvailableResponseFixedIEs;
> + struct ndis_801_11_ai_resfi ResponseFixedIEs;
> + u32 ResponseIELength;
> + u32 OffsetResponseIEs;
> } NDIS_802_11_ASSOCIATION_INFORMATION, *PNDIS_802_11_ASSOCIATION_INFORMATION;
>
> enum NDIS_802_11_RELOAD_DEFAULTS {
> @@ -148,19 +148,19 @@ enum NDIS_802_11_RELOAD_DEFAULTS {
> /* Key mapping keys require a BSSID */
> typedef struct _NDIS_802_11_KEY
> {
> - u32 Length; /* Length of this structure */
> - u32 KeyIndex;
> - u32 KeyLength; /* length of key in bytes */
> - NDIS_802_11_MAC_ADDRESS BSSID;
> - unsigned long long KeyRSC;
> - u8 KeyMaterial[32]; /* variable length depending on above field */
> + u32 Length; /* Length of this structure */
> + u32 KeyIndex;
> + u32 KeyLength; /* length of key in bytes */
> + NDIS_802_11_MAC_ADDRESS BSSID;
> + unsigned long long KeyRSC;
> + u8 KeyMaterial[32]; /* variable length depending on above field */
> } NDIS_802_11_KEY, *PNDIS_802_11_KEY;
>
> typedef struct _NDIS_802_11_REMOVE_KEY
> {
> - u32 Length; /* Length of this structure */
> - u32 KeyIndex;
> - NDIS_802_11_MAC_ADDRESS BSSID;
> + u32 Length; /* Length of this structure */
> + u32 KeyIndex;
> + NDIS_802_11_MAC_ADDRESS BSSID;
> } NDIS_802_11_REMOVE_KEY, *PNDIS_802_11_REMOVE_KEY;
>
> struct ndis_802_11_wep {
> @@ -181,7 +181,7 @@ struct ndis_802_11_wep {
> #define MIC_CHECK_TIME 60000000
>
> #ifndef Ndis802_11APMode
> -#define Ndis802_11APMode (Ndis802_11InfrastructureMax+1)
> +#define Ndis802_11APMode (Ndis802_11InfrastructureMax + 1)
> #endif
>
> struct wlan_phy_info {
> @@ -240,15 +240,15 @@ struct wlan_network {
> };
>
> enum VRTL_CARRIER_SENSE {
> - DISABLE_VCS,
> - ENABLE_VCS,
> - AUTO_VCS
> + DISABLE_VCS,
> + ENABLE_VCS,
> + AUTO_VCS
> };
>
> enum VCS_TYPE {
> - NONE_VCS,
> - RTS_CTS,
> - CTS_TO_SELF
> + NONE_VCS,
> + RTS_CTS,
> + CTS_TO_SELF
> };
>
> #define PWR_CAM 0
> @@ -259,9 +259,9 @@ enum VCS_TYPE {
>
> enum UAPSD_MAX_SP {
> NO_LIMIT,
> - TWO_MSDU,
> - FOUR_MSDU,
> - SIX_MSDU
> + TWO_MSDU,
> + FOUR_MSDU,
> + SIX_MSDU
> };
>
> #define NUM_PRE_AUTH_KEY 16
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20190325031503.4616-1-abdlwahdsa%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-25 16:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 3:15 [PATCH] staging: rtl8723bs: include: Fix indentation and spacing issues Sammy Abed
2019-03-25 16:14 ` [Outreachy kernel] " Julia Lawall
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.